Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 27 Sep 2020 11:08:30 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Pujin Shi <shipujin.t@gmail.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: irq: Add missing prototypes for init_IRQ()
Message-ID: <20200927090830.GC4929@alpha.franken.de>
References: <20200923032650.1546-1-shipujin.t@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200923032650.1546-1-shipujin.t@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Wed, Sep 23, 2020 at 11:26:50AM +0800, Pujin Shi wrote:
> init_IRQ() have no prototype, add one in irq.h
> 
> Fix the following warnings (treated as error in W=1):
> arch/mips/kernel/irq.c:52:13: error: no previous prototype for 'init_IRQ' [-Werror=missing-prototypes]
> 
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
> ---
>  arch/mips/include/asm/irq.h | 1 +
>  arch/mips/kernel/irq.c      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
> index c5d351786416..992f8040d3d9 100644
> --- a/arch/mips/include/asm/irq.h
> +++ b/arch/mips/include/asm/irq.h
> @@ -21,6 +21,7 @@
>  #define IRQ_STACK_START			(IRQ_STACK_SIZE - 16)
>  
>  extern void *irq_stack[NR_CPUS];
> +void init_IRQ(void);

putting it here hasn't any value. If you want to fix this properly,
move the extern void init_IRQ(void) in init/main.c to a common header
file and check that every arch to uses it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]