Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2412606pxk; Sun, 27 Sep 2020 06:44:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMdQrRbjt2SVnhZss1xnNYdi/e9fM7DAlFfmjgC9hKmiQuRCA3gWdXcUO8xvGlvfP9CgO/ X-Received: by 2002:aa7:cd90:: with SMTP id x16mr11008025edv.302.1601214276924; Sun, 27 Sep 2020 06:44:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601214276; cv=none; d=google.com; s=arc-20160816; b=jLTSE9h5v7EOLaM6boMNk7/uqLDaFmXTB/AwLIG1xZdBW8UUjiBT/5BEPx1DVfgDCN RDrSzf2PeIPgv6p9Sfs/Hrrr1nKlwetXqOy020b1MMegFhdNEPsZKMSCjoNoi9fKLcBU GjLm9t0s3YUu67N7lkTkbs8bmcba0mR77jAvwGFMnOH3IChii+clln1QZK/T2DE2WQzP ER/Qb8LjdBgSouoigsLCq5F/AlnmCctkO5LCOfwyVczTi2pdIGQ/+cH51YcC9Ax3hMCx QmN5QWLaw9T2/2VvSwAvlAWZt7Un2keWKBhhkRbF8h80rOBb2ZbPcgI5HkzleC9xKkzW w5jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SOlv0hQyTf1zJo7Qp96TvRRqr/BDOugtsDh0Vgmh4ks=; b=hHNptJ8zmWHoKH9WrKiNWJYGA4sxGugSlLWhlxFzY4VPA7Vpm20gktkG6eO/phFI80 H4gLrS7x+jZCCstMBC6oz1eCsyP5G3vyKy13Ez55qUGo3KefHjhDTD8BBgK4xJFYy8NM bNnZzyYV4YrcEjzQAkxVWtvUwUFqAsrQj3ZwohVnJCughhPapZUS2ukOXCYQ/6dbOXBr gjMTxd5ThOmWhqdsAHG3vd+BEiBdFVod6LS5HlTxPDnLiGXLtTag2gCwHyQXrB/WLD9z Jb1DtIXiw+UMy/V5baT5f398749GiEFTyoJPYlijMpM0n8veQHAhTdAyWFRvfxWfhrIz cK5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l25si6260923eds.531.2020.09.27.06.44.13; Sun, 27 Sep 2020 06:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgI0Nml (ORCPT + 99 others); Sun, 27 Sep 2020 09:42:41 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:24098 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgI0Nml (ORCPT ); Sun, 27 Sep 2020 09:42:41 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app07-12007 (RichMail) with SMTP id 2ee75f7096be93d-df9df; Sun, 27 Sep 2020 21:42:23 +0800 (CST) X-RM-TRANSID: 2ee75f7096be93d-df9df X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.0.144.153]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee45f7096bbeea-169d4; Sun, 27 Sep 2020 21:42:23 +0800 (CST) X-RM-TRANSID: 2ee45f7096bbeea-169d4 From: Tang Bin To: balbi@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe() Date: Sun, 27 Sep 2020 21:42:18 +0800 Message-Id: <20200927134218.20028-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In this function, we don't need dev_err() message because when something goes wrong, devm_platform_ioremap_resource() can print an error message itself, so remove the redundant one. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 02a3a7746..9454f179e 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -508,10 +508,8 @@ static int bdc_probe(struct platform_device *pdev) bdc->clk = clk; bdc->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(bdc->regs)) { - dev_err(dev, "ioremap error\n"); + if (IS_ERR(bdc->regs)) return -ENOMEM; - } irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; -- 2.20.1.windows.1