Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Alex Dewar <alex.dewar90@gmail.com>
CC:     Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dpaa2-mac: Fix potential null pointer dereference
Thread-Topic: [PATCH] dpaa2-mac: Fix potential null pointer dereference
Thread-Index: AQHWlNKE0U3a08JmbE+ZNmBTPcXWFKl8g0kA
Date:   Sun, 27 Sep 2020 13:59:52 +0000
Message-ID: <20200927135950.cy536vnvrae6h2ne@skbuf>
References: <20200927133119.586083-1-alex.dewar90@gmail.com>
In-Reply-To: <20200927133119.586083-1-alex.dewar90@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B1A59593078E0448930793083EAC1B4D@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ed9a907-722a-4bab-2c8f-08d862ed9b82
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2020 13:59:52.7476
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zF6lmdQoTjbIY6AenNmarKfL1pcoN7CeF0Xd/b0Gg9M//AlgF/4AhPHHo9nkhplv313x8QbOrnaXszGaIcy1vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2989
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 27, 2020 at 02:31:20PM +0100, Alex Dewar wrote:
> In dpaa2_pcs_destroy, variable pcs is dereference before it is
> null-checked. Fix this.
>=20
> Addresses-Coverity: CID 1497159: Null pointer dereferences (REVERSE_INULL=
)
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/n=
et/ethernet/freescale/dpaa2/dpaa2-mac.c
> index 6ff64dd1cf27..09bf4fec1172 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -291,11 +291,10 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
>  static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
>  {
>  	struct lynx_pcs *pcs =3D mac->pcs;
> -	struct device *dev =3D &pcs->mdio->dev;
> =20
>  	if (pcs) {
>  		lynx_pcs_destroy(pcs);
> -		put_device(dev);
> +		put_device(&pcs->mdio->dev);
>  		mac->pcs =3D NULL;
>  	}
>  }

This would introduce another problem because you would access an already
freed pcs. Maybe just move the declaration and initialization of dev
inside the if statement.

Thanks, Ioana=