Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2502479pxk; Sun, 27 Sep 2020 10:02:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwchDtOmgVcnmJhA4S3n+3dqvdarKZL7KFjq+q8d/CukMOxm1Tb8jaKHp3WwzxeP79ahFA4 X-Received: by 2002:a50:fa88:: with SMTP id w8mr12028510edr.179.1601226124537; Sun, 27 Sep 2020 10:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601226124; cv=none; d=google.com; s=arc-20160816; b=Iu0liQpgyKwncmr04BhBQDEKG+xYTS99TjEcgdiXwG5rcIzvNV7Asd8Imfz2b+3ViF 2YCEuuKmh3imVKsIkuWQ33XdUr195ITf1noC8cVAkuI2KqAO4opbuDgFjy4xSV0ty28k WHTbe2CkmFrSWlK7LCeGFLgvsAILzTibLvrJszmGMA518Pcl7JmiKx4pjgK9XVIl+6B6 JR09JCd4KuLFw6Kuk4WEGjiHiApGKOMo1hA3eRHyOkAS491EXG4Y+YY7HykJmWxM1+pe tlFnE7pqhtmkF4pNTOXzWQTl0mOhiUeqnV9qPjfpFGSYds2xoy5/v7v7h4lLYZnwxGKe VnUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=IQ2Fj4l/jOGsqtHlxdsKUQOb5fxImsTMnxWvz+QCLrM=; b=aOsjZni9LFl4m0oJF3JQWieQSG5DZpRAvIpQsdNT8JE9ojhLkR3H0r5Xj9nnSVjR3S SgIneGlrIrGyKNCz0dpXg0Uc0HfDW4xtLnfvxtjBAnN7kqOalGnQ+uDM4OeUWsQkT7T+ H62QRFSbAK8ID3ZkJ+kqA2R7x8Tbbj+G1gzRUWQi4frNKRpT7oT5KDYC2m9y95J1C0NH quoUrYm9VYirHzNyszqxhZ25qDO1hr4Mygnf7hBgN91g6nZhRL81JLwp5A50CRC6UtXT /rTg7nMMQn8B8PQHrM5B47dDORuxZu6JwQp5DhAPnXGktM6OANaVEDg2Yk+NY2oeqN2S beNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWRaHKIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si6298384edm.193.2020.09.27.10.01.27; Sun, 27 Sep 2020 10:02:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWRaHKIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbgI0RAA (ORCPT + 99 others); Sun, 27 Sep 2020 13:00:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:39394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbgI0Q77 (ORCPT ); Sun, 27 Sep 2020 12:59:59 -0400 Received: from kozik-lap.proceq-device.com (unknown [194.230.155.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6059823899; Sun, 27 Sep 2020 16:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601225999; bh=DsQjxeaTzdxtV/FNnzMWtGBAiV2ATQVQpSEoosApHDY=; h=From:To:Cc:Subject:Date:From; b=jWRaHKISj8i/MzZzLzvT9/1wyCUAlxZwzBIf1JXupR8bCUcBqnFUSZ6Ij0r78EdvR 5AVKMfIpW40ptp8ffyJwJiYD3vrlnG/PCO6fPoxxymOHX9IiFCQNIQZWVuk7wx3+XP RYZcCPB2dDN2l8sYw5TlngHRYxhKroS73RRIpO28= From: Krzysztof Kozlowski To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Adam Ford , Daniel Baluta , Anson Huang , Peter Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Date: Sun, 27 Sep 2020 18:59:42 +0200 Message-Id: <20200927165947.7317-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite. Reported-by: Felix Radensky Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi index 4107fe914d08..49082529764f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi @@ -135,13 +135,10 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio2>; - /* - * The interrupt is not correct. It should be level low, - * however with internal pull up this causes IRQ storm. - */ - interrupts = <8 IRQ_TYPE_EDGE_RISING>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; rohm,reset-snvs-powered; #clock-cells = <0>; @@ -398,7 +395,7 @@ pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x41 + MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141 >; }; -- 2.17.1