Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2503613pxk; Sun, 27 Sep 2020 10:04:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcJSvrudLKrugvUa/mC7M7CCMHyRzILi80e1qKUTJqVOM0XIfB63M1ccbFOW65tDpmRFwh X-Received: by 2002:a17:906:a251:: with SMTP id bi17mr11784010ejb.526.1601226248899; Sun, 27 Sep 2020 10:04:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601226248; cv=none; d=google.com; s=arc-20160816; b=CPzsi4lO9SLO7xveiPMfEgq1X+FHrKnyjfoHL587O5ZxxHDOQiPIefEeyB3Mt2LSJG uuuOBxG8u2nBda8mxuB8r+f0KFCu587FdzL3dwGctVepsDm0+GNohc+3coiZ69i09XqU uSKSHXRrFhY8LtEa+p7s+oDcqtuCnIP4yOCZFRDH9LjOiemQOozEmhkPCz84xQMem+6/ +CILLmbiS/XDJbSfTLMvoy8eZMQO7urB9vhL1fJLcDcI/qoYIBmYdQNHlNy6GmOl7Y8T TduxhSSFtnJhHJ9e9j9YMPj1KnxfLO73HrgsBDkEQHGH0E38k/OCSrdXRbC36DIh6zlX 3OgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=swH53KTyfOthZqo2NchGl52iqBhj8lGJRbFbwKfmhC4=; b=bXAb5jbmd0GbZl6gCkbYLO4BEsCHt3hUMlXuXy9L/4g90wB9AePA7yw8h/K88QvE/o scy+QXjwjeCZ7j4Fqg+yy6bIbfOF/oztcjxATnYIHQ86Rj3O8H96Vt3tlbtyJimDMxLo HMrbvV7M2tSKuHLFFur/gYfADHqaSd+H2H7hoVuo+KEJfYFqV0qvPadjiUuHGisZUFcT CJ5SY1MAhDV8cqFQ32lKNp2o6pApQ7Xd/+TsuKVAdhR7+4eogcjjEGID0k7rdbwkH7ZC rJ/15bqXMew6U2j3bb28e/qnTQaByVQ28m7sd9Oze1JAJcb8Ju52COVRb/kAKEqdQYQK Q4+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JfMNxKMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si6307065edp.276.2020.09.27.10.03.46; Sun, 27 Sep 2020 10:04:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JfMNxKMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbgI0RAP (ORCPT + 99 others); Sun, 27 Sep 2020 13:00:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbgI0RAO (ORCPT ); Sun, 27 Sep 2020 13:00:14 -0400 Received: from kozik-lap.proceq-device.com (unknown [194.230.155.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A303823899; Sun, 27 Sep 2020 17:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601226014; bh=cK6hdYbGGeVjnbbeqGymKZg6oEYJg/flTCaMuiqFPWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JfMNxKMtUq9KZ0v/Jg9V1UkGdpL5B42HKv4UnvVQ07UGwF9UAW6w4Tk9uECUdKIpF 2dnECJ05mPOFSjUxAdPU9xgepLNA15arSz/QGUasDbBI1FVHBkwvLzZPeS0md64Pog vaEnRbfF4nLM0luVE4nrgbINTK0yoIZTzdP9huGw= From: Krzysztof Kozlowski To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Adam Ford , Daniel Baluta , Anson Huang , Peter Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/6] arm64: dts: imx8mn-var-som: fix missing PMIC's interrupt line pull-up Date: Sun, 27 Sep 2020 18:59:45 +0200 Message-Id: <20200927165947.7317-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200927165947.7317-1-krzk@kernel.org> References: <20200927165947.7317-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite. Reported-by: Felix Radensky Fixes: ade0176dd8a0 ("arm64: dts: imx8mn-var-som: Add Variscite VAR-SOM-MX8MN System on Module") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi index a2d0190921e4..7f356edf9f91 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi @@ -116,13 +116,10 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio2>; - /* - * The interrupt is not correct. It should be level low, - * however with internal pull up this causes IRQ storm. - */ - interrupts = <8 IRQ_TYPE_EDGE_RISING>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; rohm,reset-snvs-powered; regulators { @@ -388,7 +385,7 @@ pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x101 + MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141 >; }; -- 2.17.1