Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2566374pxk; Sun, 27 Sep 2020 12:37:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwNSzs/0LBZpw+QWbU0rgogx5IcPTTp0hc3CloGCBpEfqfmVAylBzmFEPdgVxHBvPpRJAD X-Received: by 2002:a17:906:813:: with SMTP id e19mr12372367ejd.101.1601235461228; Sun, 27 Sep 2020 12:37:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601235461; cv=none; d=google.com; s=arc-20160816; b=mzAcur2B62hgxbRHxv4d/aoppbUFhm5tKcVeBkpQ+VMhw8PX/J07IhLaQDgLZrNyor HW1UeMimTO1Cl+4r8Eh9syE4YETeDicP7IvXpBkJTtEtIoBHANtSlZFpDgGc6NWUjVQP BjakxOxiHML3ZYIc6sEdckgm+GexyfIRBThYzBkBk1mNwKfZxPbHnPUXphgw2NhdXbn0 mta0DdGTB9He3fU9xLrnYcN4nvjty6sMd1H3S7t4UkS7LWCYTRLECsZYzDt7U4l6sLv/ W2SKTgUJWK01YxH5WzNu56zfmnUpNj0un2UP9rHf6obol9Pa5nTrhCk7kZURnlGXuJNI 6wdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Nmope1OKcgHKIN0lUkmnZDt19fb2tVenNuLLHWBLiKs=; b=JG5OxU/uNPddZ8eaL/yRxVfY/zYvqMwXWd82q7dBvcx+dDuYniAadCuiahvf2kPG50 Z7pGiaB2+JJYoik0PfWIUUWw77OuGdLV4CD6EIeDQF1T+AJp11dliKvJndDBUFKVy3Ck txnJH3XmAEONwR9XZoME5Dg4pFoA4+ewIkZrU/ATJ8ZFSC2GZ8HpUuEcxQUd/5qF/+P7 OGrBfGf5VdjQP5/C7ED+XktDSr1nPU1OKd+FWDmhylgvGaNfSs54+natI+55Vd3tZhgp 2BIAmBncJk+0Ot0zCX/EXgfv36aKbrnGlwEdGmeNMWb6OSU2pbz7TLHrFSq1Xlmeljnu 67IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=aD1ptY13; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si5945416ejt.277.2020.09.27.12.37.18; Sun, 27 Sep 2020 12:37:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=aD1ptY13; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbgI0TgW (ORCPT + 99 others); Sun, 27 Sep 2020 15:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbgI0TgV (ORCPT ); Sun, 27 Sep 2020 15:36:21 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67AFBC0613CE for ; Sun, 27 Sep 2020 12:36:21 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id r24so6611753ljm.3 for ; Sun, 27 Sep 2020 12:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nmope1OKcgHKIN0lUkmnZDt19fb2tVenNuLLHWBLiKs=; b=aD1ptY13jrKXQ+n8IhaxEaouzjLaeDMBc3wJDUdcFpr2RLNAqh58cEZMo8uG8P0q8D 3NWP56+G/OtcMLivSGDU9UxUTr5z49ricmyKju6+L69zq3I4jfR3HIvSiq6+/G26r4F8 QaZ3bMwcHl7GfGyT0IoQONGz667rqj05Csbjs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nmope1OKcgHKIN0lUkmnZDt19fb2tVenNuLLHWBLiKs=; b=TvEBdFEoEyL8cKCwyKgJUICW1cqU8d7gEvoCfvk58NngY6jrN9lNXXX87LvNPBGF9n +cDd61dIMPSGxD9ZgbTxPyaMpJV08i6rluEs2l7w55GprXzPnGW1joUH0Jw/RzIIppsF ew0EYmuxulBEhvwh0RwD3XL49cRqDiZhE8PqIyuL1gENPrmO99P7OQcVu4s52vuIYqwJ MPxcV7SisZATXB0yD97aPcFYJ96G3J3NQ3BAUdu/hT75DLlQT3Pka+Og8pbYK8GUq3yo VPo0kpLu5EPrwud94NRRWYU0zpz+RS7oTpVWTVPab8rFEb/PSrqi4Q5Ba5dWbDXCrHA2 hZ8Q== X-Gm-Message-State: AOAM531VAsjFoimuoDiKn3qQerjchC9JsDL25HQLLwS427Q6DkTxTC/6 L0i9ZiqWlI4RR4SnIrX2EGJhVQAff73RoQ== X-Received: by 2002:a2e:814b:: with SMTP id t11mr4300387ljg.367.1601235379502; Sun, 27 Sep 2020 12:36:19 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id w9sm2565652lfr.220.2020.09.27.12.36.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 12:36:16 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id w3so6596944ljo.5 for ; Sun, 27 Sep 2020 12:36:15 -0700 (PDT) X-Received: by 2002:a05:651c:104c:: with SMTP id x12mr4346496ljm.285.1601235375523; Sun, 27 Sep 2020 12:36:15 -0700 (PDT) MIME-Version: 1.0 References: <20200925222600.6832-1-peterx@redhat.com> In-Reply-To: <20200925222600.6832-1-peterx@redhat.com> From: Linus Torvalds Date: Sun, 27 Sep 2020 12:35:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/4] mm: Break COW for pinned pages during fork() To: Peter Xu Cc: Linux Kernel Mailing List , Linux-MM , Jason Gunthorpe , John Hubbard , Andrew Morton , Christoph Hellwig , Yang Shi , Oleg Nesterov , Kirill Tkhai , Kirill Shutemov , Hugh Dickins , Jann Horn , Michal Hocko , Jan Kara , Andrea Arcangeli , Leon Romanovsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 3:26 PM Peter Xu wrote: > > This series is majorly inspired by the previous discussion on the list [1], > starting from the report from Jason on the rdma test failure. Ok, this is now in my git tree with the changes I outlined in the other email. > I tested it myself with fork() after vfio pinning a bunch of device pages, .. but _my_ only testing was to just add a nasty hack that said that all pages are pinned, and made fork() much slower, but hey, it at least tests the preallocation paths etc. And I'm not seeing any obvious failures due to taking that slow-path that is supposed to be a special case. Let's hope this closes the rdma issues. Linus