Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2724613pxk; Sun, 27 Sep 2020 20:10:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza7PErNJ8YCZx2M9V4OtGdIQjCm8OGFXZBjSgXBd1oglOrKrMHNG4IZe83JyXYwLSFnbtC X-Received: by 2002:a17:906:8297:: with SMTP id h23mr13335354ejx.383.1601262651945; Sun, 27 Sep 2020 20:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601262651; cv=none; d=google.com; s=arc-20160816; b=JR2/q6/6N+/QztsJSMpRGlGOK0FGtXwWg3yP1fgk5wjMMCb+/h9dZcASDRnLhj4MaY vdeccWeuSXo7i2RSCHgXTYN2DarzvsdLCLEJX49xMyf7z5aYelrtQ8iYOzR6R+7sLzrg bXTw2tsDdfnDltjyhVUEOg9BgGe0dRt7wqQeDwjbklpKOBONNynX9IQAzhLmATPjQI/n xOeG+Ij1GWiEokECCwpB0yOY7OrWU7HzeRzgXj2IyQAkruC2t6W8sz8B1WDJ1zxtsZhu 1dj3D45qufJ2oNmaGcNe5YudzJoBjsBcJn+oTYj/qpwVhAZNXgwiSXQUcRkg+nqNQWG9 jjUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=b2mmPV1EjxnCYSj3AR1OUMieZfO+UBjdEyJmUARr47M=; b=WrDnriJU9EwnDun9hJDhb6W8tLYBjhIUhxaz6vR7S2iQsfnOtHNcjdOdm8uP+yhW7V HZNBg9IXBYP/lDbbF+ePH7WkBhpunT1AvwyrbrVFqY+7wdJF0vplaVDAMzNd6s0fXHOm y6XOdZ/7tPps6YHp/UBPxPLKISL4CmiF7grjffgI9E/R/h9DgksBnBuG0nHPHxQqO1zQ SRX9YRaBbMhH0Iexa7oqkaluwn7Q8eWYqdeGUyRekzK0UfA2Zrjt3BWjMPLRvWXoZKps 28sTSVH5NdzFv2jVFeaJnlJOBSW7SYLUL+cVcL9My2E/kdNVuwoGvOgXalyv9Xm8bv1E hrIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si6900683edt.338.2020.09.27.20.10.29; Sun, 27 Sep 2020 20:10:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbgI1DIq (ORCPT + 99 others); Sun, 27 Sep 2020 23:08:46 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:25744 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgI1DIj (ORCPT ); Sun, 27 Sep 2020 23:08:39 -0400 Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 27 Sep 2020 20:08:39 -0700 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 27 Sep 2020 20:08:37 -0700 X-QCInternal: smtphost Received: from c-mansur-linux.qualcomm.com ([10.204.90.208]) by ironmsg01-blr.qualcomm.com with ESMTP; 28 Sep 2020 08:38:26 +0530 Received: by c-mansur-linux.qualcomm.com (Postfix, from userid 461723) id 9816521C27; Mon, 28 Sep 2020 08:38:25 +0530 (IST) From: Mansur Alisha Shaik To: linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, swboyd@chromium.org, Mansur Alisha Shaik Subject: [RESEND v3 4/4] venus: put dummy vote on video-mem path after last session release Date: Mon, 28 Sep 2020 08:38:16 +0530 Message-Id: <1601262496-27026-5-git-send-email-mansur@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1601262496-27026-1-git-send-email-mansur@codeaurora.org> References: <1601262496-27026-1-git-send-email-mansur@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As per current implementation, video driver is unvoting "videom-mem" path for last video session during vdec_session_release(). While video playback when we try to suspend device, we see video clock warnings since votes are already removed during vdec_session_release(). corrected this by putting dummy vote on "video-mem" after last video session release and unvoting it during suspend. Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control") Signed-off-by: Mansur Alisha Shaik Reviewed-by: Stephen Boyd --- drivers/media/platform/qcom/venus/pm_helpers.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index 57877ea..0ebba8e 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -212,6 +212,16 @@ static int load_scale_bw(struct venus_core *core) } mutex_unlock(&core->lock); + /* + * keep minimum bandwidth vote for "video-mem" path, + * so that clks can be disabled during vdec_session_release(). + * Actual bandwidth drop will be done during device supend + * so that device can power down without any warnings. + */ + + if (!total_avg && !total_peak) + total_avg = kbps_to_icc(1000); + dev_dbg(core->dev, VDBGL "total: avg_bw: %u, peak_bw: %u\n", total_avg, total_peak); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation