Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 27 Sep 2020 20:41:16 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     Neeraj Upadhyay <neeraju@codeaurora.org>, josh@joshtriplett.org,
        rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
        jiangshanlai@gmail.com, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config
Message-ID: <20200928034116.GM29330@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <1600929250-20344-1-git-send-email-neeraju@codeaurora.org>
 <20200928001342.GD500818@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200928001342.GD500818@google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Sep 27, 2020 at 08:13:42PM -0400, Joel Fernandes wrote:
> On Thu, Sep 24, 2020 at 12:04:10PM +0530, Neeraj Upadhyay wrote:
> > Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config
> > description.
> > 
> 
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Thank you, I will apply your Reviewed-by on the next rebase.

						Thanx, Paul

> thanks,
> 
>  - Joel
> 
> > Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
> > ---
> >  kernel/rcu/Kconfig | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
> > index b71e21f..5b22747 100644
> > --- a/kernel/rcu/Kconfig
> > +++ b/kernel/rcu/Kconfig
> > @@ -227,11 +227,12 @@ config RCU_NOCB_CPU
> >  	  specified at boot time by the rcu_nocbs parameter.  For each
> >  	  such CPU, a kthread ("rcuox/N") will be created to invoke
> >  	  callbacks, where the "N" is the CPU being offloaded, and where
> > -	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
> > -	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
> > -	  on the specified CPUs, but (1) the kthreads may be preempted
> > -	  between each callback, and (2) affinity or cgroups can be used
> > -	  to force the kthreads to run on whatever set of CPUs is desired.
> > +	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
> > +	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
> > +	  from running on the specified CPUs, but (1) the kthreads may be
> > +	  preempted between each callback, and (2) affinity or cgroups can
> > +	  be used to force the kthreads to run on whatever set of CPUs is
> > +	  desired.
> >  
> >  	  Say Y here if you want to help to debug reduced OS jitter.
> >  	  Say N here if you are unsure.
> > -- 
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >