Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422714AbWHECYH (ORCPT ); Fri, 4 Aug 2006 22:24:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161511AbWHECYG (ORCPT ); Fri, 4 Aug 2006 22:24:06 -0400 Received: from mx1.redhat.com ([66.187.233.31]:59358 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1161513AbWHECYF (ORCPT ); Fri, 4 Aug 2006 22:24:05 -0400 Date: Fri, 4 Aug 2006 22:23:56 -0400 From: Dave Jones To: Linus Torvalds , Michal Piotrowski , LKML Subject: Re: 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug() Message-ID: <20060805022356.GC13393@redhat.com> Mail-Followup-To: Dave Jones , Linus Torvalds , Michal Piotrowski , LKML References: <6bffcb0e0608041204u4dad7cd6rab0abc3eca6747c0@mail.gmail.com> <20060804222400.GC18792@redhat.com> <20060805003142.GH18792@redhat.com> <20060805021051.GA13393@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060805021051.GA13393@redhat.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 31 On Fri, Aug 04, 2006 at 10:10:51PM -0400, Dave Jones wrote: > So I added this diff.. > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index f230f9a..31210a0 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -31,6 +31,14 @@ void lock_cpu_hotplug(void) > { > struct task_struct *tsk = current; > > + if (jiffies > HZ * 60) { .... > void unlock_cpu_hotplug(void) > { > + if (jiffies > HZ * 120) { ^^^ Duh. Everything becomes clearer the moment you post a diff to lkml. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/