Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2800500pxk; Sun, 27 Sep 2020 23:28:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0PrKFquR4oWcOkQVKvcJW4yhYRx81Y4UiWJbocR8A4gk4iN5V58P5x/4i1KzKvxeVDWtN X-Received: by 2002:a17:906:915:: with SMTP id i21mr187616ejd.113.1601274486363; Sun, 27 Sep 2020 23:28:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601274486; cv=none; d=google.com; s=arc-20160816; b=Kl+Mnov64CrE46/YVwQrCDM+jScpNySSt9nP/nDNNpHePIHqAsUfQwo6cyM7IXxuWI 9pWK6QBzn9U6SjRI/cmUgnuo65CDrit29d7F6wpNt8Mu9uOLth6OWq/A0anemKtpupu0 Kj5a7OlVE0VePbZP/+n38HJzElciC0+jZ4THShn0NnCY4uXURs+ISSg9Wm0g5B1kbaVP WnP3FxivulfCoXYgH2njvNlBdsLzmSrMKDZBTiMV9KKppw85wcctO6bFNz6G28D0zKD3 XuQ44+0pp6qfLmJ4Jk2/mfXM+TTkqaoBwK3erUklWcPPFCpeD+kAYDRAWngfGoaDNg47 ZAYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=8JGgp9gEXDhFEizI2iZ8ELjaWpd5qIiYsBTe11FMTG8=; b=IRUjO9jNtPxvKcCBAiYCiHf69KBEQ8MAbNbaMLgBCPJZSBQKEcuU37eJ0mefkqhD6j HGp/ExX4HfzhXLSXX089SwTScla7vcPF8v5B9Evy63MSUoHkbyz6C3L6LI5wvvEgpM0Q yBlDCSZKpv20WOhKthsEl0lU8u3uWHP7qD4DXDmONG15HjpauwsGA7Uwshk/Krr2NuKz bSW008b0xtV/+W+HTvqG64PSvshbxGOnjDnh4OtUal9A6PTDiYWt3+ZVHQ5fpb2exFGp LBBr0LWJABrvqXZdC6ytmhUpI7qjWVr4lrocAQ79ulS7ozIbO5ib5ulWL+e2NdqVYtza CuGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu21si32076ejb.127.2020.09.27.23.27.43; Sun, 27 Sep 2020 23:28:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbgI1G0o (ORCPT + 99 others); Mon, 28 Sep 2020 02:26:44 -0400 Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:41764 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbgI1G0o (ORCPT ); Mon, 28 Sep 2020 02:26:44 -0400 X-Greylist: delayed 901 seconds by postgrey-1.27 at vger.kernel.org; Mon, 28 Sep 2020 02:26:44 EDT Received: from sc9-mailhost2.vmware.com (10.113.161.72) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Sun, 27 Sep 2020 23:11:42 -0700 Received: from akaher-virtual-machine.eng.vmware.com (unknown [10.197.103.239]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id 4CA3B24781; Sun, 27 Sep 2020 23:11:42 -0700 (PDT) From: Ajay Kaher To: CC: , , , , , , , , Subject: [PATCH 4.4 20/46] fbcon: remove soft scrollback code Date: Mon, 28 Sep 2020 11:36:57 +0530 Message-ID: <1601273217-47349-1-git-send-email-akaher@vmware.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20200921162034.253730633@linuxfoundation.org> References: <20200921162034.253730633@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX13-EDG-OU-002.vmware.com: akaher@vmware.com does not designate permitted sender hosts) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -3378,7 +3054,6 @@ static const struct consw fb_con = { > .con_font_default = fbcon_set_def_font, > .con_font_copy = fbcon_copy_font, > .con_set_palette = fbcon_set_palette, > - .con_scrolldelta = fbcon_scrolldelta, > .con_set_origin = fbcon_set_origin, > .con_invert_region = fbcon_invert_region, > .con_screen_pos = fbcon_screen_pos, If I am not wrong, this change creates crash in v4.4.y. As before calling con_scrolldelta, NULL check is missing inside console_callback() for v4.4.y, refer: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/tty/vt/vt.c?h=linux-4.4.y#n2487 This NULL check was added in commit 97293de977365fe672daec2523e66ef457104921, and this is not merged to v4.4.y -Ajay