Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2805614pxk; Sun, 27 Sep 2020 23:41:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiZYuB/1JNCbSNVnHR+ITy1wV1595XIDDXUDsv58fOiUulj9RHgBQUhsHNR7i8XI1qdyN7 X-Received: by 2002:a17:906:bc52:: with SMTP id s18mr228492ejv.398.1601275271898; Sun, 27 Sep 2020 23:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601275271; cv=none; d=google.com; s=arc-20160816; b=MB4PLWSO8RLjC3sUTq7YJ2VN4QPwI/pWHoMGUG/PFlVJKQEwLhGNHj39A14HF1WQnO kJH/ZMAWhlL+xe4shfbkwDd3qV/5yR9inx61iQQq7gCW+jWs2NcS3bo05mpb43O0s7zv BskzEHhOQ7peS3cKZT4F+mg2mkaHRQyIC+W87SBTc+3Xsv5ekKsfkhNHVPIhz9Q+IsRX sOdH0oQoLm/7LEN++TKau5MKNOl9u2sRdFAqJrEmi7fjuiTSNIz6OOGEAuzyA9b2WvYl 0IsOZvl+J97lugXh4uQJJtsUkQfsYUe7+eR2Ew/7VWs9SI5zn3adEgT0wcG0KKyxxGXQ uxog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7U/X75rmIhwif4TLgWVYSAGklF004XaYwIHxKwiWxOs=; b=N1LAi35cOL7lJKb/E0Q+afvPtN/v8ebUMv60gncX8Qz62oqi59QdXlL9CPT76aR+II xCIWonR/YDVnoMTl9aDsoFeuMnyDPGNk5Jw02DZKI3NEFOaCxdfG6ipTKJKcfqE9gHsO XtxdBZGS1rUIrpY9EvmHjWWZ6guMhns3TIybqFVRAfLcckPdOJ0qsxHaAkUIeklPzxM2 iu6Z/DkEkmTGCTAC5DCxEqEczpOWke2CMN+B3wGxuBrUMmCHFVhpz/+dnraDbTmTJdh7 ZsEfcH38l6SivQQpY8VDGH/k/wLu0gtSVyoyDoYT1cI7T2kSgoAoU15fWa61qjZUkE5h 7r/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=Eupq+Ell; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bh20si29971ejb.294.2020.09.27.23.40.47; Sun, 27 Sep 2020 23:41:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=Eupq+Ell; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726596AbgI1GiM (ORCPT + 99 others); Mon, 28 Sep 2020 02:38:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgI1GiK (ORCPT ); Mon, 28 Sep 2020 02:38:10 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 901C8C0613CE; Sun, 27 Sep 2020 23:38:09 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id gx22so6921376ejb.5; Sun, 27 Sep 2020 23:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7U/X75rmIhwif4TLgWVYSAGklF004XaYwIHxKwiWxOs=; b=Eupq+Ellszm3vdHHuR4ttLWR42/Npnc1oBbsh2xUCNMnmvCdnqhGCe4RkuVNntZWK+ FV9QsKhwpEXNW11+bTG5ewYNHsvNy/T2Vs7P6abir7UfyZ5DP2gufanFXsfRO/SOHvp8 8js2iX8dN+SbbvHpMTBuvwYyU4tG8b96pV+Eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7U/X75rmIhwif4TLgWVYSAGklF004XaYwIHxKwiWxOs=; b=BWuuGXXQ+S7c3OL0ezfWSfOH+X7Cxm4os69/yMrC7K9XSpVoMoY9aqexPxBa9EmY8K JwoH2gfi8q+V+Loi8eIs57SFQNWLgoemqlKqTaTb23g1Wv2I2eFMxKudcDIfr7KHGYI+ nOMNtIH5kc+IJ9oacTFlBmub5sZM7Q5kkH3il+ns6csMIGcnsUR5L5vcVu2yD7i8JHJf rCZQZZcGNb4Mx51VkDtKnv/8sPWZZ2m3wss62INkVHPmWBC7moI4DDkOUHse3rvnt+am 8wp7+SUmFfNELKhJi7nRc13guXjuwiuaDyzEJ/mXRoFNIT0JnyjaE71Kl5ETgDErXLt2 eb8w== X-Gm-Message-State: AOAM531jzD+aSOLmuqdm/FVWeneKOr7OHVkS4XzzRuO/pBkTCV0mUhCI UA7+3Fssa7IgueXKlsJpFACY9kb+He7BV+rQg5o= X-Received: by 2002:a17:906:4cd6:: with SMTP id q22mr215192ejt.139.1601275088129; Sun, 27 Sep 2020 23:38:08 -0700 (PDT) MIME-Version: 1.0 References: <20200923164730.176881-1-tmaimon77@gmail.com> <20200923164730.176881-5-tmaimon77@gmail.com> In-Reply-To: <20200923164730.176881-5-tmaimon77@gmail.com> From: Joel Stanley Date: Mon, 28 Sep 2020 06:37:55 +0000 Message-ID: Subject: Re: [PATCH v7 4/5] arm: dts: add new device nodes to NPCM7XX device tree To: Tomer Maimon Cc: Rob Herring , Mark Rutland , Avi Fishman , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , devicetree , Linux Kernel Mailing List , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Sep 2020 at 16:48, Tomer Maimon wrote: > > Add the following new device nodes to NPCM7XX: > > - NPCM7xx PWM and FAN. > - NPCM7xx EHCI USB. > - NPCM7xx KCS. > - NPCM Reset. > - NPCM Peripheral SPI. > - NPCM FIU SPI. > - NPCM HWRNG. > - NPCM I2C. > - STMicro STMMAC. > > Signed-off-by: Tomer Maimon Reviewed-by: Joel Stanley > --- > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 382 +++++++++++++++++- > arch/arm/boot/dts/nuvoton-npcm750.dtsi | 18 + > 2 files changed, 394 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > index 5df77a617e77..4a69a9f31668 100644 > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > / { > #address-cells = <1>; > @@ -64,12 +65,6 @@ > interrupt-parent = <&gic>; > ranges = <0x0 0xf0000000 0x00900000>; > > - gcr: gcr@800000 { > - compatible = "nuvoton,npcm750-gcr", "syscon", > - "simple-mfd"; > - reg = <0x800000 0x1000>; > - }; > - > scu: scu@3fe000 { > compatible = "arm,cortex-a9-scu"; > reg = <0x3fe000 0x1000>; > @@ -92,6 +87,16 @@ > reg = <0x3ff000 0x1000>, > <0x3fe100 0x100>; > }; > + > + gcr: gcr@800000 { > + compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd"; > + reg = <0x800000 0x1000>; > + }; > + > + rst: rst@801000 { > + compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd"; > + reg = <0x801000 0x6C>; > + }; > }; > > ahb { > @@ -101,6 +106,12 @@ > interrupt-parent = <&gic>; > ranges; > > + rstc: rstc@f0801000 { > + compatible = "nuvoton,npcm750-reset"; > + reg = <0xf0801000 0x70>; > + #reset-cells = <2>; > + }; > + > clk: clock-controller@f0801000 { > compatible = "nuvoton,npcm750-clk", "syscon"; > #clock-cells = <1>; > @@ -110,6 +121,63 @@ > clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>; > }; > > + gmac0: eth@f0802000 { > + device_type = "network"; > + compatible = "snps,dwmac"; > + reg = <0xf0802000 0x2000>; > + interrupts = ; > + interrupt-names = "macirq"; > + ethernet = <0>; > + clocks = <&clk_rg1refck>, <&clk NPCM7XX_CLK_AHB>; > + clock-names = "stmmaceth", "clk_gmac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&rg1_pins > + &rg1mdio_pins>; > + status = "disabled"; > + }; > + > + ehci1: usb@f0806000 { > + compatible = "nuvoton,npcm750-ehci"; > + reg = <0xf0806000 0x1000>; > + interrupts = ; > + status = "disabled"; > + }; > + > + fiu0: spi@fb000000 { > + compatible = "nuvoton,npcm750-fiu"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0xfb000000 0x1000>; > + reg-names = "control", "memory"; > + clocks = <&clk NPCM7XX_CLK_SPI0>; > + clock-names = "clk_spi0"; > + status = "disabled"; > + }; > + > + fiu3: spi@c0000000 { > + compatible = "nuvoton,npcm750-fiu"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0xc0000000 0x1000>; > + reg-names = "control", "memory"; > + clocks = <&clk NPCM7XX_CLK_SPI3>; > + clock-names = "clk_spi3"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi3_pins>; > + status = "disabled"; > + }; > + > + fiux: spi@fb001000 { > + compatible = "nuvoton,npcm750-fiu"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0xfb001000 0x1000>; > + reg-names = "control", "memory"; > + clocks = <&clk NPCM7XX_CLK_SPIX>; > + clock-names = "clk_spix"; > + status = "disabled"; > + }; > + > apb { > #address-cells = <1>; > #size-cells = <1>; > @@ -117,6 +185,68 @@ > interrupt-parent = <&gic>; > ranges = <0x0 0xf0000000 0x00300000>; > > + lpc_kcs: lpc_kcs@7000 { > + compatible = "nuvoton,npcm750-lpc-kcs", "simple-mfd", "syscon"; > + reg = <0x7000 0x40>; > + reg-io-width = <1>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x7000 0x40>; > + > + kcs1: kcs1@0 { > + compatible = "nuvoton,npcm750-kcs-bmc"; > + reg = <0x0 0x40>; > + interrupts = ; > + kcs_chan = <1>; > + status = "disabled"; > + }; > + > + kcs2: kcs2@0 { > + compatible = "nuvoton,npcm750-kcs-bmc"; > + reg = <0x0 0x40>; > + interrupts = ; > + kcs_chan = <2>; > + status = "disabled"; > + }; > + > + kcs3: kcs3@0 { > + compatible = "nuvoton,npcm750-kcs-bmc"; > + reg = <0x0 0x40>; > + interrupts = ; > + kcs_chan = <3>; > + status = "disabled"; > + }; > + }; > + > + spi0: spi@200000 { > + compatible = "nuvoton,npcm750-pspi"; > + reg = <0x200000 0x1000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pspi1_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = ; > + clocks = <&clk NPCM7XX_CLK_APB5>; > + clock-names = "clk_apb5"; > + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_PSPI1>; > + status = "disabled"; > + }; > + > + spi1: spi@201000 { > + compatible = "nuvoton,npcm750-pspi"; > + reg = <0x201000 0x1000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pspi2_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = ; > + clocks = <&clk NPCM7XX_CLK_APB5>; > + clock-names = "clk_apb5"; > + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_PSPI2>; > + status = "disabled"; > + }; > + > timer0: timer@8000 { > compatible = "nuvoton,npcm750-timer"; > interrupts = ; > @@ -183,6 +313,246 @@ > reg-shift = <2>; > status = "disabled"; > }; > + > + rng: rng@b000 { > + compatible = "nuvoton,npcm750-rng"; > + reg = <0xb000 0x8>; > + status = "disabled"; > + }; > + > + adc: adc@c000 { > + compatible = "nuvoton,npcm750-adc"; > + reg = <0xc000 0x8>; > + interrupts = ; > + clocks = <&clk NPCM7XX_CLK_ADC>; > + resets = <&rstc NPCM7XX_RESET_IPSRST1 NPCM7XX_RESET_ADC>; > + status = "disabled"; > + }; > + > + pwm_fan: pwm-fan-controller@103000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nuvoton,npcm750-pwm-fan"; > + reg = <0x103000 0x2000>, <0x180000 0x8000>; > + reg-names = "pwm", "fan"; > + clocks = <&clk NPCM7XX_CLK_APB3>, > + <&clk NPCM7XX_CLK_APB4>; > + clock-names = "pwm","fan"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm0_pins &pwm1_pins > + &pwm2_pins &pwm3_pins > + &pwm4_pins &pwm5_pins > + &pwm6_pins &pwm7_pins > + &fanin0_pins &fanin1_pins > + &fanin2_pins &fanin3_pins > + &fanin4_pins &fanin5_pins > + &fanin6_pins &fanin7_pins > + &fanin8_pins &fanin9_pins > + &fanin10_pins &fanin11_pins > + &fanin12_pins &fanin13_pins > + &fanin14_pins &fanin15_pins>; > + status = "disabled"; > + }; > + > + i2c0: i2c@80000 { > + reg = <0x80000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb0_pins>; > + status = "disabled"; > + }; > + > + i2c1: i2c@81000 { > + reg = <0x81000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb1_pins>; > + status = "disabled"; > + }; > + > + i2c2: i2c@82000 { > + reg = <0x82000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb2_pins>; > + status = "disabled"; > + }; > + > + i2c3: i2c@83000 { > + reg = <0x83000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb3_pins>; > + status = "disabled"; > + }; > + > + i2c4: i2c@84000 { > + reg = <0x84000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb4_pins>; > + status = "disabled"; > + }; > + > + i2c5: i2c@85000 { > + reg = <0x85000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb5_pins>; > + status = "disabled"; > + }; > + > + i2c6: i2c@86000 { > + reg = <0x86000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb6_pins>; > + status = "disabled"; > + }; > + > + i2c7: i2c@87000 { > + reg = <0x87000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb7_pins>; > + status = "disabled"; > + }; > + > + i2c8: i2c@88000 { > + reg = <0x88000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb8_pins>; > + status = "disabled"; > + }; > + > + i2c9: i2c@89000 { > + reg = <0x89000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb9_pins>; > + status = "disabled"; > + }; > + > + i2c10: i2c@8a000 { > + reg = <0x8a000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb10_pins>; > + status = "disabled"; > + }; > + > + i2c11: i2c@8b000 { > + reg = <0x8b000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb11_pins>; > + status = "disabled"; > + }; > + > + i2c12: i2c@8c000 { > + reg = <0x8c000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb12_pins>; > + status = "disabled"; > + }; > + > + i2c13: i2c@8d000 { > + reg = <0x8d000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb13_pins>; > + status = "disabled"; > + }; > + > + i2c14: i2c@8e000 { > + reg = <0x8e000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb14_pins>; > + status = "disabled"; > + }; > + > + i2c15: i2c@8f000 { > + reg = <0x8f000 0x1000>; > + compatible = "nuvoton,npcm750-i2c"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb15_pins>; > + status = "disabled"; > + }; > }; > }; > > diff --git a/arch/arm/boot/dts/nuvoton-npcm750.dtsi b/arch/arm/boot/dts/nuvoton-npcm750.dtsi > index a37bb2294b8f..13eee0fe5642 100644 > --- a/arch/arm/boot/dts/nuvoton-npcm750.dtsi > +++ b/arch/arm/boot/dts/nuvoton-npcm750.dtsi > @@ -32,6 +32,7 @@ > next-level-cache = <&l2>; > }; > }; > + > soc { > timer@3fe600 { > compatible = "arm,cortex-a9-twd-timer"; > @@ -41,4 +42,21 @@ > clocks = <&clk NPCM7XX_CLK_AHB>; > }; > }; > + > + ahb { > + gmac1: eth@f0804000 { > + device_type = "network"; > + compatible = "snps,dwmac"; > + reg = <0xf0804000 0x2000>; > + interrupts = ; > + interrupt-names = "macirq"; > + ethernet = <1>; > + clocks = <&clk_rg2refck>, <&clk NPCM7XX_CLK_AHB>; > + clock-names = "stmmaceth", "clk_gmac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&rg2_pins > + &rg2mdio_pins>; > + status = "disabled"; > + }; > + }; > }; > -- > 2.22.0 >