Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 08:50:39 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Guido =?utf-8?Q?G=C3=BCnther?= <agx@sigxcpu.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on
 mantix panel
Message-ID: <20200928065039.GB2837573@ulmo>
References: <cover.1600707235.git.agx@sigxcpu.org>
 <71a9108f3472ba9af4bead01b1b770d1e73eb08e.1600707235.git.agx@sigxcpu.org>
 <20200924193807.GA1223313@ravnborg.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="GID0FwUMdk1T2AWN"
Content-Disposition: inline
In-Reply-To: <20200924193807.GA1223313@ravnborg.org>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--GID0FwUMdk1T2AWN
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote:
> Hi Guido.
>=20
> On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido G=C3=BCnther wrote:
> > We need to reset both for the panel to show an image.
> >=20
> > Signed-off-by: Guido G=C3=BCnther <agx@sigxcpu.org>
> > ---
> >  .../bindings/display/panel/mantix,mlaf057we51-x.yaml       | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mla=
f057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,ml=
af057we51-x.yaml
> > index 937323cc9aaa..ba5a18fac9f9 100644
> > --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we5=
1-x.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we5=
1-x.yaml
> > @@ -35,7 +35,9 @@ properties:
> >    vddi-supply:
> >      description: 1.8V I/O voltage supply
> > =20
> > -  reset-gpios: true
> > +  reset-gpios:
> > +    minItems: 2
> > +    maxItems: 2
>=20
> reset-gpios is, as you already wrote, defined in panel-common.yaml.
> Do not try to change it here.
> It would be much better, I think, to introduce a mantix,reset-gpios
> property.
>=20
> This would avoid that we had two different reset-gpios definitions.

My understanding is that this will only override the defaults defined in
panel-common.yaml. So everything else about the
panel-common.yaml#/properties/reset-gpios definition remains valid and
all this does is say that when this matched on "mantix,mlaf057we51-x",
then the "reset-gpios" property is expected to contain two entries as
opposed to the single entry that is expected by default.

Thierry

--GID0FwUMdk1T2AWN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9xh78ACgkQ3SOs138+
s6FB8g//QtBW3j5TqyMHUoddPBCtKSfsY10GMjvB1UNVnf3COAo+qKbNI+aCEeJV
EXr7Nek9zLYPMfbSGaNkk9T36D4SMBVJdpTLm93kXAHSE3CW4e/mNpA78MRDPzPN
rORuQHrZ7yhNnZbKZIrIXCP9o38Y5HPuPM/3qoc5Yx2cnUFSCCN+O2SGyAMbZw26
sXOsGKOZ2p0nHXrEf1YZ4DyX8u+WJzYV8NOWLfaZgs6HkEFRE+4nF3IwYmeU8h7E
5BkqKiTWiruu1hK9I6v7CLWQj6efG1VuNL5dZwqYiJU4q9vqr/Cw23GxBeBhu8z8
umUV5LRHxf4CK5+1Rp9hPJHdjwG6gm3FoeXABD/uY5pzbcjoxqxzgN0GGE5At5KZ
2yRc1jfWC8ZIQOg9iI9XKhOP+id8GXmlHZT0CazBtesDbm2g3/J+zdzzJgheYRzz
wHKkAb5AZjBzVhc8R8UbbczdPUEwMn6hnO4d5Whg41PGcD9PsfzGRx92KUNpkmK/
Ofj1ZgfhAKNGoJSoKjkBX6b7bviU9q1BHKKr7hryAS04r7M9kBWcF3iC7m7/cDsP
WtyDubuGQOqQ43kL+frGrjgLXnF7iy/m16kPgjD7DlxeWYL8kFYfRnSr/976oXdH
5zKXEIdFrPEHmcs89OBFRchJ91m531oM+wbTv6N4Ec8i8X2R6X0=
=sjb9
-----END PGP SIGNATURE-----

--GID0FwUMdk1T2AWN--