Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>, Adam Ford <aford173@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        Peter Chen <peter.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt
 line pull-up
Thread-Topic: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt
 line pull-up
Thread-Index: AQHWlO+orzxSy6wcu0yvbSG+niNqx6l9sYXg
Date:   Mon, 28 Sep 2020 08:06:10 +0000
Message-ID: <VE1PR04MB6638D590D325B4CEABB4806B89350@VE1PR04MB6638.eurprd04.prod.outlook.com>
References: <20200927165947.7317-1-krzk@kernel.org>
 <20200927165947.7317-3-krzk@kernel.org>
In-Reply-To: <20200927165947.7317-3-krzk@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 74f8c27d-6807-4772-c4fd-08d863855c51
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 08:06:10.2388
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GRK3uxwHEUALaLJAgrnG7Sd/ix8AYxV9bBzhQVC1Hg1X9jybwAyX3QKgTsQnAAWY0SDAMCekGMh7CgxQlHq9Cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4815
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/09/28 1:00 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The PMIC's interrupt is level low and should be pulled up.  The PMIC's de=
vice
> node had pinctrl-0 property but it lacked pinctrl-names which is required=
 to
> apply the pin configuration.
>=20
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts
> to a common dtsi")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Please tag me with the whole patch set, thanks.
Reviewed-by: Robin Gong <yibin.gong@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index f305a530ff6f..521eb3a5a12e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -121,6 +121,7 @@
>  	pmic@4b {
>  		compatible =3D "rohm,bd71847";
>  		reg =3D <0x4b>;
> +		pinctrl-names =3D "default";
>  		pinctrl-0 =3D <&pinctrl_pmic>;
>  		interrupt-parent =3D <&gpio1>;
>  		interrupts =3D <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1