Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 10:17:26 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Kevin Tang <kevin3.tang@gmail.com>
Cc:     maarten.lankhorst@linux.intel.com, sean@poorly.run,
        airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
        mark.rutland@arm.com, orsonzhai@gmail.com, zhang.lyra@gmail.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master
 bindings
Message-ID: <20200928081726.hkh3rzbfr6m7jszt@gilmour.lan>
References: <1601274460-7866-1-git-send-email-kevin3.tang@gmail.com>
 <1601274460-7866-2-git-send-email-kevin3.tang@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wsivn4n7yx76g6b5"
Content-Disposition: inline
In-Reply-To: <1601274460-7866-2-git-send-email-kevin3.tang@gmail.com>
Precedence: bulk


--wsivn4n7yx76g6b5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

On Mon, Sep 28, 2020 at 02:27:35PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@unisoc.com>
>=20
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>=20
> RFC v7:
>   - Fix DTC unit name warnings
>   - Fix the problem of maintainers
>=20
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
>  .../display/sprd/sprd,display-subsystem.yaml       | 39 ++++++++++++++++=
++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,d=
isplay-subsystem.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-=
subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,displa=
y-subsystem.yaml
> new file mode 100644
> index 0000000..9487a39
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsyst=
em.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.y=
aml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> +  - Kevin Tang <kevin.tang@unisoc.com>
> +
> +description: |
> +  The Unisoc DRM master device is a virtual device needed to list all
> +  DPU devices or other display interface nodes that comprise the
> +  graphics subsystem.
> +
> +properties:
> +  compatible:
> +    const: sprd,display-subsystem
> +
> +  ports:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description:
> +      Should contain a list of phandles pointing to display interface po=
rt
> +      of DPU devices.

Generally speaking, driver-specific properties should be prefixed by the
vendor name to avoid any conflict with generic properties (like the
OF-Graph ports subnode in this case)

Maxime

--wsivn4n7yx76g6b5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3GcFgAKCRDj7w1vZxhR
xS+CAPsHd2tToWbot1PTKDityictfpR+g452/h0gzCk21CJWUwEA6mST9Nu/gRFs
jq4u6HJkFAaCIllYK06QAD6PzFlFsg0=
=jHyL
-----END PGP SIGNATURE-----

--wsivn4n7yx76g6b5--