Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2859851pxk; Mon, 28 Sep 2020 01:49:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkYJmWavFQuE8wh47HucYSymkDwZvJm6eD6v6+XtphC0VYq2VtYI0ryHxQKeS704kOghTD X-Received: by 2002:a17:906:3ca2:: with SMTP id b2mr637566ejh.460.1601282940809; Mon, 28 Sep 2020 01:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601282940; cv=none; d=google.com; s=arc-20160816; b=FPH5tL9HG2f/FivU99hMjN5ftmhGdlA3gC6t6YAzz81tTfa+nDMlqSmpRcjIqjGTtp hJK6dEtVuKz3A0u1TqDGP9WYbJJj1kN3z6c1a84IxnpfxRaE06TJwD6H/gHcaAiTB6bc /itQOqFgtjig4IHzffeSAh1nesEdOwM95BEZ3dnQSpRijQUZTBw9zHV2+zjEP/EPefCQ eTxU+ooDr/9A5Na4/j9pAzHEnhxEDIdm4zyXmAxFm28ui9XRXDfqVwf2uFtHjEjSDQiL XhiMSlWXK6Q+6IAdyEVO5k6hvny4UnPbCvD92u4s5Rx8AlffgzBzAn351sVFxpUM383t WPug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nS1+mZH+1q3Z1ieI+xXv6fDTo0VrdNwEG9Fe9x5ehDg=; b=kn1OvgfLoJTpZl6AmVjrfoDYszkeLb+Cbx5MZ3szAQpqFEhrmGuW6MyHg6a8RiCBYD 7IptIzNuWTMlNbLorkCbD7pWAI6WrBSqdiOGgyfhqCmdTi3UrQWwzgvqieAUWClKNywl img/2l4jAg79umjukVHjuoZdO5oKWA3TjlsBpxpimJz790bF8w57dwjLm3I6MTYKpKpu twXDW2tiLxjUHfbCydMT8lhDD/SIdKN37aCAxiuebiSoqXTv5MgLMQ6oB/UFUrCeqD+t VKgAQcWcNVlpI7lNcIryZgFqAWvUZareVF7gnbBlDGxsk1iFTxGyjbG2zK7EF0MtR1d/ OllQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QKev1kYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y102si160672ede.165.2020.09.28.01.48.38; Mon, 28 Sep 2020 01:49:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QKev1kYj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbgI1Iph (ORCPT + 99 others); Mon, 28 Sep 2020 04:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgI1Iph (ORCPT ); Mon, 28 Sep 2020 04:45:37 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E000C0613CE; Mon, 28 Sep 2020 01:45:37 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id mn7so227625pjb.5; Mon, 28 Sep 2020 01:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nS1+mZH+1q3Z1ieI+xXv6fDTo0VrdNwEG9Fe9x5ehDg=; b=QKev1kYjofg9CeUcQo2fCgYI5XqAaZXltLyFsuFj2PxGkOygx42Bdaquz/2KUJ/uXw YB44tgBbMn/iys8dLegdc8+HkveO+YAwMS2yTX9vcwycmuvizEX1jMrnyXaZKpmHubnu z9Wp4ncdmuOSluTdNymJsCLYAt59p9+YEbNJ7yxNXAiXtmzeOtPCXbrhE3mZDvLoNjLb gtnYLo/Bcg8SfJgtd9lUNFE8o6c+GUI8bYIsJKU7+ODQu5ogpisixQ097Se3jH3w8Gvv JbKHuDtB+iRDO5JpKD5rtNy8XFaSjr10C4okZDAHQtIYJR2is/Vxmh6qGsoOlqWo0GKw 87iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nS1+mZH+1q3Z1ieI+xXv6fDTo0VrdNwEG9Fe9x5ehDg=; b=SbFuRG4XG2AuebG6B4pqlwUEcXwmY/dpVYlsNJ0eY+SwdbWOmRvgWYd/mIHVKixBaw YDA4j9qhaQJfbF2XrX/Tavboz6k6s4mNySe4OfQr4TEfZqyCOtDdLbQU8aokDVA+UP/C 4OL2uIretTWaMXPALtoMmm/Gd1DeX2WTrMafgZmXwQXaEFcQ6qHQmkMu2XwbU2nLVVZC GpkviSBlihwyaOwWTuQ1HffMijgIq68+E53FYRCb8uyhQmMLCcA0PvT9b8O9irWk90ps ZNwiSwR6qDkCGDQOfPejAucy1g9TKLPQS4pAUu6FTolQ0A/W8nhJO1HVZTThzjOquMy9 bzFw== X-Gm-Message-State: AOAM5323k9yxlsrwVpD4cX0VbJCAkZ0pKcgC+qdyhDaAOFSzHiZZODzN m5rFoIJBSWUeGb3XzdvAXqIMjRYFX+I/e/Zw4V0= X-Received: by 2002:a17:90a:fd98:: with SMTP id cx24mr358002pjb.181.1601282737132; Mon, 28 Sep 2020 01:45:37 -0700 (PDT) MIME-Version: 1.0 References: <20200928040651.24937-1-haifeng.zhao@intel.com> <20200928040651.24937-4-haifeng.zhao@intel.com> In-Reply-To: <20200928040651.24937-4-haifeng.zhao@intel.com> From: Andy Shevchenko Date: Mon, 28 Sep 2020 11:45:18 +0300 Message-ID: Subject: Re: [PATCH 3/5 V55555] PCI/ERR: get device before call device driver to avoid NULL pointer reference To: Ethan Zhao Cc: Bjorn Helgaas , Oliver , ruscur@russell.cc, Lukas Wunner , Andy Shevchenko , Stuart Hayes , Alexandru Gagniuc , Mika Westerberg , linux-pci , Linux Kernel Mailing List , pei.p.jia@intel.com, ashok.raj@linux.intel.com, Sathyanarayanan Kuppuswamy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 7:13 AM Ethan Zhao wrote: Same comments as per v4. Also you have an issue in versioning here. Use -v parameter to `git format-patch`, it will do it for you nicely. -- With Best Regards, Andy Shevchenko