Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2862240pxk; Mon, 28 Sep 2020 01:55:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOZDgLsTO+TaFLCZPDThPfm3PG1mFlqgKUDyr3FEA9YKac0bYX7p15cHV5PhVFOzEH5Dfh X-Received: by 2002:a17:906:6158:: with SMTP id p24mr621498ejl.35.1601283328142; Mon, 28 Sep 2020 01:55:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601283328; cv=none; d=google.com; s=arc-20160816; b=Eep/o+ju2ujTthgRMYjaLwx0MtTrfx2USM5PN886efFx5QehvhEB84N91ha+9WOn8Q WpZi5Y6FZXry3UiSjJ3fi+YsBWxVEhii2KXw219srKsWbxwHMLnLCRCB8DxoT23Rr7fT Kjq8WeT/ah4yQ8PYA7rFGQNA9C/KF359Qka+lPYajlb5Jw5DnxqIL0g5Rm2mtANSbSFW kcT5wl2I4itGA0jcrS83PSelr3Ln+xtTpwOS1GRV/pRSVT/mMKL1uMFl6+pC7ao6w7A5 taDoFEZCxHyyNBSeP8lDdyknyrgifzkMaLNCdsT7Pg1xW+vVhULcb9uB6m0Fg0yTqpWj Ngfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7kkoZT428v3E17CNeS6GIKtbpEfIRBmIlsMliISEXSs=; b=iPbmgSQtrABhw7vsl9Fd5m+MvPHvK/sDtcIPF7wFlxILH/WlWG9uFEuEIrKHR+qWNX uAOKnvPh/eNGTUoqbkbWHqZ3bV1t/M1KjiUIbKJU5FgMsNZ96b6XziWejiNeWimG+uy0 4cltDcpVWWkiaweVnNHcOMBg60DSy5GOrzU5gBwx5TpSvFVKst4QtNwiYXWqUHMsaxmW Y0NHbBfraVvNLmlLZjBGF0yNzsZBNfPyiA+86TI+RwyHdyoUJ5XRncWZ32S4tvXXeqXO 9qNEhT3sC0OMK7NpmK4CxC+7V6yL+5EJQDLDqB/PGXSIor+F3g9dQCBqQEnNaYGCJAaj EGBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I2U58rlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si150936edy.478.2020.09.28.01.55.05; Mon, 28 Sep 2020 01:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I2U58rlC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726552AbgI1Ixa (ORCPT + 99 others); Mon, 28 Sep 2020 04:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgI1Ixa (ORCPT ); Mon, 28 Sep 2020 04:53:30 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC4E2C0613CE; Mon, 28 Sep 2020 01:53:29 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id z23so7337405ejr.13; Mon, 28 Sep 2020 01:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7kkoZT428v3E17CNeS6GIKtbpEfIRBmIlsMliISEXSs=; b=I2U58rlCrLg+pag8kdZk+ww1w+86zHHTalccZqE84bO9tM3iYANpqbsXLKllhQVaKO F1L+98rv6HGbkMFKLZfgLD6BCQTflZNLwcGqyM3Zyr3xFLZ+9W+Q/ezZ+rn65zgxWMno HiqeAp0K/2BvOi7S2GTxcr7aHs9mBZk7mI6E0FW6BUwpsrgRrzy4cSnTYyu5PdwPYiRg qRFjSamR0s7iRWOLY0qh5txrrs9ZoPZ0bhcgExoPiXCT0JMpVXfSRSrQ+nu1V/hc4Sn+ feGPLtBBnZ/piwuBk5tjiW/+0cluu4382/3yCLFeX3x+x+w4jCjwCJY6LxIndSc1lH/p tSeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7kkoZT428v3E17CNeS6GIKtbpEfIRBmIlsMliISEXSs=; b=OpXEXHy67g12RUqKFVPk1Kbtd51dk1QCUWfacrtjtJcG2vkS2XwPWsh2wDpoy/wj7/ RbY5eK8POl1tnkfV55R1C7ncmHs6wKjhoXr2BUcI1DW7NMWWbGq627tyy2MwsSS23ytz wCvOugvHJyWMDX90K//1MBLfUcOLZj+TlIOaW6RYS/uOxrSZFo2pRqPyQ59vWx+WKIT2 QZ4hhHO+6hB0pq3MiWpXT/y0//Zd7qi61soCmiGEqthFL7U9GQepgrn9fIJ0IcdBeLtK n/I7N6mzD8H0SvEtjv1TYMzSTbQBjnO8zdzW6/sfp4ChzxhWAaY01/pefirB+OWt6MsZ BJFg== X-Gm-Message-State: AOAM531Jfg5a89Sqs3rskCkyAbFGPmUxHOk5Wulo92Ri5u1ZJ/aXZeuS IZsEP/NHeY4DCj/Kc+vhxxeM0IBhXVdRSjn0GAE= X-Received: by 2002:a17:906:4cd6:: with SMTP id q22mr607603ejt.139.1601283208473; Mon, 28 Sep 2020 01:53:28 -0700 (PDT) MIME-Version: 1.0 References: <20200928040651.24937-1-haifeng.zhao@intel.com> <20200928040651.24937-4-haifeng.zhao@intel.com> In-Reply-To: From: Ethan Zhao Date: Mon, 28 Sep 2020 16:53:17 +0800 Message-ID: Subject: Re: [PATCH 3/5 V55555] PCI/ERR: get device before call device driver to avoid NULL pointer reference To: Andy Shevchenko Cc: Ethan Zhao , Bjorn Helgaas , Oliver , ruscur@russell.cc, Lukas Wunner , Andy Shevchenko , Stuart Hayes , Alexandru Gagniuc , Mika Westerberg , linux-pci , Linux Kernel Mailing List , pei.p.jia@intel.com, ashok.raj@linux.intel.com, Sathyanarayanan Kuppuswamy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 4:46 PM Andy Shevchenko wrote: > > On Mon, Sep 28, 2020 at 7:13 AM Ethan Zhao wrote: > > Same comments as per v4. > Also you have an issue in versioning here. Use -v parameter to `git > format-patch`, it will do it for you nicely. Aha, git has got this function. I thought it was still manual work..... great tip.! Thanks, Ethan > > -- > With Best Regards, > Andy Shevchenko