Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2876749pxk; Mon, 28 Sep 2020 02:26:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFWOpL69RWkYqRWoFDsd4NOKIFb0ONtyXUSk/EO87ucWXoEpukoW36rNeml3hAZ8694yuJ X-Received: by 2002:a05:6402:64b:: with SMTP id u11mr622446edx.147.1601285186578; Mon, 28 Sep 2020 02:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601285186; cv=none; d=google.com; s=arc-20160816; b=viDLL1OORMMWz2pyAAmtv8pyLCWBm9G9EJ61gXVkVrjKvxdhuSlTIG0vEDyYa1KvOd fL8wVoYp6aYn6Hj5JmCoFaMsNYLKguA03sg4vMBR0naSgwdl4UMi3XBIr4hcn8B8HQcR 6xQzf/38LM1SrX8Rkaxuu7YZgEPBcDKqCFrfStYyLjfmSjidNKL7sf9i7uxwrWgL25IY qftyUkjzDAy6zNvOD4pPxrjNgBw7a4QbjFsWDPkVKzZBBCmbzDHRQ1fxmo2fBpEzJ2YQ Ed5jZm23Whg1YdF5fovJe/F8LJ57HKhSlV+HpbI9MRAezsR3hl5jKB7GvRLOuttA1+6G Qykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vyVUoH6nO0IVpbXsn2T2AaiGIjQmj8vnetRytde1IBY=; b=rTzpYPAMyRjPw0lrcVzXxs3BlU4pVQMT4vWcu0bkFHrPz97l8Mf6mlGjKWd5YOld3q dhytoJI9sAxAVOSX/84z5EXUvuWWZ/wvduBYqftxXvotC6KasomQDxLOVoMmyKkst97y U/cs4D//7t7T8EAcNpcE/5hBzEzjQcwP+GpyE5ZRRTl1WbPtT9ylR1VzbtfVnipfje4m es8pWIUR4OdeiQNsoTL+KM7UHvKz3IchIhjT/yDH2UqvheJMRQ1qcXbNJXAEWVJCXvRg HtandG/FubgrGOua77Fi6fVuj8saUaLtXr/OnF/HCvl5qNaBPgiKG67dVNlvfOZ5PEPa XOqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Cd2f88d0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d25si169298edy.405.2020.09.28.02.26.03; Mon, 28 Sep 2020 02:26:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Cd2f88d0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgI1JWx (ORCPT + 99 others); Mon, 28 Sep 2020 05:22:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgI1JWx (ORCPT ); Mon, 28 Sep 2020 05:22:53 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A752C061755 for ; Mon, 28 Sep 2020 02:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vyVUoH6nO0IVpbXsn2T2AaiGIjQmj8vnetRytde1IBY=; b=Cd2f88d00pAiW209s/WpH/WGDI 4p3RZL4bD4XX+UAwln7hgeecdmeZc0ieBOLoEfkUdtPbWumKESLOh+fzVVoG+MrUYu0mU9et9PhpO GR/9W5+kORFQl/yr2+3qhj4eIm3OVPqeRgBQBl7sLpCgZZu9kyV46GfCQCObpjXPWjViSUjK9OIdj 7+vzZutW71JTcjSJvMDNLzUIf/7B8E+VOlMqrByNmwCBXWbKS0kDeqqWiYkq9xBqVJajm1Kum9VHP S6Eb06R9xv+anb+YZ2jTN6WYUEHBGYLY28NRTyfisJgIYka8b4qJRT1dND/99TNHzYtzHmscZubFo B+6DpqQQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMpMw-0001Qy-4H; Mon, 28 Sep 2020 09:22:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 801C1302753; Mon, 28 Sep 2020 11:22:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 460A0203E73B9; Mon, 28 Sep 2020 11:22:49 +0200 (CEST) Date: Mon, 28 Sep 2020 11:22:49 +0200 From: Peter Zijlstra To: qianjun.kernel@gmail.com Cc: tglx@linutronix.de, will@kernel.org, luto@kernel.org, linux-kernel@vger.kernel.org, laoar.shao@gmail.com, qais.yousef@arm.com, urezki@gmail.com, Frederic Weisbecker Subject: Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop Message-ID: <20200928092249.GC2628@hirez.programming.kicks-ass.net> References: <20200915115609.85106-1-qianjun.kernel@gmail.com> <20200915115609.85106-5-qianjun.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915115609.85106-5-qianjun.kernel@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.kernel@gmail.com wrote: > +/* > + * The pending_next_bit is recorded for the next processing order when > + * the loop is broken. This per cpu variable is to solve the following > + * scenarios: This, that adds all that complexity, and I think it's wrong. The softirqs are priority ordered. Running then again from 0 up if/when you break seems 'right'.