Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2907418pxk; Mon, 28 Sep 2020 03:29:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxFMM7ms64UyFXCJH16izTOoNZNStttlOy9G04X1nRonsi1wtBkCsd0Ytt6W+u0ES7e3fk X-Received: by 2002:a17:906:3a0e:: with SMTP id z14mr936563eje.192.1601288994846; Mon, 28 Sep 2020 03:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601288994; cv=none; d=google.com; s=arc-20160816; b=w9/WJxnTPHLJoEwwPW1xRvBGLYDBGx+a6f+iM6Op4RfcrPuRY5O12+bRuNT3QDxC/Q zg8/F/8n14y9BptO0dhvUn0w1MhKUP1CUq7ykRr5++1zIT/HKEMB2T9v+Ow3cY4nnBn3 EwozWlUT4x6HcJ+E61BlZOpNDCGLg6M6vHBx0m9iL3vNZHwcbc0cUh/y0TQNW7zFNelo 0ckjxCahIS162Uus5ZwTu0a0bYG7yxfkTpwlAbPz0F69mLokxOSeTh4nWyimiA8ia6sT tHnMjSBMASLBXl55lw/osGf/G+rvmbxQyuJEUnB41PV76x6e3Z83/vI3F+Vy/adRhurk jJ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date:cc :to:from:subject:message-id:dkim-signature; bh=IytjbA/Gu1fX17Qs7VG7S2omMUSZgctkOvA1MDdO80E=; b=bOihC2f0/4l0sS0JExxAyvqfaI6rMDL1y7ZUN3St9pWmCoqaEcnuSPk1ER582y/V8a vNfF99ZdSpyk4/BowvVaicDTJepazoW5lbf4J5JxgWgVxUWUlogZESXssrb25vwM8IY4 gtfgwiWAYkNVWNVSqRORdgbOpfesJEBqY1gMyxVgwBMqjji/MyH71hgfPCqeadf1WbrJ xVBjZqMGhfOGmdfHb0IshmMo+DOPXQLDsNZvOl/Fq6JvKgxnhpuCSCO2Qq/yaLYJjXY+ 5zipa23juICaq5DXjzO2cmkjvOYqgMCIp8SliIMdPJ0UmIz0J64HL7WACkKKJYvi5lo9 6sUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@areca-com-tw.20150623.gappssmtp.com header.s=20150623 header.b=H60AmnX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j12si339316ejy.198.2020.09.28.03.29.32; Mon, 28 Sep 2020 03:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@areca-com-tw.20150623.gappssmtp.com header.s=20150623 header.b=H60AmnX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbgI1K2P (ORCPT + 99 others); Mon, 28 Sep 2020 06:28:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbgI1K2P (ORCPT ); Mon, 28 Sep 2020 06:28:15 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21DF7C0613CE for ; Mon, 28 Sep 2020 03:28:15 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id mm21so390255pjb.4 for ; Mon, 28 Sep 2020 03:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=areca-com-tw.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=IytjbA/Gu1fX17Qs7VG7S2omMUSZgctkOvA1MDdO80E=; b=H60AmnX5bjo2Zfvw6RGRnAdZKrrt16oF5PdqfhAUZ+2CB62aTA2aegYcXQXOlYLlk+ rnrjE5kP6XgwMiPI35osWtIbMhHeoaJeIh+uTozML8NjZ6YWzwd+ViFMszF+GxSGFaeA 7beLdNU5gyV3GOHI0FoSS4H0D6nXw9O/dJiG0hWnMYZFAyl49TiR99jKx04KXFOYHQ/x enbV++3DXNonVLjKMBZ9rlwhby/2GNW0h9JFVx2MldTyjUmmLnQsN2TuzjS0gm0Yvh7b ORYYoLdk38eJhTv3AkZioVT+hIMurRWvy8XdxckVMppoSBQT++LZY2C0ycLoHOxdGURX m+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=IytjbA/Gu1fX17Qs7VG7S2omMUSZgctkOvA1MDdO80E=; b=d+v0qo7zUMjPGGLHBbaw0xac788WDU1j8eah8WcJyE3LRJ+wDJafCiwCzian7yV2bI 16FQFihMsTy7pcy8kJ11z39eYpicIHHYQ+6xQ2ffTnUKffs9uvo4p0z026Pn9JaoKw6A UeoAVQp0yD0CmR6kIA2nYSG4tQQ3WIexemjvHYUH3yQgnk/mV6YsViWwT5m/bd06Uc9p 42zFmcdQPnUeOO5LLTL1t5GR6/nFhZ2nXUFHmVtDwkm6kpCpfq25MV7gARmVoxStMJz6 JGd6deNTpPXct0pcX9WWqNkHxre30O6sonpXW4THgYAJiCy/FFaKtTLxb+LR7RgQrKeo GNSA== X-Gm-Message-State: AOAM532AoCcEBhsav2s5hmJSoSSwDPYZ+PmqaARuPVsQWFBgzDFAfT0F YgtkfMp7ZqybUaRHW8ACuMhV0A== X-Received: by 2002:a17:90a:e80f:: with SMTP id i15mr675312pjy.62.1601288894722; Mon, 28 Sep 2020 03:28:14 -0700 (PDT) Received: from centos78 (60-248-88-209.HINET-IP.hinet.net. [60.248.88.209]) by smtp.gmail.com with ESMTPSA id n67sm910506pgn.14.2020.09.28.03.28.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2020 03:28:14 -0700 (PDT) Message-ID: Subject: [PATCH 1/4] scsi: arcmsr: From: ching Huang To: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, Linux Kernel Mailing List Cc: dan.carpenter@oracle.com, hch@infradead.org, Colin King Date: Mon, 28 Sep 2020 18:28:12 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ching Huang Remove unnecessary syntax. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index fa562a0..5076480 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -317,20 +317,16 @@ static bool arcmsr_remap_pciregion(struct AdapterControlBlock *acb) static void arcmsr_unmap_pciregion(struct AdapterControlBlock *acb) { switch (acb->adapter_type) { - case ACB_ADAPTER_TYPE_A:{ + case ACB_ADAPTER_TYPE_A: iounmap(acb->pmuA); - } - break; - case ACB_ADAPTER_TYPE_B:{ + break; + case ACB_ADAPTER_TYPE_B: iounmap(acb->mem_base0); iounmap(acb->mem_base1); - } - - break; - case ACB_ADAPTER_TYPE_C:{ + break; + case ACB_ADAPTER_TYPE_C: iounmap(acb->pmuC); - } - break; + break; case ACB_ADAPTER_TYPE_D: iounmap(acb->mem_base0); break; @@ -552,18 +548,14 @@ static void arcmsr_flush_adapter_cache(struct AdapterControlBlock *acb) { switch (acb->adapter_type) { - case ACB_ADAPTER_TYPE_A: { + case ACB_ADAPTER_TYPE_A: arcmsr_hbaA_flush_cache(acb); - } break; - - case ACB_ADAPTER_TYPE_B: { + case ACB_ADAPTER_TYPE_B: arcmsr_hbaB_flush_cache(acb); - } break; - case ACB_ADAPTER_TYPE_C: { + case ACB_ADAPTER_TYPE_C: arcmsr_hbaC_flush_cache(acb); - } break; case ACB_ADAPTER_TYPE_D: arcmsr_hbaD_flush_cache(acb); @@ -1213,21 +1205,15 @@ static uint8_t arcmsr_abort_allcmd(struct AdapterControlBlock *acb) { uint8_t rtnval = 0; switch (acb->adapter_type) { - case ACB_ADAPTER_TYPE_A: { + case ACB_ADAPTER_TYPE_A: rtnval = arcmsr_hbaA_abort_allcmd(acb); - } break; - - case ACB_ADAPTER_TYPE_B: { + case ACB_ADAPTER_TYPE_B: rtnval = arcmsr_hbaB_abort_allcmd(acb); - } break; - - case ACB_ADAPTER_TYPE_C: { + case ACB_ADAPTER_TYPE_C: rtnval = arcmsr_hbaC_abort_allcmd(acb); - } break; - case ACB_ADAPTER_TYPE_D: rtnval = arcmsr_hbaD_abort_allcmd(acb); break; @@ -1916,18 +1902,14 @@ static void arcmsr_hbaE_stop_bgrb(struct AdapterControlBlock *pACB) static void arcmsr_stop_adapter_bgrb(struct AdapterControlBlock *acb) { switch (acb->adapter_type) { - case ACB_ADAPTER_TYPE_A: { + case ACB_ADAPTER_TYPE_A: arcmsr_hbaA_stop_bgrb(acb); - } break; - - case ACB_ADAPTER_TYPE_B: { + case ACB_ADAPTER_TYPE_B: arcmsr_hbaB_stop_bgrb(acb); - } break; - case ACB_ADAPTER_TYPE_C: { + case ACB_ADAPTER_TYPE_C: arcmsr_hbaC_stop_bgrb(acb); - } break; case ACB_ADAPTER_TYPE_D: arcmsr_hbaD_stop_bgrb(acb); @@ -1951,7 +1933,6 @@ static void arcmsr_iop_message_read(struct AdapterControlBlock *acb) writel(ARCMSR_INBOUND_DRIVER_DATA_READ_OK, ®->inbound_doorbell); } break; - case ACB_ADAPTER_TYPE_B: { struct MessageUnit_B *reg = acb->pmuB; writel(ARCMSR_DRV2IOP_DATA_READ_OK, reg->drv2iop_doorbell); @@ -2034,7 +2015,6 @@ struct QBUFFER __iomem *arcmsr_get_iop_rqbuffer(struct AdapterControlBlock *acb) qbuffer = (struct QBUFFER __iomem *)®->message_rbuffer; } break; - case ACB_ADAPTER_TYPE_B: { struct MessageUnit_B *reg = acb->pmuB; qbuffer = (struct QBUFFER __iomem *)reg->message_rbuffer; @@ -2069,7 +2049,6 @@ static struct QBUFFER __iomem *arcmsr_get_iop_wqbuffer(struct AdapterControlBloc pqbuffer = (struct QBUFFER __iomem *) ®->message_wbuffer; } break; - case ACB_ADAPTER_TYPE_B: { struct MessageUnit_B *reg = acb->pmuB; pqbuffer = (struct QBUFFER __iomem *)reg->message_wbuffer; @@ -2699,10 +2678,8 @@ static irqreturn_t arcmsr_interrupt(struct AdapterControlBlock *acb) switch (acb->adapter_type) { case ACB_ADAPTER_TYPE_A: return arcmsr_hbaA_handle_isr(acb); - break; case ACB_ADAPTER_TYPE_B: return arcmsr_hbaB_handle_isr(acb); - break; case ACB_ADAPTER_TYPE_C: return arcmsr_hbaC_handle_isr(acb); case ACB_ADAPTER_TYPE_D: @@ -3634,18 +3611,14 @@ static int arcmsr_polling_ccbdone(struct AdapterControlBlock *acb, int rtn = 0; switch (acb->adapter_type) { - case ACB_ADAPTER_TYPE_A: { + case ACB_ADAPTER_TYPE_A: rtn = arcmsr_hbaA_polling_ccbdone(acb, poll_ccb); - } break; - - case ACB_ADAPTER_TYPE_B: { + case ACB_ADAPTER_TYPE_B: rtn = arcmsr_hbaB_polling_ccbdone(acb, poll_ccb); - } break; - case ACB_ADAPTER_TYPE_C: { + case ACB_ADAPTER_TYPE_C: rtn = arcmsr_hbaC_polling_ccbdone(acb, poll_ccb); - } break; case ACB_ADAPTER_TYPE_D: rtn = arcmsr_hbaD_polling_ccbdone(acb, poll_ccb);