Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1601274460-7866-1-git-send-email-kevin3.tang@gmail.com>
 <1601274460-7866-6-git-send-email-kevin3.tang@gmail.com> <20200928082029.cohvqu5zf3uiqz4a@gilmour.lan>
In-Reply-To: <20200928082029.cohvqu5zf3uiqz4a@gilmour.lan>
From:   Kevin Tang <kevin3.tang@gmail.com>
Date:   Mon, 28 Sep 2020 19:29:01 +0800
Message-ID: <CAFPSGXaCE_QN3N6fRoEPv=DDrmF10g2Vd76fD=xVgV0cbdDa8Q@mail.gmail.com>
Subject: Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi
 dsi&dphy bindings
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi maxime,
Sorry, I forgot to describe ports subnode with my two port@X, i will be fix=
 it.

Thanks for reminding

Maxime Ripard <maxime@cerno.tech> =E4=BA=8E2020=E5=B9=B49=E6=9C=8828=E6=97=
=A5=E5=91=A8=E4=B8=80 =E4=B8=8B=E5=8D=884:20=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi!
>
> On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote:
> > From: Kevin Tang <kevin.tang@unisoc.com>
> >
> > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY)
> > support for Unisoc's display subsystem.
> >
> > RFC v7:
> >   - Fix DTC unit name warnings
> >   - Fix the problem of maintainers
> >
> > Cc: Orson Zhai <orsonzhai@gmail.com>
> > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> > ---
> >  .../display/sprd/sprd,sharkl3-dsi-host.yaml        | 98 ++++++++++++++=
++++++++
> >  .../display/sprd/sprd,sharkl3-dsi-phy.yaml         | 75 ++++++++++++++=
+++
> >  2 files changed, 173 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd=
,sharkl3-dsi-host.yaml
> >  create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd=
,sharkl3-dsi-phy.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl=
3-dsi-host.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,shark=
l3-dsi-host.yaml
> > new file mode 100644
> > index 0000000..b6bbf67
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-h=
ost.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.=
yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Unisoc MIPI DSI Controller
> > +
> > +maintainers:
> > +  - Kevin Tang <kevin.tang@unisoc.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: sprd,sharkl3-dsi-host
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      Physical base address and length of the registers set for the de=
vice.
> > +
> > +  interrupts:
> > +    maxItems: 2
> > +    description:
> > +      Should contain DSI interrupt.
> > +
> > +  clocks:
> > +    minItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: clk_src_96m
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +    description: A phandle to DSIM power domain node
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
> > +
> > +  port@0:
> > +    type: object
> > +    description:
> > +      A port node with endpoint definitions as defined in
> > +      Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +      That port should be the input endpoint, usually coming from
> > +      the associated DPU.
> > +  port@1:
> > +    type: object
> > +    description:
> > +      A port node with endpoint definitions as defined in
> > +      Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +      That port should be the output endpoint, usually output to
> > +      the associated DPHY.
>
> Is there a specific reason you don't follow the OF-graph and have a
> ports subnode with your two port@X in there?
>
> Maxime