Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 15:06:18 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     JC Kuo <jckuo@nvidia.com>
Cc:     gregkh@linuxfoundation.org, robh@kernel.org, jonathanh@nvidia.com,
        kishon@ti.com, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH v3 04/15] phy: tegra: xusb: tegra210: Do not reset UPHY
 PLL
Message-ID: <20200928130618.GE3065790@ulmo>
References: <20200909081041.3190157-1-jckuo@nvidia.com>
 <20200909081041.3190157-5-jckuo@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="MIdTMoZhcV1D07fI"
Content-Disposition: inline
In-Reply-To: <20200909081041.3190157-5-jckuo@nvidia.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--MIdTMoZhcV1D07fI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 09, 2020 at 04:10:30PM +0800, JC Kuo wrote:
> Once UPHY PLL hardware power sequencer is enabled, do not assert
> reset to PEX/SATA PLLs, otherwise UPHY PLL operation will be broken.
> This commit removes reset_control_assert(pcie->rst) and
> reset_control_assert(sata->rst) from PEX/SATA UPHY disable procedure.
>=20
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
> v3:
>    new, was a part of "phy: tegra: xusb: Rearrange UPHY init on Tegra210"
>=20
>  drivers/phy/tegra/xusb-tegra210.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-t=
egra210.c
> index f06e7bc7a51b..ef4bbcbed60b 100644
> --- a/drivers/phy/tegra/xusb-tegra210.c
> +++ b/drivers/phy/tegra/xusb-tegra210.c
> @@ -504,7 +504,6 @@ static void tegra210_pex_uphy_disable(struct tegra_xu=
sb_padctl *padctl)
>  	if (--pcie->enable > 0)
>  		goto unlock;
> =20
> -	reset_control_assert(pcie->rst);
>  	clk_disable_unprepare(pcie->pll);
> =20
>  unlock:
> @@ -746,7 +745,6 @@ static void tegra210_sata_uphy_disable(struct tegra_x=
usb_padctl *padctl)
>  	if (--sata->enable > 0)
>  		goto unlock;
> =20
> -	reset_control_assert(sata->rst);
>  	clk_disable_unprepare(sata->pll);
> =20
>  unlock:

Does this mean that we can no longer reset these PLLs anymore? Is that
safe? Would we ever need to reset them for recovery or similar? For
power saving, is disabling the clock enough, or could we save some extra
power by putting the PLLs into reset?

Thierry

--MIdTMoZhcV1D07fI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9x38oACgkQ3SOs138+
s6HtDg//cltNSFygdEehsXmLkrNS4au0j1gDfycbnJNhDjwkSWo4eZWV0Q+cDhSx
HWpW7b9wxI8RZvsePtalLP19TTqXg4YFKiEaD575Fd3VrxM5qRpoMVF3SgNULYWe
svfab8PnPtkcilandiqppxMAYx9tWukWTM4HvEilqMZdr20lApPkHTZ/lyBH36Gu
3e0QtSn9Ckj9iKLXqh5TqpuPyFqhmNHOzH4IzlKO9VH5um1EHp/dCUnSMt39+46z
CmWNM0mjx95a8vKwc13OWekR5L80Bopl+7pSNCORWjpRbfWN5P4dc8S1VabwpTWe
5xkaXd+USLCkQIKmcCOR4Tx2tV45g+V1nfiwYla3fhCvOgbb+P2YC5GPVnhPxChL
9Za0NZupXEgBit7yzoT9acaUfzeTrmQC6feZD7A4Aqd67/njgCRxO9hvEwF5PHo6
wIviAUG614NHLntFIQ6ak7v89vS5jIkp1YDYsK7WKeMm5jYzCNusGn42z9E/9yp+
mWn0NGX7CNRPM17+lPgZ9lZb0GmI4M0iTUVpez7/L8ei5weupX5pOvjQOWuQn6sp
vil3joCmBPC67vXTMSw+mizjCvU+NY7wa9s1FB64lGfM9eZNVeQo5qCn+oSlJI6N
RycwiDcYmgb5Uf1j3hSJusoALaX4EGt8uRyVK2nqucMe8w0ZrDQ=
=+ofS
-----END PGP SIGNATURE-----

--MIdTMoZhcV1D07fI--