Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 15:17:51 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     JC Kuo <jckuo@nvidia.com>
Cc:     gregkh@linuxfoundation.org, robh@kernel.org, jonathanh@nvidia.com,
        kishon@ti.com, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH v3 08/15] soc/tegra: pmc: Provide usb sleepwalk register
 map
Message-ID: <20200928131751.GI3065790@ulmo>
References: <20200909081041.3190157-1-jckuo@nvidia.com>
 <20200909081041.3190157-9-jckuo@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8/UBlNHSEJa6utmr"
Content-Disposition: inline
In-Reply-To: <20200909081041.3190157-9-jckuo@nvidia.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--8/UBlNHSEJa6utmr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 09, 2020 at 04:10:34PM +0800, JC Kuo wrote:
> This commit implements a register map which grants USB (UTMI and HSIC)
> sleepwalk registers access to USB PHY drivers. The USB sleepwalk logic
> is in PMC hardware block but USB PHY drivers have the best knowledge
> of proper programming sequence. This approach prevents using custom
> pmc APIs.

I don't think this final sentence is useful. The commit message should
explain what you're doing, but there's no need to enumerate any other
inferior solution you didn't choose to implement.

If you do want to keep it: s/pmc/PMC/.

While at it, perhaps replace "usb" by "USB" in the subject as well.

>=20
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
> v3:
>    commit message improvement
>    drop regmap_reg() usage
>    rename 'reg' with 'offset'
>    rename 'val' with 'value'
>    drop '__force' when invokes devm_regmap_init()
>    print error code of devm_regmap_init()
>    move devm_regmap_init() a litter bit earlier
>    explicitly set '.has_usb_sleepwalk=3Dfalse'
>   =20
>  drivers/soc/tegra/pmc.c | 95 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>=20
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index d332e5d9abac..ff24891ce9ca 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -43,6 +43,7 @@
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> +#include <linux/regmap.h>
> =20
>  #include <soc/tegra/common.h>
>  #include <soc/tegra/fuse.h>
> @@ -102,6 +103,9 @@
> =20
>  #define PMC_PWR_DET_VALUE		0xe4
> =20
> +#define PMC_USB_DEBOUNCE_DEL		0xec
> +#define PMC_USB_AO			0xf0
> +
>  #define PMC_SCRATCH41			0x140
> =20
>  #define PMC_WAKE2_MASK			0x160
> @@ -133,6 +137,13 @@
>  #define IO_DPD2_STATUS			0x1c4
>  #define SEL_DPD_TIM			0x1c8
> =20
> +#define PMC_UTMIP_UHSIC_TRIGGERS	0x1ec
> +#define PMC_UTMIP_UHSIC_SAVED_STATE	0x1f0
> +
> +#define PMC_UTMIP_TERM_PAD_CFG		0x1f8
> +#define PMC_UTMIP_UHSIC_SLEEP_CFG	0x1fc
> +#define PMC_UTMIP_UHSIC_FAKE		0x218
> +
>  #define PMC_SCRATCH54			0x258
>  #define  PMC_SCRATCH54_DATA_SHIFT	8
>  #define  PMC_SCRATCH54_ADDR_SHIFT	0
> @@ -145,8 +156,18 @@
>  #define  PMC_SCRATCH55_CHECKSUM_SHIFT	16
>  #define  PMC_SCRATCH55_I2CSLV1_SHIFT	0
> =20
> +#define  PMC_UTMIP_UHSIC_LINE_WAKEUP	0x26c
> +
> +#define PMC_UTMIP_BIAS_MASTER_CNTRL	0x270
> +#define PMC_UTMIP_MASTER_CONFIG		0x274
> +#define PMC_UTMIP_UHSIC2_TRIGGERS	0x27c
> +#define PMC_UTMIP_MASTER2_CONFIG	0x29c
> +
>  #define GPU_RG_CNTRL			0x2d4
> =20
> +#define PMC_UTMIP_PAD_CFG0		0x4c0
> +#define PMC_UTMIP_UHSIC_SLEEP_CFG1	0x4d0
> +#define PMC_UTMIP_SLEEPWALK_P3		0x4e0
>  /* Tegra186 and later */
>  #define WAKE_AOWAKE_CNTRL(x) (0x000 + ((x) << 2))
>  #define WAKE_AOWAKE_CNTRL_LEVEL (1 << 3)
> @@ -334,6 +355,7 @@ struct tegra_pmc_soc {
>  	const struct pmc_clk_init_data *pmc_clks_data;
>  	unsigned int num_pmc_clks;
>  	bool has_blink_output;
> +	bool has_usb_sleepwalk;
>  };
> =20
>  static const char * const tegra186_reset_sources[] =3D {
> @@ -2495,6 +2517,68 @@ static void tegra_pmc_clock_register(struct tegra_=
pmc *pmc,
>  			 err);
>  }
> =20
> +static const struct regmap_range pmc_usb_sleepwalk_ranges[] =3D {
> +	regmap_reg_range(PMC_USB_DEBOUNCE_DEL, PMC_USB_AO),
> +	regmap_reg_range(PMC_UTMIP_UHSIC_TRIGGERS, PMC_UTMIP_UHSIC_SAVED_STATE),
> +	regmap_reg_range(PMC_UTMIP_TERM_PAD_CFG, PMC_UTMIP_UHSIC_FAKE),
> +	regmap_reg_range(PMC_UTMIP_UHSIC_LINE_WAKEUP, PMC_UTMIP_UHSIC_LINE_WAKE=
UP),
> +	regmap_reg_range(PMC_UTMIP_BIAS_MASTER_CNTRL, PMC_UTMIP_MASTER_CONFIG),
> +	regmap_reg_range(PMC_UTMIP_UHSIC2_TRIGGERS, PMC_UTMIP_MASTER2_CONFIG),
> +	regmap_reg_range(PMC_UTMIP_PAD_CFG0, PMC_UTMIP_UHSIC_SLEEP_CFG1),
> +	regmap_reg_range(PMC_UTMIP_SLEEPWALK_P3, PMC_UTMIP_SLEEPWALK_P3),
> +};
> +
> +static const struct regmap_access_table pmc_usb_sleepwalk_table =3D {
> +	.yes_ranges =3D pmc_usb_sleepwalk_ranges,
> +	.n_yes_ranges =3D ARRAY_SIZE(pmc_usb_sleepwalk_ranges),
> +};
> +
> +static int tegra_pmc_regmap_readl(void *context, unsigned int offset, un=
signed int *value)
> +{
> +	struct tegra_pmc *pmc =3D context;
> +
> +	*value =3D tegra_pmc_readl(pmc, offset);
> +	return 0;
> +}
> +
> +static int tegra_pmc_regmap_writel(void *context, unsigned int offset, u=
nsigned int value)
> +{
> +	struct tegra_pmc *pmc =3D context;
> +
> +	tegra_pmc_writel(pmc, value, offset);
> +	return 0;
> +}
> +
> +static const struct regmap_config usb_sleepwalk_regmap_config =3D {
> +	.name =3D "usb_sleepwalk",
> +	.reg_bits =3D 32,
> +	.val_bits =3D 32,
> +	.reg_stride =3D 4,
> +	.fast_io =3D true,
> +	.rd_table =3D &pmc_usb_sleepwalk_table,
> +	.wr_table =3D &pmc_usb_sleepwalk_table,
> +	.reg_read =3D tegra_pmc_regmap_readl,
> +	.reg_write =3D tegra_pmc_regmap_writel,
> +};
> +
> +static int tegra_pmc_regmap_init(struct tegra_pmc *pmc)
> +{
> +	struct regmap *regmap;
> +	int err;
> +
> +	if (pmc->soc->has_usb_sleepwalk) {
> +		regmap =3D devm_regmap_init(pmc->dev, NULL, (void *) pmc,

I don't think you need that explicit cast there.

With those minor comments addressed:

Acked-by: Thierry Reding <treding@nvidia.com>

--8/UBlNHSEJa6utmr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9x4n8ACgkQ3SOs138+
s6GmiA//S57Ija3gTgeRRo+t19DjQqhaDBEvnn6kYYTx1xvtqiq+Xg3TlFOKpQh7
MrPINACNc3TPc6poLP36X3FZ1IPp6u8npGQnqKEGY4AkXyVoYBGxPeZmZiHOjC4r
y9OE27d+lshl2Pebp4eYouBIlgRwCFa/g0S8MRoD4CO16nEJWb0ATKK9KCCDalry
XEEtPezU3tHAa2QpzmDDNLVtvlcdDASkpvlTrH2k9R7erv3TSMO/0RXPGdVJNTao
ovsJ+g3lEJqd7xpjmaOUUTndCnWMTNynNrm8DRqbRKs0Y92KtHBa0z2M88qXaNFQ
TtMfL0d6gv7pAqH/VyTddGs5PIRpokwM0QpCQ7uLCWADeD7zdzR0FeSNXmZ9/N5r
VrGpdwbdPN+n0U3CciEK6dOIK9iv7Q7cZDDHCog9WeCEQdcMzrXxABmIcxtsWzVS
ftjzbTXq/cOQx2ohVw3BlsYf3vFEQZnJa7/MzYyWGCxLPczlsBhtBavEIlAkXODu
VbKqFzb2y8G5JCaGajHqhAjxiMjwabXniUypLeefkgXdooYrRIkSo67REsi5HkVK
44SCLSlOFT9GHvfT3Uxh3n4k9GkclfSqbm3psJRRojHY/H/6SRkWQJ1Isg5MrWz/
ir0XNgQ+EZbGIQElaja7NF8CBVPgZD+DEN8qHyfdUNkLjZMS5N4=
=J/bb
-----END PGP SIGNATURE-----

--8/UBlNHSEJa6utmr--