Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 15:39:42 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Hagen Paul Pfeifer <hagen@jauu.net>
Cc:     linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: perf script, libperf: python binding bug (bytearrays vs. strings)
Message-ID: <20200928133942.GC3517742@krava>
References: <20200927074312.GA3664097@laniakea>
 <20200928100808.GA3517742@krava>
 <20200928104311.GA412466@laniakea>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200928104311.GA412466@laniakea>
Precedence: bulk

On Mon, Sep 28, 2020 at 12:43:11PM +0200, Hagen Paul Pfeifer wrote:
> * Jiri Olsa | 2020-09-28 12:08:08 [+0200]:
> 
> >patch below fixes it for me, but seems strange this was
> >working till now.. maybe you're the only one using this
> >with python3 ;-)
> 
> and I thought python2 is obsolete and not maintained anymore ... ;-)
> Anyway, the patch fixed everything: no more garbage for Python2 and Python3
> as well as no bytearray type Python3!
> 
> Tested-by: Hagen Paul Pfeifer <hagen@jauu.net>
> 
> Thank you Jiri!
> 
> Probably this patch should be applied on stable too!? Not sure when the 
> problem was introduced.

great, I'll check on that and send full patch later, thanks 

jirka

> 
> Hagen
> 
> >jirka
> >
> >
> >---
> >diff --git a/tools/perf/util/print_binary.c b/tools/perf/util/print_binary.c
> >index 599a1543871d..13fdc51c61d9 100644
> >--- a/tools/perf/util/print_binary.c
> >+++ b/tools/perf/util/print_binary.c
> >@@ -50,7 +50,7 @@ int is_printable_array(char *p, unsigned int len)
> > 
> > 	len--;
> > 
> >-	for (i = 0; i < len; i++) {
> >+	for (i = 0; i < len && p[i]; i++) {
> > 		if (!isprint(p[i]) && !isspace(p[i]))
> > 			return 0;
> > 	}
> >
>