Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3044828pxk; Mon, 28 Sep 2020 07:06:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxFEuAE+BqczuAebTX83nD3mtiNbjf0qRB1RmoHGvnlgdAGO6gCM059+XZoYK8ld+KTPCD X-Received: by 2002:aa7:c154:: with SMTP id r20mr1937338edp.337.1601301987898; Mon, 28 Sep 2020 07:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601301987; cv=none; d=google.com; s=arc-20160816; b=mms7IAenObRZHLS9Z4O9w5Jiko7THwouirnHCKungEW75Dy61oKk7W44S21NX4P9xe R5llh6ipYKweQ73SbHm/OTtQ8xMB3EX02T42Y9G3cE/d/HRG5ZyYlUT1P2z1cIZWRl/k r/C4fiTNZgquYDfjoEFvU2tVNvFEodBoECHxYCqxuUHhBRul+0HErufZMJBFmDomwgbk N8f9Gt7O3h1ZCsuRQnkrrLtj++uuweWfxTNyTZkHGcB4oEolPFJkK/StigiO3ekDl+9d daEVRdk4MMYFVewOBVIqpnVOQgspoQzRKCX0L0psFyVS74PrzEWtrQbfySEUpIn8tADi hhRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=O+B2yHW3I0r7dGo4/jd61iktCFjlkfiy55jSH4sdMqA=; b=fopGJbKn4VVpVZvXYBDnMko7zJtRttV/e/2qmkdngUkiAS9E2rIQQJB97SS3yOsHeV Qm4y26/KHXMqtIKc5URqGyPV7f7xK+qKuWrbc1NJGYigCuj0ySrLoN6lxi3z6IiIY+h5 auW1juRcbcwRlJgT9l5ROqNjxmqQ4qyVNEtFCsaPAtO/28yKSW5xsOUJI/CNOogCD0Ov 5rjboZiHVxbQjAsTvg3jaG11ewY1clUm1olvJqO7vMSnCA99SFI1hOzxhRRu16ilxhPt RCf674GvKJ0daYTpOsP2NKGlrLizeCsNI5CaC97SX6nSGSz+OsVjeMWEdX4eK7tWMkZv hrrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nyKO0gGT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by20si811114ejc.416.2020.09.28.07.06.03; Mon, 28 Sep 2020 07:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nyKO0gGT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgI1OCa (ORCPT + 99 others); Mon, 28 Sep 2020 10:02:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgI1OC3 (ORCPT ); Mon, 28 Sep 2020 10:02:29 -0400 Received: from paulmck-ThinkPad-P72.home (unknown [50.45.173.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64DAA21548; Mon, 28 Sep 2020 14:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601301749; bh=Vobqy5ZNV0BItrof3qaTmqtMGSa+AIkCaHcPJTyJEZU=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=nyKO0gGTF1gQl/tmCdVhkfepP6Z8kCkb9CuDuRynWwrxhlj+0+s0JSJbiniZ5VPaK oSwrhuTkr5TQLWXwTWXb7RFjiUTNKTMCzwLPFQFogPOWuTdWRG0o6ylAj1GfcqhwWY x5FjpEbSZ7q2fagVjNoXRCXTZu9t8o/uTJ5tib00= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 2C91D352077A; Mon, 28 Sep 2020 07:02:29 -0700 (PDT) Date: Mon, 28 Sep 2020 07:02:29 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: Julia Lawall , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , rcu@vger.kernel.org Subject: Re: [PATCH] kvfree_rcu(): fix ifnullfree.cocci warnings Message-ID: <20200928140229.GO29330@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200927225519.GB2800828@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200927225519.GB2800828@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2020 at 06:55:19PM -0400, Joel Fernandes wrote: > On Sun, Sep 27, 2020 at 03:00:29PM +0200, Julia Lawall wrote: > > From: kernel test robot > > > > NULL check before kfree is not needed. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > Fixes: e9bed2a1239b ("kvfree_rcu(): Switch to kmalloc() and kfree() for allocations") > > Signed-off-by: kernel test robot > > Signed-off-by: Julia Lawall > > --- > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git urezki-pcount.2020.09.26a > > head: 1a8eee1cc5b0e59c17f5d94c5871e6c70c4a43a1 > > commit: e9bed2a1239b017d78cec5de66adce0560f6d077 [17/18] kvfree_rcu(): Switch to kmalloc() and kfree() for allocations > > :::::: branch date: 4 hours ago > > :::::: commit date: 15 hours ago > > > > tree.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_s > > bkvhead[i] = NULL; > > krc_this_cpu_unlock(krcp, flags); > > > > - if (bkvhead[i]) > > - kfree(bkvhead[i]); > > + kfree(bkvhead[i]); > > > > Acked-by: Joel Fernandes (Google) Applied and pushed, thank you both! Thanx, Paul > thanks, > > - Joel > > > cond_resched_tasks_rcu_qs(); > > }