Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 16:06:53 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     JC Kuo <jckuo@nvidia.com>
Cc:     gregkh@linuxfoundation.org, robh@kernel.org, jonathanh@nvidia.com,
        kishon@ti.com, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH v3 15/15] xhci: tegra: Enable ELPG for runtime/system PM
Message-ID: <20200928140653.GO3065790@ulmo>
References: <20200909081041.3190157-1-jckuo@nvidia.com>
 <20200909081041.3190157-16-jckuo@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BuBclajtnfx5hylj"
Content-Disposition: inline
In-Reply-To: <20200909081041.3190157-16-jckuo@nvidia.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--BuBclajtnfx5hylj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 09, 2020 at 04:10:41PM +0800, JC Kuo wrote:
> This commit implements the complete programming sequence for ELPG
> entry and exit.
>=20
>  1. At ELPG entry, invokes tegra_xusb_padctl_enable_phy_sleepwalk()
>     and tegra_xusb_padctl_enable_phy_wake() to configure XUSB PADCTL
>     sleepwalk and wake detection circuits to maintain USB lines level
>     and respond to wake events (wake-on-connect, wake-on-disconnect,
>     device-initiated-wake).
>=20
>  2. At ELPG exit, invokes tegra_xusb_padctl_disable_phy_sleepwalk()
>     and tegra_xusb_padctl_disable_phy_wake() to disarm sleepwalk and
>     wake detection circuits.
>=20
> At runtime suspend, XUSB host controller can enter ELPG to reduce
> power consumption. When XUSB PADCTL wake detection circuit detects
> a wake event, an interrupt will be raised. xhci-tegra driver then
> will invoke pm_runtime_resume() for xhci-tegra.
>=20
> Runtime resume could also be triggered by protocol drivers, this is
> the host-initiated-wake event. At runtime resume, xhci-tegra driver
> brings XUSB host controller out of ELPG to handle the wake events.
>=20
> The same ELPG enter/exit procedure will be performed for system
> suspend/resume path so USB devices can remain connected across SC7.
>=20
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
> v3:
>    use 'unsigned int' for PHY index
>    remove unnecessary 'else'
>    drop IRQF_TRIGGER_HIGH when invokes devm_request_threaded_irq()
>   =20
>  drivers/usb/host/xhci-tegra.c | 389 +++++++++++++++++++++++++++++++---
>  1 file changed, 360 insertions(+), 29 deletions(-)
>=20
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index aabff8ee0bb3..ba3f40e78171 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -15,9 +15,11 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of_device.h>
> +#include <linux/of_irq.h>
>  #include <linux/phy/phy.h>
>  #include <linux/phy/tegra/xusb.h>
>  #include <linux/platform_device.h>
> +#include <linux/usb/ch9.h>
>  #include <linux/pm.h>
>  #include <linux/pm_domain.h>
>  #include <linux/pm_runtime.h>
> @@ -224,6 +226,7 @@ struct tegra_xusb {
> =20
>  	int xhci_irq;
>  	int mbox_irq;
> +	int padctl_irq;
> =20
>  	void __iomem *ipfs_base;
>  	void __iomem *fpci_base;
> @@ -269,10 +272,13 @@ struct tegra_xusb {
>  		dma_addr_t phys;
>  	} fw;
> =20
> +	bool suspended;
>  	struct tegra_xusb_context context;
>  };
> =20
>  static struct hc_driver __read_mostly tegra_xhci_hc_driver;
> +static int tegra_xusb_exit_elpg(struct tegra_xusb *tegra, bool runtime);
> +static int tegra_xusb_enter_elpg(struct tegra_xusb *tegra, bool runtime);

Can we reshuffle the code to avoid these predeclarations? Looks like
they're only used in tegra_xusb_runtime_{suspend,resume}(), so perhaps
move the implementations right before those?

Thierry

--BuBclajtnfx5hylj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9x7fsACgkQ3SOs138+
s6GviA//bArY95N26kWGSQkCddCGbNVfmaKT8ob441Ff3cYz0E84EhyFK4NbKXiW
SnK9nz92bD36pEOq4zHqrt3Fr/oxawBu7nUKn9EhQzabPUNT8u85MH9W5CopwhU4
tJrLWmfiyJbX390CXU2jUW3rRs6sIZ6q7Cg8duX3J5cDZtijcJ6yZ5GFlqtEmwMq
YwRlrVxm2yYo/jYvkmnYUDxwK/DT5KvX6cblQ69eh20DPL5e7J57uBEPNnum2n88
5hFkNFjBjfy0lb1MhGq6mpSjXNzqWOUxS6CPNbi6VYahaIZjYbLqQljGobuuKQXQ
J9Ri0zGLO46+4T3Rog6o4Rpm123Kuxl9EkyO/6WOQpMpIrw3KwJsZWmd3xMLBqNx
WshobHLSIKXRaIm/Mng3QTFyOe2EqXbnItNlLlzCV68z3hF25GUUpmelSLfK+ltW
Ywrh3xDEgUz/vVduW6AxYwpF1fKCNEtPS41VLn8vzwJ5C+Sy5AMhJWH/qoilFLZi
aGt+jovRHfXaltxhUU8djloEjHIe57nflEcNnqTfzCHDP9oqhI3krU2QIt2t5xGB
lxXOj/ZXC6DVDdcyHEfOxOk5siGvkf4vM871deQACPRthyb84UYqGVz91ztdz6+l
sJnOIxr5fxqxSr8tz4COZFEr+LwrmWAhDC8ZriUo8GjvAW5DTp0=
=ieLj
-----END PGP SIGNATURE-----

--BuBclajtnfx5hylj--