Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3153357pxk; Mon, 28 Sep 2020 09:35:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwp4RI6fqqH0Xxmwj5CH+EBc3O2CpR5QdHAHvCWzv8hUJ+CerodMzX6h9ryeJDhQYRc72o0 X-Received: by 2002:aa7:c387:: with SMTP id k7mr2659091edq.242.1601310933757; Mon, 28 Sep 2020 09:35:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601310933; cv=none; d=google.com; s=arc-20160816; b=y9yddBl/BRVfGH2zh4uUWBGcsZriEDI93kaDQ9D87Mb/qv7fZByY+pK+Hd6rNiur4o 41c7EE7/McGqlFBKTry/PQqbX8T6Vi5VcdPCcsWEsCjdHua3neJbA+uEEcPq9kSEhAHF oPIKbfmse03nBcgcI2MdemZTsb38zSTBz351qVCygkhw8fpzx9KiYDMBMseLtE126xwI EJSrC3Aq5ldNKXX6Y9JLQBqYQiJY8/vuxFn6VfbGPy4BA5s30VBP3Zgvg2xe81tBLzjg ZdaBNsuFZDXdove3IZgp0dU7sIiJMkhw2WHC1fJJftqL/REbQzHNCl3y9XZ7iVF2skXp i+3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :dkim-signature; bh=IRAWYiQ1GCGSlHPkfgGvGRuzfd4N+24+EgOwtiWIZpU=; b=CuMzHneGRf++VPF+d9puhkOmbkEwCrqSZ/vfNAH1uvVUb88j8sml6py0SKBteE1kyJ OVMcdGI+7LVho3XnfeL4xxqtBfl05Rvoq3uurj9a94l+og3nDqaSaKR38+Ju7smGchmi eTBfUbtmF1C+8z5+d4dC4HFK8MA6f+mFWyRtGgF+Y/sZ79QIW7uUTKzQAlUys97ktriQ Nj3ljHTq936pnUcFcWtS1BDcbhqc907PjG6Mjt5e49ZYXjj8LVNjzSD6gtxnlevaLYHG NDWgk2FBvSVjCBp7tyxDA1HWVf4IMlLyhC3fgTmt0jnZqAv5qcs7hmvzRTWxbXQTEwQi WjvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FeajeMxJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v23si875774ejf.312.2020.09.28.09.35.10; Mon, 28 Sep 2020 09:35:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FeajeMxJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgI1Qbx (ORCPT + 99 others); Mon, 28 Sep 2020 12:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgI1Qbx (ORCPT ); Mon, 28 Sep 2020 12:31:53 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3710C061755; Mon, 28 Sep 2020 09:31:52 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id 60so1531235otw.3; Mon, 28 Sep 2020 09:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IRAWYiQ1GCGSlHPkfgGvGRuzfd4N+24+EgOwtiWIZpU=; b=FeajeMxJNB5HezesR0mun6c7dtWpk0jW0Bb1qxHWOKJFMlY8ALExYd5LOLvvJunSJ7 gKt7UGzLTgxK53RnAXFxSfeDAnZrjDbD87W1bi8XQWeklFa9+gN7VGvIO/yEsZVeE7Yj +6pEJSstIuTQWTnfN0wwQ4Yc4Qlnc9muoGdAraonMPFZATcOyFZfgiZJNjTqCRg9PT3j 1a1JpQaeT6hBUyAShg5+OdR+nFQLlcPniOaJQFOAe2LBIMs6Is08UhRaR85bS+rhezCB mtkePpls/OGOBGTiwmb/WSF6GLS3FMqOs3TUGfr8r4rSlMFPlzpN9HEQ9YVLNm2sCokS v9eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IRAWYiQ1GCGSlHPkfgGvGRuzfd4N+24+EgOwtiWIZpU=; b=P4+ngH7MpJ9CwTOq+S9xVwyiTYxlUZXciSERqcTPbWzigwUbnFeTDFdAmjzSsOCLw1 b0xwAqe4P0qcacOov1cFrqzHGsOyP429HywRmFTDx6ZSb1ITyqDyqFD1U2fJWWY2/gu2 peZk96FhIRXDLEHk/v8SnTkpFY5dfa9HP1qW15NoTfstXmpCN6zmAWNzNRxiXzL6I+re DPG3GoA+ZaU/2FX+hDw1/HfxxBEd19R433NgUwi7vfzsjKEDB+oufs8dJTMslonsBRWQ lie1CYIDO2h5whRQ3kFKF6cF2gBwp3bkuMqsOy0B9JwGs9HKHxayW9eEtyasf0xNczXI lKBQ== X-Gm-Message-State: AOAM5338eJvTyhu/O8MqhoIkuxrc+X4eGoYuMjNB2LTJ9QiNIsJBCUjW MXg6CKQv8FDlJo9+fSLyI7+KXPt0ERE= X-Received: by 2002:a9d:5183:: with SMTP id y3mr1535373otg.285.1601310711824; Mon, 28 Sep 2020 09:31:51 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 36sm330426otb.30.2020.09.28.09.31.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Sep 2020 09:31:51 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 28 Sep 2020 09:31:50 -0700 From: Guenter Roeck To: "Bedel, Alban" Cc: "linux-hwmon@vger.kernel.org" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jdelvare@suse.com" , "robh+dt@kernel.org" Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200928163150.GD106276@roeck-us.net> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> <7986c014-b826-bad1-f19c-cdda31d20804@roeck-us.net> <20200928162948.GC106276@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928162948.GC106276@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 09:29:49AM -0700, Guenter Roeck wrote: > > > > This is handled in lm75_remove() where I added the regulator_disable() > > call. > > lm75_remove() won't be called if the probe function fails. > Sorry, I am confused; please ignore this noise. Guenter