Date: Sat, 5 Aug 2006 22:10:47 +0400
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Greg KH <greg@kroah.com>
Cc: lkml <linux-kernel@vger.kernel.org>, David Miller <davem@davemloft.net>,
       Ulrich Drepper <drepper@redhat.com>, netdev <netdev@vger.kernel.org>,
       Zach Brown <zach.brown@oracle.com>
Subject: Re: [take4 1/4] kevent: Core files.
Message-ID: <20060805181047.GA22177@2ka.mipt.ru>
References: <11547829553148@2ka.mipt.ru> <11547829581556@2ka.mipt.ru> <20060805175702.GA27992@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20060805175702.GA27992@kroah.com>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 27

On Sat, Aug 05, 2006 at 10:57:02AM -0700, GregKH (greg@kroah.com) wrote:
> > +	dev = class_device_create(kevent_user_class, NULL, 
> > +			MKDEV(kevent_user_major, 0), NULL, kevent_name);
> > +	if (IS_ERR(dev)) {
> > +		printk(KERN_ERR "Failed to create %d.%d class device in \"%s\" class: err=%ld.\n", 
> > +				kevent_user_major, 0, kevent_name, PTR_ERR(dev));
> > +		err = PTR_ERR(dev);
> > +		goto err_out_class_destroy;
> > +	}
> 
> As you are only using 1 minor number in this code, why not just use a
> miscdevice instead?  It saves a bit of overhead and makes the code a
> tiny bit smaller :)

No problem. I will move it to miscdevice instead of full chardev.

> thanks,
> 
> greg k-h

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/