Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3182038pxk; Mon, 28 Sep 2020 10:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymiXvBIII3dSBJxDbqXYNHIjo+ZfUUOzZ8pCCRzuvWkEMP7YLrIwgP/5Lgbhe6++KigQ09 X-Received: by 2002:a17:906:4a07:: with SMTP id w7mr2651168eju.366.1601313443408; Mon, 28 Sep 2020 10:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601313443; cv=none; d=google.com; s=arc-20160816; b=hwZDkaS0DEOBToKV7gKRvNRFZdySnHW8RYAWs7FvPHT6YeasRWq0vwyjTL5QzhnsbU uSpGL+TCTbz0nXx4G057wU6+HUKVA3BXtd21njfiSLvKFwXO6KoGxBcsZ1Ae2eD3xevQ R8IdOk59NWBwoqNRqMRiRqMgPz2W9KzqOpRRvU/TooLUvT3H2rxqXPfPyQRCAEpfdvYm 50LgpWtL3nsjj/bkX0Qjh9H/DQ8oE42NVYKLRN5FiT1QmZTXt2rA54CXfGLfJtwYQZD+ Rxdt8Z7wjogc9MBjfRe8sRn115GPIvXg/Qec7KNsE9Yq9Xf0aLLBTb4LNAC/R0plToPn E2NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:to:from:ironport-sdr:ironport-sdr; bh=Ml7eG8tcVdPCTZlc7ezYk8l0nMCF4AqOc7k0iN0fh/0=; b=wGFclIBLC4RxNeVC/pSvaRSnIyim+dmqq/jp4DEXHHUznxxGcZm9AfTgo3alBHF29y Z1Higl0lyJPmBOxloP3jRTRGZ6gcxD3Wm7+EweDQ0JBQk6h08bWJsNAMHVBq+ZPGOyan RIIsPgG2MEqjnmOneo7py16N6Bh3etjRoBTD9P7v6GWDMCqtGZkSOo7yuc8Q9Bh40lMu epTHprTRSg+D1g/XknRUPPmMjNq7LEZ35Jv73sAODGG3y+bMI/wP8hjtaKjmZBHEWA78 W2LR3XYE0djfUWFHe4YrfnaKwIsRhUkERy5Tuw5usydgG28njp5Xr4QhIm3iF7cMUr5k TedQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g19si984436eds.240.2020.09.28.10.17.00; Mon, 28 Sep 2020 10:17:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgI1RPU (ORCPT + 99 others); Mon, 28 Sep 2020 13:15:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:13271 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbgI1RPU (ORCPT ); Mon, 28 Sep 2020 13:15:20 -0400 IronPort-SDR: HqwWAVapywKR7mw3lkEKXvlFP72pCx9542pRneHSCwP39NxIroKFti5LJ5q+lNZzqnBYz6NdtJ lHSmAQNDkzCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="161258609" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="161258609" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 10:15:17 -0700 IronPort-SDR: sdwvITrZwIodaSl3A6uuocAozDR0/EXh0gkaRVGOgxYVobRJFQGzIM/fU9bE8PaJdxtkLclvpe Ra48h5Rv71UA== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="338261563" Received: from lizwalsh-mobl3.ger.corp.intel.com (HELO localhost) ([10.251.86.12]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 10:15:12 -0700 From: Jani Nikula To: "Surendrakumar Upadhyay\, TejaskumarX" , "Vivi\, Rodrigo" , "airlied\@linux.ie" , "daniel\@ffwll.ch" , "intel-gfx\@lists.freedesktop.org" , "dri-devel\@lists.freedesktop.org" , "linux-kernel\@vger.kernel.org" , "Ausmus\, James" , "Roper\, Matthew D" , "Souza\, Jose" , "ville.syrjala\@linux.intel.com" , "De Marchi\, Lucas" , "Pandey\, Hariom" Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-3-tejaskumarx.surendrakumar.upadhyay@intel.com> <87a6xaow40.fsf@intel.com> Date: Mon, 28 Sep 2020 20:15:29 +0300 Message-ID: <871rilq0um.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > This is a good example of a potential trap that having > IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder > might change the if ladder to have IS_ELKHARTLAKE() first, and the > subsequent IS_JASPERLAKE() branch would never be taken. > > BR, > Jani. > > Tejas : In that case I will put attention note in comment about > platform checks such that ladder distrubance can be avoided. What you > suggest? The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center