Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <202009271553.4OjMpGkX%lkp@intel.com> <76cae106-b643-57a9-e82e-48e46ebf1b70@ti.com>
In-Reply-To: <76cae106-b643-57a9-e82e-48e46ebf1b70@ti.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 28 Sep 2020 10:52:54 -0700
Message-ID: <CAKwvOdnsQY6S+3zAH6_SD0ifbUaSDFj9mBdhF4GVq6VB=tjFsA@mail.gmail.com>
Subject: Re: sound/soc/ti/j721e-evm.c:528:34: warning: unused variable 'j721e_audio_of_match'
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 28, 2020 at 12:27 AM 'Peter Ujfalusi' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
>
>
> On 27/09/2020 10.27, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.=
git master
> > head:   a1bffa48745afbb54cb4f873bba783b2ae8be042
> > commit: 6748d05590594837e42dfa975879fb275099f0b2 ASoC: ti: Add custom m=
achine driver for j721e EVM (CPB and IVI)
> > date:   3 months ago
> > config: x86_64-randconfig-r033-20200927 (attached as .config)
> > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project a8=
3eb048cb9a75da7a07a9d5318bbdbf54885c87)
> > reproduce (this is a W=3D1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/s=
bin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linu=
x.git/commit/?id=3D6748d05590594837e42dfa975879fb275099f0b2
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kerne=
l/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout 6748d05590594837e42dfa975879fb275099f0b2
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross =
ARCH=3Dx86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> sound/soc/ti/j721e-evm.c:528:34: warning: unused variable 'j721e_audi=
o_of_match' [-Wunused-const-variable]
> >    static const struct of_device_id j721e_audio_of_match[] =3D {
> >                                     ^
> >    1 warning generated.
>
> Right, in the attached .config:
> # CONFIG_OF is not set
>
> There must be a clean way to handle this without extensive ifedfery...

Pretty sure I just saw a patch go by wrapping another device table
definition in #ifdef CONFIG_OF, so it's not unusual.

>
> > vim +/j721e_audio_of_match +528 sound/soc/ti/j721e-evm.c
> >
> >    527
> >  > 528        static const struct of_device_id j721e_audio_of_match[] =
=3D {
> >    529                {
> >    530                        .compatible =3D "ti,j721e-cpb-audio",
> >    531                        .data =3D &j721e_cpb_data,
> >    532                }, {
> >    533                        .compatible =3D "ti,j721e-cpb-ivi-audio",
> >    534                        .data =3D &j721e_cpb_ivi_data,
> >    535                },
> >    536                { },
> >    537        };
> >    538        MODULE_DEVICE_TABLE(of, j721e_audio_of_match);
> >    539
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> >
>
> - P=C3=A9ter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> --
> You received this message because you are subscribed to the Google Groups=
 "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an=
 email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgi=
d/clang-built-linux/76cae106-b643-57a9-e82e-48e46ebf1b70%40ti.com.


--=20
Thanks,
~Nick Desaulniers