Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nick Terrell <terrelln@fb.com>
To:     Feng Tang <feng.tang@intel.com>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Sedat Dilek <sedat.dilek@gmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "rong.a.chen@intel.com" <rong.a.chen@intel.com>,
        "philip.li@intel.com" <philip.li@intel.com>
Subject: Re: PROBLEM: zstd bzImage decompression fails for some x86_32 config
 on 5.9-rc1
Thread-Topic: PROBLEM: zstd bzImage decompression fails for some x86_32 config
 on 5.9-rc1
Thread-Index: AQHWlXUd/dfvQ2fZYk2nxWB3sbp9DKl+WAWA
Date:   Mon, 28 Sep 2020 18:02:03 +0000
Message-ID: <74757C2A-7C09-4C2E-9828-E8D12EE4706B@fb.com>
References: <20200928085505.GA22244@shbuild999.sh.intel.com>
In-Reply-To: <20200928085505.GA22244@shbuild999.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <79D9A78EAB20564F9AAD9B499466E59E@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6239dd6e-26c0-4ad9-cbe7-08d863d89b08
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 18:02:03.6806
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QrTzxVDVZhgMGY1FEjq4H6hSVC0JdSFtxJkzXeB6JxnxbvMHXEFX8fX19XLb8gek
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2199
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-28_16:2020-09-28,2020-09-28 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=0
 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 mlxlogscore=989
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2006250000 definitions=main-2009280140
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 28, 2020, at 1:55 AM, Feng Tang <feng.tang@intel.com> wrote:
>=20
> Hi Nick,
>=20
> 0day has found some kernel decomprssion failure case since 5.9-rc1 (X86_3=
2
> build), and it could be related with ZSTD code, though initially we bisec=
ted
> to some other commits.
>=20
> The error messages are:=20
> =09
> 	early console in setup code
> 	Wrong EFI loader signature.
> 	early console in extract_kernel
> 	input_data: 0x046f50b4
> 	input_len: 0x01ebbeb6
> 	output: 0x01000000
> 	output_len: 0x04fc535c
> 	kernel_total_size: 0x055f5000
> 	needed_size: 0x055f5000
> =09
> 	Decompressing Linux...
> =09
> 	ZSTD-compressed data is corrupt
>=20
> This could be reproduced by compiling the kernel with attached config,
> and use QEMU to boot it.
>=20
> We suspect it could be related with the kernel size, as we only see
> it on big kernel, and some more info are:
>=20
> * If we remove a lot of kernel config to build a much smaller kernel,
>  it will boot fine
>=20
> * If we change the zstd algorithm from zstd22 to zstd19, the kernel will
>  boot fine with below patch
>=20
> 	diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compresse=
d/Makefile
> 	index 3962f59..8fe71ba 100644
> 	--- a/arch/x86/boot/compressed/Makefile
> 	+++ b/arch/x86/boot/compressed/Makefile
> 	@@ -147,7 +147,7 @@ $(obj)/vmlinux.bin.lzo: $(vmlinux.bin.all-y) FORCE
> 	 $(obj)/vmlinux.bin.zst: $(vmlinux.bin.all-y) FORCE
> 	-	$(call if_changed,zstd22)
> 	+	$(call if_changed,zstd)
>=20
>=20
> Please let me know if you need more info, and sorry for the late report
> as we just tracked down to this point.

Thanks for the report, I will look into it today.

Best,
Nick

> Thanks,
> Feng
>=20
>=20
>=20
> <zstd_x86_32.config>