Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3211341pxk; Mon, 28 Sep 2020 11:07:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyB0JPwnd8ClXOeEIcTFuWHcibwGWxH6FPY6d8//yeRWZdbuLxIUwNSJ3XOOmiYUdGK5Lh X-Received: by 2002:a17:906:cd0d:: with SMTP id oz13mr43600ejb.212.1601316434162; Mon, 28 Sep 2020 11:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601316434; cv=none; d=google.com; s=arc-20160816; b=dJlu4Us5eOQCrWQnpRRdS4nf8V1l3q9g0oy+RuSSLNtZOTdS0HMVrLteRMmOhRwPGC QheTl7nHeueuUzG0DrELDxzmWqNi6bOnzhJ/E1egCddp4QhFpMzUMSyUNUPoK+ie394Y ApTW9kh1TvOUUe/zLjX7yGOkxhGdA0LT3O5DII3BOHo1o1otH5TZcur5npM//Ldl8JNN sh/9Bck1wyda3GS+i3h18/50ek41Nl1fbVZiFxePV9PeHI2A6L5QZfhl8nruzfv9PKW1 jVGhrNI1e4P4H6gLMJu98GOCXdJElgBBd0Ae+CyQS2iM7ZIcaSeyy2F+et1s7vHbzLVj UXDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=ohoLnq3IyOM867rdqpCnwxlxG54wqeklNmSLBI3TIxg=; b=NPheEVUp2zgClP5b+9n4Skl3ARzKvvJBPihwB17vLFQX0733gfD4dJiBjNn71MLTIK uFSX6dPDbIenh+ToQmJRjDrZCQtRoN/DA8B/+jICClfYXYHxw+HBdLRuOHwCqSftmUKy QAiyqnH/zTeeTO0nkmDtRsgaLJmE963DSpghH0sXfImxtz5ufzF2q5TIhBaEfNM9xTHR 8wXVALn1t+xKrNjKXMEgvyFKQht0WuF/DeOyoTnRe74PVLiKiWwSTkWsJ4imXAKSHSf+ /VxmP9k6exFwOHps/tY3elbJt0AbmAIlb44vBBIqeUz/ACnZwC4echjHRTLSeXxHC12V Hm2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fHwtX++C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si1100919ejs.53.2020.09.28.11.06.51; Mon, 28 Sep 2020 11:07:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fHwtX++C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbgI1SCj (ORCPT + 99 others); Mon, 28 Sep 2020 14:02:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:40404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbgI1SCR (ORCPT ); Mon, 28 Sep 2020 14:02:17 -0400 Received: from [192.168.0.112] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F263C20BED; Mon, 28 Sep 2020 18:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601316136; bh=ecZXyWDxzaXZoqVvnUfNYLoG/DJ+B7euoHgszVXCivc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fHwtX++CygUGfmenlMSqel4CBIYAF3jMJOK04h5tYPQJ2/L+ZA1mbAubxue4rIqzO tkpDg2eviLKjAotH+X3lZ/K9JCwEaSsWz7MSByERF43brhWlWmFILAlgLkzUSevMMp zWOdT5u34THPsDBWy5iiKueaLbmH53sbh2mNpdfM= Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call To: "Kuppuswamy, Sathyanarayanan" , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <704c39bf-6f0c-bba3-70b8-91de6a445e43@linux.intel.com> <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org> <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> <95e23cb5-f6e1-b121-0de8-a2066d507d9c@linux.intel.com> <65238d0b-0a39-400a-3a18-4f68eb554538@kernel.org> <4ae86061-2182-bcf1-ebd7-485acf2d47b9@linux.intel.com> <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com> <44f0cac5-8deb-1169-eb6d-93ac4889fe7e@kernel.org> <3bc0fd23-8ddd-32c5-1dd9-4d5209ea68c3@linux.intel.com> <8a3aeb3c-83c4-8626-601d-360946d55dd8@linux.intel.com> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <9b295cad-7302-cf2c-d19d-d27fabcb48be@kernel.org> Date: Mon, 28 Sep 2020 14:02:14 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8a3aeb3c-83c4-8626-601d-360946d55dd8@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/2020 1:15 PM, Kuppuswamy, Sathyanarayanan wrote: > Since there is no state restoration for FATAL errors, I am wondering > whether > calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are > required? Good question, Initially when we started, we were trying to handle both NON_FATAL and FATAL errors in DPC. We have seen value in unifying AER's callback mechanism with DPC. It looks like this no longer applies for DPC. Some drivers want these indication to stop outgoing DMA/timers so that system can recover quickly. There is value in calling them with existing AER based design. I agree it doesn't apply here anymore if we are going to remove the device driver. Maybe, you should stop calling pcie_do_recovery() in DPC as well. > > Let me know your comments about following pseudo code. > > if (fatal error & hotplug_supported) >    do nothing // if fatal triggered by DPC, clear DPC state. > > if (fatal error & no-hotplug) >   perform slot_reset and renumerate affected devices. LGTM, I apologize for calling this slot_reset but slot_reset in err.c code is for post recovery callback to endpoint drivers. Let's not use this term here anymore to not confuse ourselves. remove device + rescan similar to how hotplug remove + hotplug insertion notifications does eventually. All of this to be done in DPC driver without any err.c involvement. Bjorn, What do you think? Is this a good direction? Sinan