Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3224530pxk; Mon, 28 Sep 2020 11:29:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+azggdfzR5I4ETcNudX0fyDfONrUz/iJzzbXnpCbSzGgjpbtx56riOIaI8IUCi77hTHv7 X-Received: by 2002:aa7:dad8:: with SMTP id x24mr3246522eds.19.1601317763740; Mon, 28 Sep 2020 11:29:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601317763; cv=none; d=google.com; s=arc-20160816; b=Dp6/zP80BAel4Ug70NVgd+WB1bxXg7msSnAxXlY+k7mqAnZ/dsUZQUz3fKmCDtV0/a 5fa9pCMe2zcyzVnZOJbrrPnVAG/Eke1HU4udnx4G7TSUATR5wtILJfS36lzoICK32WQp Hh7bAeQvwS7q/9WbJu/0ETCvOInNJgXjnxKilyLRSZRQvqjb43/TbK9b7Xq3uwMoPb4h jnoOElLLxZH36HyRfqVGjHKmuwq2mdzYSgpsGQHPMJ1oYP3Cuz0u34lQd/2ozz8jyvnE jvrlIwhA7QzUyuOyRcXYNvM4ffgwAq9gFdWuRRie3jhWiYX53p7KUvrBq89jHTJ+LGfs dqJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt :references:cc:to:from:subject:dkim-signature; bh=Hqj7bmcqb0fJWzGn6GYE0i3laa0sjiF2AKvBBWEqduw=; b=eJxV40XMPlSDvkc4YU98IyTfJ2zlnMiOTk53OgjxXvA9cZOHE48ISm984PgHFyszHj DgKyWxHT8QBnf6+M1kgcZaB4EaeVpVWDWv5QLq+TGoXDhYhCYq1v140X3PWnp/jg+k6h gQc0xn0SBFvSfoVmzKaid4IXLESiEj3x6rwxN7r4cmAD0MtkEyGC8b5AZZByDhwRPLyV 4B4xksT4si4+hsIf54jVRuJCS2plUCbiHu2CjIdfmIzWjKe7a+CpSG3Zfm+hq4YaUBg5 9GYeQGbHIcEmTaMQGTbaKCyWaSvU+kBfA4NAFwMhkHSk5YFjon7hO4Dok75KnPEWJQf8 aLxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NdGGNGXV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yr3si1057259ejb.322.2020.09.28.11.29.01; Mon, 28 Sep 2020 11:29:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NdGGNGXV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgI1SZ7 (ORCPT + 99 others); Mon, 28 Sep 2020 14:25:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbgI1SZ7 (ORCPT ); Mon, 28 Sep 2020 14:25:59 -0400 Received: from [192.168.0.112] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B888206C3; Mon, 28 Sep 2020 18:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601317558; bh=Hqj7bmcqb0fJWzGn6GYE0i3laa0sjiF2AKvBBWEqduw=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=NdGGNGXVPmkeehQO7Wil32kjU2ZHxxdp2Pu2+J+i4m6FvVjFEPdmwWrin1wqet9Bx x1XNqE4FBm+l/2v24WaiH43ivMYoClORE72gAwhrZmuAGomoqCTHwmy8sNCrh4mokG pfFf2+fDFTxhkO0iaLUNpmqpZRVnCzPu5vpFFEn8= Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call From: Sinan Kaya To: "Kuppuswamy, Sathyanarayanan" , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org> <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> <95e23cb5-f6e1-b121-0de8-a2066d507d9c@linux.intel.com> <65238d0b-0a39-400a-3a18-4f68eb554538@kernel.org> <4ae86061-2182-bcf1-ebd7-485acf2d47b9@linux.intel.com> <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com> <44f0cac5-8deb-1169-eb6d-93ac4889fe7e@kernel.org> <3bc0fd23-8ddd-32c5-1dd9-4d5209ea68c3@linux.intel.com> <8a3aeb3c-83c4-8626-601d-360946d55dd8@linux.intel.com> <9b295cad-7302-cf2c-d19d-d27fabcb48be@kernel.org> Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <93b4015f-df2b-728b-3ef7-ac5aa10f03ed@kernel.org> Date: Mon, 28 Sep 2020 14:25:56 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <9b295cad-7302-cf2c-d19d-d27fabcb48be@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/2020 2:02 PM, Sinan Kaya wrote: > Since there is no state restoration for FATAL errors, I am wondering > whether > calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are > required? I also would like to ask someone closer to the spec language double check this. When we recover the link at the end of the DPC handler, what is the expected state of the endpoint? Is it a some kind of a reset like secondary bus reset? (I assumed this one) Undefined? or just plain link recovery with everything else as intact as it used to be?