Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3232848pxk; Mon, 28 Sep 2020 11:45:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZjInipUdizUuj9+KD1CrKTOB6BBoqHJ0XrYXDl7S1vCSTFkksKFwPO21lpEUh4F2XWLa6 X-Received: by 2002:a05:6402:326:: with SMTP id q6mr3368663edw.216.1601318754495; Mon, 28 Sep 2020 11:45:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601318754; cv=none; d=google.com; s=arc-20160816; b=Kr2xETy3lTD62ndBlbQZS2cA6Zy362X/bticz1F70MG289vcXfDzZqzZBERBJaGz1v JMrkom8I52381hFtxK+DUiNmHvLhhBJnEj84BVJH9hCLwog2qyTZR3QIi3iV/Y9Xp8za 6Ij5LK2AapBHbvF6dzdcCTH3/rDT1hg222QuhHuI9KbidDXpDmoY5TEfEViBBQqvXwRI TTVujELUQCxj73NydW9JuIzMpneBsVR3wGx1YTHxfXQ809zFXybkhDi4mfl3/p5tPvU9 yEUvGPYNRqbTOrnJwx5ZbO9L4HeH6n/hqMXtmCHkPDqiBsAM681l7f1OvcYQ+CX5nRtz NTJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=mMpSORkuwjhOa8TOokOcUYzY59laiixLdPiUVCdrAeg=; b=GmPUOztFYaWzQwseD1b+s1EvCG7R248LmQYHm8WBN4+R+ffSgrjp68cElNlJPC+9jS YIJkxs4CKW9bgGoQLCsTdLBZ8IfJkjPBsBzjF0Xm/gI2D7oxw4xXkNX85vTabOsCPgSw b13tdEmbt/LsCyObb/6h6MuxZvHGoCgcPoOeMpzqMtllJON7v3X24hg063wU+GWQtHEq FEiG/uCXRETc/rHorrK7e34qswaNT0o2dk4K5l/9V7uhJYEqTo5z2HhzEErAaGZJ0Tqv q4nTCGmlROw7buTOyDFbtmM9dQYzv++odpOeo51b08Dj13Ezm20zBwjcFgFzliVnwsdN KoAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f13si1208375edc.249.2020.09.28.11.45.30; Mon, 28 Sep 2020 11:45:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbgI1So0 (ORCPT + 99 others); Mon, 28 Sep 2020 14:44:26 -0400 Received: from mail-oo1-f68.google.com ([209.85.161.68]:41256 "EHLO mail-oo1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgI1So0 (ORCPT ); Mon, 28 Sep 2020 14:44:26 -0400 Received: by mail-oo1-f68.google.com with SMTP id t3so585888ook.8; Mon, 28 Sep 2020 11:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mMpSORkuwjhOa8TOokOcUYzY59laiixLdPiUVCdrAeg=; b=InQEHHl/gI0WQ316S0PTr4UnvWxXgphJCUx91NZYcBBbsWeKsTOxoClY6Br7Wdwg1s 0WhsJona5XcjsF6HUXTCT1Eo78sKutfhHwQs1u0+7h3sPywbiO+KrbiSIIedTeardSlS 4TWmjE9dWAhi/LA7hg+CE0au/uCol3VRTGv3fWyF2dxS2FD7LHbGzB3aZJKAwBd8U2PE yjIhxjZuZdrBiqx6a3/TEATkrgZvyUKZhdgazRkyHUl/SnDOfu+BSXkAIDJFNMzIsoUM s/gLislM+yH+kUz610upP/kcTk4NMe8Bg2GOoFa/qhfaUxsVcHGUSBhdnPx8z7CNqFVv npsA== X-Gm-Message-State: AOAM530Zdvcv6a+ek5WxQ+x80IszRvwLct/uNAQa+tekyOxPSm5Zwjz2 ONWaDTYdG9Y5nWoA3/jtWg== X-Received: by 2002:a4a:a50a:: with SMTP id v10mr1807675ook.4.1601318664841; Mon, 28 Sep 2020 11:44:24 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y23sm2261445ooj.34.2020.09.28.11.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 11:44:24 -0700 (PDT) Received: (nullmailer pid 3059480 invoked by uid 1000); Mon, 28 Sep 2020 18:44:23 -0000 Date: Mon, 28 Sep 2020 13:44:23 -0500 From: Rob Herring To: Gene Chen Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, matthias.bgg@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add bindings for MT6360 LED Message-ID: <20200928184423.GA3041988@bogus> References: <1600865452-19649-1-git-send-email-gene.chen.richtek@gmail.com> <1600865452-19649-2-git-send-email-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600865452-19649-2-git-send-email-gene.chen.richtek@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote: > From: Gene Chen > > Add bindings document for LED support on MT6360 PMIC > > Signed-off-by: Gene Chen > --- > .../devicetree/bindings/leds/leds-mt6360.yaml | 107 +++++++++++++++++++++ > 1 file changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > new file mode 100644 > index 0000000..a356a1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6360 PMIC from MediaTek Integrated. Where's the PMIC schema? This file needs to be referenced from it and that means it all needs to be one series. > + > +maintainers: > + - Gene Chen > + > +description: | > + This module is part of the MT6360 MFD device. > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > + and 4-channel RGB LED support Register/Flash/Breath Mode > + > +properties: > + compatible: > + const: mediatek,mt6360-led > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^led@[0-5]$": > + type: object > + $ref: common.yaml# > + description: > + Properties for a single LED. > + > + properties: > + reg: > + description: Index of the LED. > + enum: > + - 0 # LED output INDICATOR1 > + - 1 # LED output INDICATOR2 > + - 2 # LED output INDICATOR3 > + - 3 # LED output INDICATOR4 > + - 4 # LED output FLED1 > + - 5 # LED output FLED2 > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + led-controller { > + compatible = "mediatek,mt6360-led"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + default-state = "off"; > + }; > + led@1 { > + reg = <1>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + default-state = "off"; > + }; > + led@2 { > + reg = <2>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + default-state = "off"; > + }; > + led@3 { > + reg = <3>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + default-state = "off"; > + }; > + led@4 { > + reg = <4>; > + function = LED_FUNCTION_FLASH; > + color = ; > + function-enumerator = <1>; > + default-state = "off"; > + led-max-microamp = <200000>; > + flash-max-microamp = <500000>; > + flash-max-timeout-us = <1024000>; > + }; > + led@5 { > + reg = <5>; > + function = LED_FUNCTION_FLASH; > + color = ; > + function-enumerator = <2>; > + default-state = "off"; > + led-max-microamp = <200000>; > + flash-max-microamp = <500000>; > + flash-max-timeout-us = <1024000>; > + }; > + }; > +... > -- > 2.7.4 >