Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3285164pxk; Mon, 28 Sep 2020 13:13:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZoLOnp26F+dEq0reioSXARf8JNR9BwV7dPso/azXQ2ovxlEYWcxLiwTmHCqH08NXQo1WY X-Received: by 2002:a17:906:850e:: with SMTP id i14mr483125ejx.168.1601323995520; Mon, 28 Sep 2020 13:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601323995; cv=none; d=google.com; s=arc-20160816; b=oNbGkEBXtXZsxcstMh7gq1gmNPkidUW79XiRRsOsikuJToxEGWoszwjM4plh9dwYmw T4Kkfw2x5t9iN807MRVmHXJgsKwG1uc0za6xyIfSgrLGIc027I2ou+Aw8PPra0XZYqMr 2xjpz9ylF3BKEa5UuvknqmoB5loD7M3l2Y+70UCwvPFhhNRvMdcgiYK4ALOtgO+kLku+ H6ZMpFW0z2AyiDdPO87eLJZkrF5XzTgbiAfRASqp68Tn/91IP/iLvjkCb6aiQbsPLWaO tet0s5IRFmk71p+q/ebdkAWlFBkPWDdcXhzHoroV8mrKS+eFpjXtS02kYj2SC7/xlrTW SgHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S99N8rvF/t2so08QhL6pclkzbq8/CXYQ8U2vW/BH+ec=; b=nr2Y0srJc20BmGVptPUQuNogZfqpDIv4wcIbAPC4J635bPQZg974Pfv0NyZsqGF/a6 9NS+Stg/FPuXstFqQiHc5fKdbTtx5jLE2yzbMFkZaUyGSecFCFN6cES7WZXUt72+8yrO 7a4TbcZtEb9nTzpWkQ96yECGy2R28hOrIK0W7RlfxUJj551xXUSHJwUu+MZBg01Pu5yl CfiB4FzY1Up41tXdEaUfvmcQRC55hN5wB1Odd9QPv1+ckKtIi5iSGxHnL5mGGXVwVLIp EUlZ+pxdYed+Fo9vv3oHF+nCpy5RBJhbqTr2GbE0+EZTERbLl4tGjYI5Fwfw2U4w/heJ UCzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="At/lupLa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp1si1356661ejc.307.2020.09.28.13.12.52; Mon, 28 Sep 2020 13:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="At/lupLa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726590AbgI1UJi (ORCPT + 99 others); Mon, 28 Sep 2020 16:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgI1UJi (ORCPT ); Mon, 28 Sep 2020 16:09:38 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F01BC0613CE for ; Mon, 28 Sep 2020 13:09:38 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id f18so2132272pfa.10 for ; Mon, 28 Sep 2020 13:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S99N8rvF/t2so08QhL6pclkzbq8/CXYQ8U2vW/BH+ec=; b=At/lupLafCk7dwPh75O9pTw9C98MC2piMlqqdXjCzrWBQEXwERGK3FCRzSXAetk9zy wZhTjK+f3R0DZzkscP2AJNyOVoNpsfj0X+47zeF7OmSmo6FJKe1aSrrNF9LeOUO0Yt6M FhtmIbkzd0YQyxlBLICX1+SPytq0egZ0FJQn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S99N8rvF/t2so08QhL6pclkzbq8/CXYQ8U2vW/BH+ec=; b=i/WMhT3iCk+wDZ2GrfmpFKiTc1uHpoOHmbU3BCIlXB18dpCD8LUN37rQcoHHOOoGj1 DjPthtBPy2T5Dh5oBtkVv/SIND6o62fUsDVdnRyvBAUtHUVyW+gQDbcBsjhJi11eztIk YgaiR+XGPkEAYvR98qZp31YDEE2Djrylgt8bJHt1aWKIQ60I+yVapfiLV8woHyEPh57+ KwzxTgD2f0POm/yTQrCoEA7XX5nJ3vBLUVmIxt6DgJ3BaLWTIuyepR7x51VUxoZ4BkWu skhp+MfPG8gt7jLcmJHXZFaqNrhJynGLq+rrrtvLu2TZWSNMpHgZ77u4pR0FhHujo7K4 nm2Q== X-Gm-Message-State: AOAM532LEL2Fg3ir8li8S5+zm9XE/OqayM2MOYAMoX/u0UNEvrZkZyii udkVdIGb3pViWjzhgGoTp0TVRg== X-Received: by 2002:a63:165c:: with SMTP id 28mr527069pgw.302.1601323777776; Mon, 28 Sep 2020 13:09:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l14sm2165383pfc.170.2020.09.28.13.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 13:09:36 -0700 (PDT) Date: Mon, 28 Sep 2020 13:09:36 -0700 From: Kees Cook To: Hangbin Liu Cc: Shuah Khan , Naresh Kamboju , Jonathan Corbet , linux-doc@vger.kernel.org, Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/run_kselftest.sh: Make each test individually selectable Message-ID: <202009281306.CF94D1786@keescook> References: <20200925234527.1885234-1-keescook@chromium.org> <20200925234527.1885234-3-keescook@chromium.org> <20200927024840.GD2531@dhcp-12-153.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200927024840.GD2531@dhcp-12-153.nay.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2020 at 10:48:40AM +0800, Hangbin Liu wrote: > On Fri, Sep 25, 2020 at 04:45:27PM -0700, Kees Cook wrote: > > Currently with run_kselftest.sh there is no way to choose which test > > we could run. All the tests listed in kselftest-list.txt are all run > > every time. This patch enhanced the run_kselftest.sh to make the test > > collections (or tests) individually selectable. e.g.: > > > > $ ./run_kselftest.sh -c seccomp -t timers:posix_timers -t timers:nanosleep > > > > Additionally adds a way to list all known tests with "-l", usage > > with "-h", and perform a dry run without running tests with "-n". > > This is better than my previous patch and we can modify run_kselftest.sh > easily. The Documentation/dev-tools/kselftest.rst should also be update. Thanks! I will send a v2. -- Kees Cook