Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3302330pxk;
        Mon, 28 Sep 2020 13:47:17 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwazS1osxDNK+j5Og4ybxkjHQXl1It2Ri4LcLf7Nc8U4t/xn33lwGCp+F+ROHrRdLupTPyw
X-Received: by 2002:a05:6402:305a:: with SMTP id bu26mr3970768edb.262.1601326037253;
        Mon, 28 Sep 2020 13:47:17 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601326037; cv=none;
        d=google.com; s=arc-20160816;
        b=sXpDLDwA6Ju+jPKA2WV3bQiMFDK7860QiOzGzOnghaMzVGPW07VIPC/7gV1oLC+ry9
         G9KjCNokhSI2gcP0EUlbUrDGHvzjugZCjLc25Mbjs86ukQMiY/hMhFB5573snCYXNFkH
         MGv9KHcYCKIlfmaPnG1YwLITP58CQwbvKZqw/5QzLQLvUTQrUQRLHXz4KMOR2H/ECU3O
         QQeDlX8d+/ChzZ9McD08XSnkjHr16ACaVu5XjIuKT3hlQ1q1Wn9LY4W/7T/j7ecDiCpW
         N4wJdfCoVt8LEtjzkGy56nBeqhNp84jLxZP/Bfctm/Vcj4hki8baZ1Gii2mJmDRdkwSH
         /Q7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=ZNzUuJga0yAMPUYJp+Mbsk5gWocHn8PGlFF35AeQU6M=;
        b=q7wghGyTOjw6DuqVu6rNSpCFJuCaVpZcXJjNV3HOfUweJt4DO4Srs2B2xf1QfXNa9N
         YxakWdTZpjVi0w975BJrDO2SySefsoe9YqU1dGnbJgaJGqcKK0DpR80CHHZYHWxJIsB+
         irlyAsx0Qq1X89iNlyT6PkjNeP+9oc+HnzjaoD3Dxo4bvBonbis2H/A5F4cZlS3wJKWq
         wUudH+Uu7Y7aURUHnA+o/h0SMwWgiBooidR/OiTIipwgdLF48P0zh6exjJ0GjhMfe0c1
         QcEEcZd2xPdHfjr/tCCdecwh4VqaD+xGgylKlWr6YrEvNuxpuwHhEdrGPCDdN8yD10+n
         Df8A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=m5IQA3iW;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e18si1244955ejq.144.2020.09.28.13.46.55;
        Mon, 28 Sep 2020 13:47:17 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=m5IQA3iW;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726839AbgI1Up6 (ORCPT <rfc822;austinkernel.kim@gmail.com>
        + 99 others); Mon, 28 Sep 2020 16:45:58 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:6258 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726281AbgI1Up6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Sep 2020 16:45:58 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f724b220000>; Mon, 28 Sep 2020 13:44:18 -0700
Received: from [10.2.53.30] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 28 Sep
 2020 20:45:57 +0000
Subject: Re: [PATCH 8/8] selftests/vm: hmm-tests: remove the libhugetlbfs
 dependency
From:   John Hubbard <jhubbard@nvidia.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Shuah Khan <shuah@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kselftest@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <linux-s390@vger.kernel.org>
References: <20200928062159.923212-1-jhubbard@nvidia.com>
 <20200928062159.923212-9-jhubbard@nvidia.com>
 <20200928130245.GQ9916@ziepe.ca>
 <982fd9bf-64cb-00e9-f092-13849c7cf7d9@nvidia.com>
Message-ID: <de7ddfb6-e0f8-f70c-f38b-127ec6b54591@nvidia.com>
Date:   Mon, 28 Sep 2020 13:45:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <982fd9bf-64cb-00e9-f092-13849c7cf7d9@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1601325858; bh=ZNzUuJga0yAMPUYJp+Mbsk5gWocHn8PGlFF35AeQU6M=;
        h=Subject:From:To:CC:References:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=m5IQA3iWGf+mZlD+saPKKaP+GSN4PkecL44skN/WMfHCWeNk37hDn5PMtercS3tK6
         Lp2QQuHA9Xj/xMMew2SGfA2kmICe2T0+C2xOut+GVKNp7iBo9QVJ+B6ZTiCBWwct88
         T8nBnsGvpfQ0Tv2rc+csXV/eiQOABg6g4J0ThvAIFFQIAE/Gs9RyB7niQarYyAe+HZ
         QUn0TG+3k8nyf5xQHK59lujZJH/Y3S5qtFqWhA6+9CnsqRq0d9y3dntQbiaKDZ7p1n
         uq8HRKBsBnaiNvulGdhSjuQVJLSLijDk44AC0NT7oB/9lsTgiZ52taQi/N8J9UtfH5
         WACzwgevzothA==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/28/20 1:18 PM, John Hubbard wrote:
> On 9/28/20 6:02 AM, Jason Gunthorpe wrote:
>> On Sun, Sep 27, 2020 at 11:21:59PM -0700, John Hubbard wrote:
> ...
>>> +gcc -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1
>>
>> This gcc has to come from some makefile variable
  I plan on posting a v2 with this additional change, to fix the above point:

diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
index 986a90fa9653..019cbb7f3cf8 100644
--- a/tools/testing/selftests/vm/Makefile
+++ b/tools/testing/selftests/vm/Makefile
@@ -138,7 +138,7 @@ $(OUTPUT)/hmm-tests: local_config.h
  $(OUTPUT)/hmm-tests: LDLIBS += $(HMM_EXTRA_LIBS)

  local_config.mk local_config.h: check_config.sh
-	./check_config.sh
+	./check_config.sh $(CC)

  EXTRA_CLEAN += local_config.mk local_config.h

diff --git a/tools/testing/selftests/vm/check_config.sh b/tools/testing/selftests/vm/check_config.sh
index 651a4b192479..079c8a40b85d 100755
--- a/tools/testing/selftests/vm/check_config.sh
+++ b/tools/testing/selftests/vm/check_config.sh
@@ -16,7 +16,8 @@ echo "#include <sys/types.h>"        > $tmpfile_c
  echo "#include <hugetlbfs.h>"       >> $tmpfile_c
  echo "int func(void) { return 0; }" >> $tmpfile_c

-gcc -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1
+CC=${1:?"Usage: $0 <compiler> # example compiler: gcc"}
+$CC -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1

  if [ -f $tmpfile_o ]; then
      echo "#define LOCAL_CONFIG_HAVE_LIBHUGETLBFS 1" > $OUTPUT_H_FILE



thanks,
-- 
John Hubbard
NVIDIA