Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3330376pxk; Mon, 28 Sep 2020 14:41:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDrxk7hUleFSySt+HCQ0JngeguXr1sKihJAWPZytJDd6ixVrNuz/Uc6/U0ajxFOoV89m1L X-Received: by 2002:a05:6402:304e:: with SMTP id bu14mr19925edb.352.1601329309950; Mon, 28 Sep 2020 14:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601329309; cv=none; d=google.com; s=arc-20160816; b=DcYMvOtTxpm6BZxsNv184ac9GlkuGEoSEfOW0SMB/o5DeWBYYGBPrBy/Pg7bc9MLez zIxQAUJizAvCPyvS2h2mri2+0GkONqgL2YZ8xWqdb9aAHLA7V0xCyZB7yORMfB9S4e8O WtUMH7Dp5COC2JwydoeICOF9EA6p/7SHubn0JOI9BCcvEe/ca7WDr/PPzhvAwYV7dajq Hel9J9nw8wPdtaRkDP8wl+SHVM2y1U1urAbkDqhF4oTG+Ak6ZZktww+1JXgofzW0fnZD a6IWLCc5Ob3fiIzfyQg0zRm6C3aw7KlcCtVmChhMbDwsrih35+aVnV+hkwIPUDDjseki Juzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt :openpgp:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=S/2QRE4uAeFV81j4ymLABZ71FiPdLtm0oeviefGvdwQ=; b=w6xKkU/eVfKAUQZW3pbxzzeKIgVdd1iRLyVtTb5UtNyhAMgSmpGHtB6+b6l2Mv0qsQ +bxFPXIhYhLFeJyqg1F9zQOC48YrLFsANzVS0HtEc6k4O7ZeZo+ngasS6TIq8o0+lJf6 ynwo/xuQhY9uJum1wh0/kBjOHkgpzRi2rl0GQpTljjVtf8YBYJ8sHBDSm5RoL9fLF+Sc Uu7LQ37rHt+33/Vi1Nc14x33bpzRRu3yyuEDIdwVH91Zu7o7DNs+Gq95GELB2SCr54zy LXP+1qYonkMB9A+HmYTmZi3ICUZqHOWc5VuIa0EahIa3Fu9XnEnRs6OxsyX7a7RGHA3a nGlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id br19si1329398ejb.151.2020.09.28.14.41.27; Mon, 28 Sep 2020 14:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgI1VjV (ORCPT + 99 others); Mon, 28 Sep 2020 17:39:21 -0400 Received: from mga06.intel.com ([134.134.136.31]:2319 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgI1VjU (ORCPT ); Mon, 28 Sep 2020 17:39:20 -0400 IronPort-SDR: nsJiMSfFj/tqUBgV9R9It/+G0AZWxqcIPUv069GWofq97sxWR8d+eaVeucSbpsMUaFwr3z0/w3 Ee9XZnGzuWmw== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="223659585" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="223659585" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 14:39:20 -0700 IronPort-SDR: GlduqrY/RsAR9qfNJfV5hZ4/+8xG1G4fwXJT6TGdpdy7PBpzKBETyhlKVbKb8w8Y/UUdNuimGG OTOm8O84+4zQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="457001526" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by orsmga004.jf.intel.com with ESMTP; 28 Sep 2020 14:39:18 -0700 Subject: Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168 To: Kai-Heng Feng , Mathias Nyman Cc: Greg Kroah-Hartman , "open list:USB XHCI DRIVER" , open list References: <20200504171642.26947-1-kai.heng.feng@canonical.com> <0F26EE78-D4F4-4CCB-892B-999E203BF515@canonical.com> <14291E1B-6580-4C69-9EF8-3B30BC78B8D0@canonical.com> From: Mathias Nyman Openpgp: preference=signencrypt Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: <8d913b15-a7e4-5e35-a137-355d222ccf1f@linux.intel.com> Date: Tue, 29 Sep 2020 00:42:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <14291E1B-6580-4C69-9EF8-3B30BC78B8D0@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.9.2020 12.10, Kai-Heng Feng wrote: > > >> On Jun 8, 2020, at 11:56, Kai-Heng Feng wrote: >> >> >> >>> On May 5, 2020, at 01:16, Kai-Heng Feng wrote: >>> >>> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was >>> runtime suspended previously: >>> [ 370.080359] pci 0000:02:00.0: can't change power state from D3cold to D0 (config space inaccessible) >>> [ 370.080477] xhci_hcd 0000:04:00.0: can't change power state from D3cold to D0 (config space inaccessible) >>> [ 370.080532] pcieport 0000:00:1c.0: DPC: containment event, status:0x1f05 source:0x0200 >>> [ 370.080533] pcieport 0000:00:1c.0: DPC: ERR_FATAL detected >>> [ 370.080536] xhci_hcd 0000:04:00.0: can't change power state from D3hot to D0 (config space inaccessible) >>> [ 370.080552] xhci_hcd 0000:04:00.0: AER: can't recover (no error_detected callback) >>> [ 370.080566] usb usb3: root hub lost power or was reset >>> [ 370.080566] usb usb4: root hub lost power or was reset >>> [ 370.080572] xhci_hcd 0000:04:00.0: Host halt failed, -19 >>> [ 370.080574] xhci_hcd 0000:04:00.0: Host not accessible, reset failed. >>> [ 370.080575] xhci_hcd 0000:04:00.0: PCI post-resume error -19! >>> [ 370.080586] xhci_hcd 0000:04:00.0: HC died; cleaning up >>> >>> This can be fixed by not runtime suspend the controller at all. >>> >>> So disable runtime suspend for EJ168 xHCI device. >>> >>> Signed-off-by: Kai-Heng Feng >> >> A gentle ping... > > Another gentle ping... Thanks, somehow I didn't notice this earlier. Was the rootcause ever investigated? Preventing runtime suspend looks like a quick fix to get rid of the issue, but possibly just hides some other underlying power management problem -Mathias