Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3380096pxk; Mon, 28 Sep 2020 16:24:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF4opFqlXCYlJCV1e43LIhhjunq024qpx0PyPDvFKl9RpLvR5MxCK5KNbU5qjmvBCdIo+Z X-Received: by 2002:a17:906:e113:: with SMTP id gj19mr1091725ejb.263.1601335465522; Mon, 28 Sep 2020 16:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601335465; cv=none; d=google.com; s=arc-20160816; b=iHhkdEYDaDkNvJR+TwtuzEVWGSEWc74NBYXzshPTHlQ9zF5eBqjKzErJwGSKgVmF+X Jw/QMHz24fvCa9q/wf04zl9LR81hFXJX6wCZhZLY4ifb/W3AjBOzroSHbgWMweYIUgP6 tcAcJAITXYbSDimy7eFGG+ZC7+7RmKIqbBTgTeAUTEr4a2UM7yqz9VbgquR9n2HlzZwe 0bGsLQP1m8yyCa6LZVrEqt5E4QNQyDXhHEdcE0h+GkfdqANTC0F6y5z20lrrHIoqO34X oZL23KJC5xzgKZvuNHGIbRQGh/dgpdIk9KVF7dgMOGEIquLkcnMusC+VCBEiz0RASNHn em2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=gaA/nbho2rHBM2XGAt+fqZDqrrCyGQoKDIGncDoowiY=; b=QpYR3MdbgWiKsCEyiS9wCqIbUMIa1GlsPH2QmR03/CUDIBlQGhwEjO5WW2JVb6BHzz kxN4r9dt3E+azNk/aRPlhUCUTJ1CX5hAnDG8ipgWd0tui0kmzl8yq4mi0/z+UgJF0Gt/ FeAPYUzesjykFEVzPxC10wX5ucrz2GoW8JNH584Vofas1cvTg/LewoqZmQqSlMlCqeL3 ray4ZJvW92zGszxf/x+Du97dSJkHlbY8ht61rR2pHjGV2Um7Bn7+m2KN3pWVwZvTT4v1 3WF47BGxmwJ0h1tWFFk8iwhEYvs58/L1MnJTgsLIUygZyx90JkCn0zoTD+DFcA2p+pbI a1/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=WpOlbRfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr21si1880431ejc.186.2020.09.28.16.23.56; Mon, 28 Sep 2020 16:24:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=WpOlbRfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbgI1XTG (ORCPT + 99 others); Mon, 28 Sep 2020 19:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbgI1XSm (ORCPT ); Mon, 28 Sep 2020 19:18:42 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B60C0613AF for ; Mon, 28 Sep 2020 15:41:50 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id e5so2949812ilr.8 for ; Mon, 28 Sep 2020 15:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gaA/nbho2rHBM2XGAt+fqZDqrrCyGQoKDIGncDoowiY=; b=WpOlbRfAI9e8II+dnFUMmLCr028LWtZq3VDo3e7fgu588x0zs7KTTS1rPIT60wbAGy cFwY0h5dO4zkUJdnxSGUKs+097/h1H6C3mMVF+vw66IPMyv0pyTPefuI3b/L1Te3OJTD 5HSxT4otUXABTWMa/ya8prB3WhIkjEBLxYMM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gaA/nbho2rHBM2XGAt+fqZDqrrCyGQoKDIGncDoowiY=; b=sozvhSDMcsTF1ek1rmfe+gJD6AAAWMWpQ55x3CQ7AK5zCTP4GdkHQzJRQPbTC4WgGK MjU7mw57QX4rEUKwYvd81X4aeO3f+iUgbi3k6fsLjRcxQGS3alP/ClA99BAGIWR0dC2G WTzYXlrAXbSoZxxGnKDf65zIEPc0c/LHFH9XkBkRi+9/l92KML2g9IxnVCGAJYdGvwWw JERVsVb4JaeEr71HG/UsIGRXxWBQ3vg17W6I1AuBKChO9U7kBH6vVNlKfrAa4P3bV7tg 5sMekeTocuKIGr2xoqPOKVbIfPyRhS7QSvK06O7XnSBCK82J44E237SQqTwhTIbavqCR KdDw== X-Gm-Message-State: AOAM530zgn0/bi35fFLONvNGFACps2QMxIXFVEwNSgcrouknwvqJ+zV2 goZtR/WKEy16i0dhd3bUsK3v6g== X-Received: by 2002:a92:8452:: with SMTP id l79mr459458ild.222.1601332909461; Mon, 28 Sep 2020 15:41:49 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id j1sm1334685ilq.74.2020.09.28.15.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2020 15:41:48 -0700 (PDT) Subject: Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters To: Kees Cook Cc: corbet@lwn.net, gregkh@linuxfoundation.org, shuah@kernel.org, rafael@kernel.org, johannes@sipsolutions.net, lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, christian@brauner.io, hridya@google.com, surenb@google.com, minyard@acm.org, arnd@arndb.de, mchehab@kernel.org, rric@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-acpi@vger.kernel.org, devel@driverdev.osuosl.org, openipmi-developer@lists.sourceforge.net, linux-edac@vger.kernel.org, Shuah Khan References: <202009260923.9A2606CFF6@keescook> From: Shuah Khan Message-ID: <3929a023-eb7a-509c-50e1-ee72dca05191@linuxfoundation.org> Date: Mon, 28 Sep 2020 16:41:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202009260923.9A2606CFF6@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/26/20 10:29 AM, Kees Cook wrote: > On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: >> 7. Verified that the test module compiles in kunit env. and test >> module can be loaded to run the test. > > I meant write it using KUnit interfaces (e.g. KUNIT_EXPECT*(), > kunit_test_suite(), etc): > https://www.kernel.org/doc/html/latest/dev-tools/kunit/ > > Though I see the docs are still not updated[1] to reflect the Kconfig > (CONFIG_foo_KUNIT_TEST) and file naming conventions (foo_kunit.c). > I would like to be able to run this test outside Kunit env., hence the choice to go with a module and kselftest script. It makes it easier to test as part of my workflow as opposed to doing a kunit and build and running it that way. I don't mind adding TEST_COUNTERS to kunit default configs though. thanks, -- Shuah