Subject: Re: [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names
From: Rusty Russell <rusty@rustcorp.com.au>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <ak@muc.de>,
       lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <44D55AEC.1090205@zytor.com>
References: <1154771262.28257.38.camel@localhost.localdomain>
	 <20060806023824.GA41762@muc.de>
	 <1154832963.29151.21.camel@localhost.localdomain>
	 <44D55AEC.1090205@zytor.com>
Content-Type: text/plain
Date: Sun, 06 Aug 2006 13:09:59 +1000
Message-Id: <1154833800.29151.24.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1227
Lines: 31

On Sat, 2006-08-05 at 19:58 -0700, H. Peter Anvin wrote:
> Rusty Russell wrote:
> > 
> > You mean the l and ll variants?  The 64 bit variants are rdmsrl and
> > rdtscll, not to be confused with rdtscl, which returns the lower 32
> > bits.  This confusion caused the x86_64 bug in gameport.c which the
> > patch comment mentioned (at least, seems to be a bug to me).
> > 
> > See why I want to fix these names?
> > 
> > So if you would prefer u64 rdtsc64(), u32 rdtsc_low(), u64 rdmsr64(int
> > msr), u32 rdmsr_low(int msr), I can convert everyone to that, although
> > it's a more invasive change...
> 
> rdmsrl is really misnamed.  It should have been rdmsrq to be consistent, 
> and have rdmsrl return the low 32 bits.

I prefer the more explicit linux-style naming of rdmsr_low32/rdmsr64,
myself, even though this is x86-specific code.  Noone has an excuse for
misunderstanding then...

Thanks!
Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/