Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 18:15:35 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>,
        linux- stable <stable@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH 4.19 38/92] kprobes: Fix NULL pointer dereference at
 kprobe_ftrace_handler
Message-ID: <20200928181535.56d7b2cb@oasis.local.home>
In-Reply-To: <20200928180942.100aa6c8@oasis.local.home>
References: <20200820091537.490965042@linuxfoundation.org>
        <20200820091539.592290034@linuxfoundation.org>
        <CA+G9fYvdQv2Ukvs-UKiEgYaDdBthsWsY=35cQ4YpvMhA0hU5Gg@mail.gmail.com>
        <20200928180942.100aa6c8@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, 28 Sep 2020 18:09:42 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 29 Sep 2020 01:32:59 +0530
> Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> 
> > stable rc branch 4.19 build warning on arm64.
> > 
> > ../kernel/kprobes.c: In function ‘kill_kprobe’:
> > ../kernel/kprobes.c:1070:33: warning: statement with no effect [-Wunused-value]
> >  1070 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> >       |                                 ^
> > ../kernel/kprobes.c:2090:3: note: in expansion of macro ‘disarm_kprobe_ftrace’
> >  2090 |   disarm_kprobe_ftrace(p);
> >       |   ^~~~~~~~~~~~~~~~~~~~  
> 
> Seems to affect upstream as well.
> 

Bah, no (tested the wrong kernel).

You want this commit too:

10de795a5addd ("kprobes: Fix compiler warning for !CONFIG_KPROBES_ON_FTRACE")

-- Steve