Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3386006pxk; Mon, 28 Sep 2020 16:37:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPeRMB98uUfOyHCNP9RgQ5LmalTlAzrJj5ybjKzuYk1G5wtl5J1qwsq/+Kyu23+zdbCEMF X-Received: by 2002:a17:906:28c4:: with SMTP id p4mr1108105ejd.345.1601336266935; Mon, 28 Sep 2020 16:37:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601336266; cv=none; d=google.com; s=arc-20160816; b=rTQ98L95O8dk9N2hnDQKM9rw/PYqMDXF9wJqd+ugMDQ1PG9JaLIO/CAwlEE4ufgs0P k+kew1GMMvsxniBCmQM8mmqpJBap7bEWvo/3NllSwWg0Fqiq3hZnhmk1+Kl/dCwxO4SP ci6IgYcASaGaNyXk3UBxVZQ1G2vEKsMPekIPtU/N0euTjg5lxhzLbX/jT8ReHq4bpwNO lgcqBLHDNyjcD43qMQHa/gYjiggWIl6S9sewZlYMZwn5sOefJeJbZ2RLXk+XaRvhTA+6 DEFQbRB2k/51oGsJIj82lRYHEHAqWjtDyAuwwstrHO1jIY/DuW++aujdTzOHewr+hZOQ g9Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ugAZCBJVnUlRlDJ5cmTo/Ezzz4KVlUC0kF7Wrw2eBl4=; b=tmUcVsdZYiwVU1nIQ4zk8toSJab20DYWBC61+3bfeVe0ybkwBLIlhPHbYp+KF0fKc6 IrkBcO8Xh+0Ht0qyQPnR00zl5m8m2s/ZQDWh5MeIpleieKnreO34fxUZLpn0+1PdPR1Q T25RPxGrh8IiMOOQ+AvF+H3kfkIycnCyWpKr/6v35JT+SxSnoRdj3V3Tuu9Jkkd6qMqj oOBpMfB449MCW6oYdqASKcbuCKTNuwqMm52nIY6HPZnUxrBkoi08nZneqszvxfZZFAWc ail1Rs/UVsVYWqXg60a9VnFXGmC+x5uFiyl7BuBsBpQ7p0j1/BiJPpbPFhQ7obF8JMQ0 HUcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1imhI4mk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si1396729eji.298.2020.09.28.16.37.19; Mon, 28 Sep 2020 16:37:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1imhI4mk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727366AbgI1Xbr (ORCPT + 99 others); Mon, 28 Sep 2020 19:31:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgI1XbG (ORCPT ); Mon, 28 Sep 2020 19:31:06 -0400 Received: from paulmck-ThinkPad-P72.home (unknown [50.45.173.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0976522574; Mon, 28 Sep 2020 23:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601335866; bh=xBvFJr3HzbVvZzRWdMfb7wUEPCUSWv4vIDuq8NJNVFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1imhI4mkLWXcSHTGxW/f2BLOOw9kW98k/AgMpOuc0Wz2BZA9OnsNJ+PnMaqXFP3bD w3rcEO5fUavZm7M5PBDaaHGKAyNI8B4iNgQyyCaqLjsqJkQyQb0SMspiLpyzYkJKAk 6cM+yq8o7yWWQ5dKCIq8FxTqtSENPEzbtMb1IitQ= From: paulmck@kernel.org To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, mhocko@kernel.org, mgorman@techsingularity.net, torvalds@linux-foundation.org, Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , "Paul E . McKenney" Subject: [PATCH tip/core/rcu 08/15] sched: Cleanup PREEMPT_COUNT leftovers Date: Mon, 28 Sep 2020 16:30:55 -0700 Message-Id: <20200928233102.24265-8-paulmck@kernel.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200928233041.GA23230@paulmck-ThinkPad-P72> References: <20200928233041.GA23230@paulmck-ThinkPad-P72> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be removed. Cleanup the leftovers before doing so. Signed-off-by: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Steven Rostedt Cc: Ben Segall Cc: Mel Gorman Cc: Daniel Bristot de Oliveira Signed-off-by: Paul E. McKenney --- kernel/sched/core.c | 6 +----- lib/Kconfig.debug | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 2d95dc3..1c304a1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3706,8 +3706,7 @@ asmlinkage __visible void schedule_tail(struct task_struct *prev) * finish_task_switch() for details. * * finish_task_switch() will drop rq->lock() and lower preempt_count - * and the preempt_enable() will end up enabling preemption (on - * PREEMPT_COUNT kernels). + * and the preempt_enable() will end up enabling preemption. */ rq = finish_task_switch(prev); @@ -7308,9 +7307,6 @@ void __cant_sleep(const char *file, int line, int preempt_offset) if (irqs_disabled()) return; - if (!IS_ENABLED(CONFIG_PREEMPT_COUNT)) - return; - if (preempt_count() > preempt_offset) return; diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index d4d0574..52af6ad 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1320,7 +1320,6 @@ config DEBUG_LOCKDEP config DEBUG_ATOMIC_SLEEP bool "Sleep inside atomic section checking" - select PREEMPT_COUNT depends on DEBUG_KERNEL help If you say Y here, various routines which may sleep will become very -- 2.9.5