Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3437892pxk; Mon, 28 Sep 2020 18:27:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4y81zJOATZuG/+8pKAzyma6/nkJz21uODB8vsQrjseIjzTz5XD6vjhL2gGE1IjLhAm4mH X-Received: by 2002:a17:906:fcc7:: with SMTP id qx7mr1586217ejb.254.1601342836470; Mon, 28 Sep 2020 18:27:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601342836; cv=none; d=google.com; s=arc-20160816; b=LA/DKMFPCwKk5z/7NYPv+wEX3c3TtxE4tx6eV0cE5w/Het47zz3VfYXGaDMDs+4EN7 hUz2LMOEzrooO0BNlUppI8PZo6mFSSPuiB0lovv4CDxEuN1Cwg0LchyKCeqz+QW4MscG SHiDie7yZTLghc/QTLXkVupEAJDf4/7VMUI/rZsxuWjahchdJuqCAEQcLQdap6gqkPt1 x7+aMfxcbk/Z2cGMcijta/HQs464RTH/isWcpA/RHXLqYow9y7HvCYXP4AwYp8EAbRoM rLp+hrhS45rp8Ynt6u2Ad8CCOdWkmwqH71vmfRh1vU4oP3Zqh1hHjCvU1rgEpZh3LYr0 ud0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=KvPSUv9R+pMz0Dzvufnll0M5gsWkV0QDn6imu6rPEjk=; b=wji6UXFxeMWf7MPLOgv9zZBPKqGyYlZFuh8w3m73NH9+iIxsKoseQh+fwYD2gtp9iQ MkUYX2rtEO79wP0heZaFh3dlB9wPdlq1JSrPURrn7pFyfymaPEL8u+TcRwbjCpm/pP8N mh1wWhp9gWgHGAhm0JxusssKgFbRZHJepezi1LuYihLx1rylXmW7E4c6wTVdBI7IcL/5 mldTGxKg67TCrItBzdNJRkNIMAFDGLaqfWbjhvfDH3iH2VK8/VCch74KG92+P2jrKzq0 cmxpKdoSFlVbb9XKXBb5aQn05/ykaKGw7O93QSA8GVQ7K51D917MN/VJNzI7+RkNxaaK zOmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MiAX6Bl5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k19si1768030ejg.563.2020.09.28.18.26.47; Mon, 28 Sep 2020 18:27:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MiAX6Bl5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727269AbgI2BYT (ORCPT + 99 others); Mon, 28 Sep 2020 21:24:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725272AbgI2BYT (ORCPT ); Mon, 28 Sep 2020 21:24:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA143C061755; Mon, 28 Sep 2020 18:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=KvPSUv9R+pMz0Dzvufnll0M5gsWkV0QDn6imu6rPEjk=; b=MiAX6Bl5SpKQryagLT05HOoge+ 7B+iHEAzJYuE26crASPvGyEws7E4Yhxeni3Uhs+XMuDKrgjNT79apZNSXrfWdwp2wOVHtDahFdgt4 sZWXwjqtfunyD4fdSI+6ONkg0Z3CRINr9HJItCvj9CTOxyC4kEUuTui3i3tZGCFVaSZs2b2yHE8Vm +n30qIRgrDtQCjXEtGbtVZUA0JBT/rFcacxJd+TAjiaiKqNG7cBTMQhb4g13KMq0WSXbegSeIkQKa S8fVb70eFiDGQR6QM6nxe6VXJn7bWJbVDKshgd5QTpP0BxANSmbY0qXAqeTJ0VHWZYR0VxNw3McEt FieYV3zQ==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN4NM-0003lZ-7I; Tue, 29 Sep 2020 01:24:16 +0000 Subject: Re: [PATCH V6 5/5] platform/x86: Intel PMT Crashlog capability driver To: "David E. Box" , lee.jones@linaro.org, dvhart@infradead.org, andy@infradead.org, bhelgaas@google.com, alexander.h.duyck@linux.intel.com, hdegoede@redhat.com, alexey.budankov@linux.intel.com Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org References: <20200929005320.14739-1-david.e.box@linux.intel.com> <20200929005320.14739-6-david.e.box@linux.intel.com> From: Randy Dunlap Message-ID: <7b757ee6-52ba-5b77-5b89-d6bbd5817d11@infradead.org> Date: Mon, 28 Sep 2020 18:24:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200929005320.14739-6-david.e.box@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/20 5:53 PM, David E. Box wrote: > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 02cb2db11417..675f3396b341 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1377,6 +1377,14 @@ config INTEL_PMT_TELEMETRY > access to hardware telemetry metrics on devices that support the > feature. > > +config INTEL_PMT_CRASHLOG > + tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver" > + select INTEL_PMT_CLASS > + help > + The Intel Platform Monitoring Technology (PMT) crashlog driver provides > + access to hardware crashlog capabilities on devices that support the > + feature. > + Documentation/process/coding-style.rst, section 10: Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. -- ~Randy