Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3440334pxk; Mon, 28 Sep 2020 18:32:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDKtjXim6oO531Tc7nadqhwmSn/rKVpcQJgqlIIIeazkJefFgGnxcpzisxNkvYb1S8dLsx X-Received: by 2002:a50:8523:: with SMTP id 32mr822098edr.282.1601343145828; Mon, 28 Sep 2020 18:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601343145; cv=none; d=google.com; s=arc-20160816; b=WhZaVqCyYzf5raOBiKuiOzQ0Ib6ppHfrJCby6rHk/uRUa2hLLjr3vgh+YYg7Ld8zS9 YuF8LZIXTf5P1u53hoO9RdzSQ4k14UIzkGFkQNEUCNGUr/VKojtBD1A2YCpNCnTqE3lY 2k6/1ExBeGfv3kRal4zEFZ4Sc2/Ti6aWN/c+X04XqJPzhgkkALsZFsk4PqFhjH0IrFLl Hk9o9h97ULggb4jzl4CQBXCjnjNWWY5zWo985pHGBuxi/DPFEHdEG6t5hyO8aE1doxbd KrD5VjufAkWDAMGgqS7zA3A2NMbphdtH6NMktie3IP7TMyA5CC9iqLsyqyFWb4Uar2OD QVPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bieVBAf0tXHK0yxx6ThhHhjeZTLZWnZ1REQrrbUC2T0=; b=iA9hgYElPNjspiqf1fCnRvAl+f7u6A3FHu9+Ep1+ZDEM7rOCMJnUyfruL+19BCYZM2 9c+JWV3kqUYbom96MU2OHdwTqBqD5+F7Q214775oyNS4qheqGLNgwgKmtardvq43U/Zt x8Z2HUogNAgFigylUUbO12mVuaEwQramAD9x9LtLRhWKgIVl2SFfNmOMXTkm7dulDP2U YlRssZwsPzecnnHb1BRE1obXDdsed/odJs+LijGAwrxs4dG7P3Yv0Z7RZzBuuDrqAoi4 rH0Cn8oplF3lh3w/d9giGjFTXyrPPIFslFOiYOKeRX1n4/FF8EUg3dtfyeO89GBNk/dA GZHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DQpo1itr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si1895893eds.69.2020.09.28.18.31.55; Mon, 28 Sep 2020 18:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DQpo1itr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbgI2Bae (ORCPT + 99 others); Mon, 28 Sep 2020 21:30:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgI2Bab (ORCPT ); Mon, 28 Sep 2020 21:30:31 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACD3621734; Tue, 29 Sep 2020 01:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601343030; bh=zB0SGeeoNPVMkVnQLXd5mspfS30Xe6OaobqccoNYGuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQpo1itrfHYIa3bfnoMVkPwryZ7WZ/jrEMBr4My59eNxYqJEzVGgsMBFFxzuXYrXR biaoBXMdWEeFagKD5o6sotBwbtzgJzY5J5ty4AtPTPhYYonebFCNPLJFtZjMUNiLmN wkvo1X8d8W1/55P0sRhoHIXjTzgP8mQYurOQbpEM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans de Goede , kernel test robot , Dan Carpenter , Al Viro , Sasha Levin , linux-fsdevel@vger.kernel.org Subject: [PATCH AUTOSEL 5.8 02/29] vboxsf: Fix the check for the old binary mount-arguments struct Date: Mon, 28 Sep 2020 21:29:59 -0400 Message-Id: <20200929013027.2406344-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200929013027.2406344-1-sashal@kernel.org> References: <20200929013027.2406344-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede [ Upstream commit 9d682ea6bcc76b8b2691c79add59f7d99c881635 ] Fix the check for the mainline vboxsf code being used with the old mount.vboxsf mount binary from the out-of-tree vboxsf version doing a comparison between signed and unsigned data types. This fixes the following smatch warnings: fs/vboxsf/super.c:390 vboxsf_parse_monolithic() warn: impossible condition '(options[1] == (255)) => ((-128)-127 == 255)' fs/vboxsf/super.c:391 vboxsf_parse_monolithic() warn: impossible condition '(options[2] == (254)) => ((-128)-127 == 254)' fs/vboxsf/super.c:392 vboxsf_parse_monolithic() warn: impossible condition '(options[3] == (253)) => ((-128)-127 == 253)' Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Hans de Goede Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/vboxsf/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c index 8fe03b4a0d2b0..25aade3441922 100644 --- a/fs/vboxsf/super.c +++ b/fs/vboxsf/super.c @@ -384,7 +384,7 @@ static int vboxsf_setup(void) static int vboxsf_parse_monolithic(struct fs_context *fc, void *data) { - char *options = data; + unsigned char *options = data; if (options && options[0] == VBSF_MOUNT_SIGNATURE_BYTE_0 && options[1] == VBSF_MOUNT_SIGNATURE_BYTE_1 && -- 2.25.1