Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "chunfeng.yun@mediatek.com" <chunfeng.yun@mediatek.com>,
        "yanaijie@huawei.com" <yanaijie@huawei.com>
Subject: Re: [PATCH 0/8] Introduced new Cadence USBSSP DRD Driver.
Thread-Topic: [PATCH 0/8] Introduced new Cadence USBSSP DRD Driver.
Thread-Index: AQHWlZOgx8QuRR8gQ06qRBCVZ4Wqcal+9IAA
Date:   Tue, 29 Sep 2020 03:24:03 +0000
Message-ID: <20200929032258.GA9076@b29397-desktop>
References: <20200928122741.17884-1-pawell@cadence.com>
In-Reply-To: <20200928122741.17884-1-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <40B5B350F1D5C04DB0B5F303587A7397@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 569573c7-1c67-448e-aa52-08d864271d6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 03:24:03.1646
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ca+1IUl0X/v2Hx9mz5J+GzFN2srx1eu3j4VS7Q69qA0XW0EW7XjAqMwtE3oPFkiIAPn/aZocfrDoQfohvmCQ7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6372
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-09-28 14:27:33, Pawel Laszczak wrote:
> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>=20
> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> Host Only (XHCI)configurations.
>=20
> The current driver has been validated with FPGA burned. We have support
> for PCIe bus, which is used on FPGA prototyping.
>=20
> The host side of USBSS-DRD controller is compliance with XHCI
> specification, so it works with standard XHCI Linux driver.
>=20
> The host side of USBSS DRD controller is compliant with XHCI.

The device side?

> The architecture for device side is almost the same as for host side,
> and most of the XHCI specification can be used to understand how
> this controller operates.
>=20
> This controller and driver support Full Speed, Hight Speed, Supper Speed
> and Supper Speed Plus USB protocol.
>=20
> The prefix cdnsp used in driver has chosen by analogy to cdn3 driver.
> The last letter of this acronym means PLUS. The formal name of controller
> is USBSSP but it's to generic so I've decided to use CDNSP.
>=20
> The patch 1: adds support for DRD CDNSP.=20
> The patch 2: separates common code that can be reusable by cdnsp driver.
> The patch 3: moves reusable code to separate module.
> The patch 4: changes prefixes in reusable code frome cdns3 to common cdns=
.
> The patch 5: adopts gadget_dev pointer in cdns structure to make possible=
=20
> 	     use it in both drivers.
> The patches 6-8: add the main part of driver and has been intentionally
>              split into 3 part. In my opinion such division should not
>              affect understanding and reviewing the driver, and cause tha=
t
>              main patch (7/8) is little smaller. Patch 6 introduces main
>              header file for driver, 7 is the main part that implements a=
ll
>              functionality of driver and 8 introduces tracepoints.
>=20
> ---
>=20
> Pawel Laszczak (7):
>   usb: cdns3: Add support for DRD CDNSP
>   usb: cdns3: Split core.c into cdns3-plat and core.c file
>   usb: cdns3: Moves reusable code to separate module
>   usb: cdns3: Refactoring names in reusable code
>   usb: cdns3: Changed type of gadget_dev in cdns structure
>   usb: cdnsp: Device side header file for CDNSP driver
>   usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver
>   usb: cdnsp: Add tracepoints for CDNSP driver
>=20
>  drivers/usb/Kconfig               |    1 +
>  drivers/usb/Makefile              |    1 +
>  drivers/usb/cdns3/Kconfig         |    8 +
>  drivers/usb/cdns3/Makefile        |    8 +-
>  drivers/usb/cdns3/cdns3-plat.c    |  209 +++
>  drivers/usb/cdns3/core.c          |  336 ++--
>  drivers/usb/cdns3/core.h          |   51 +-
>  drivers/usb/cdns3/drd.c           |  219 ++-
>  drivers/usb/cdns3/drd.h           |   93 +-
>  drivers/usb/cdns3/gadget-export.h |   26 +-
>  drivers/usb/cdns3/gadget.c        |   29 +-
>  drivers/usb/cdns3/host-export.h   |   10 +-
>  drivers/usb/cdns3/host.c          |   23 +-
>  drivers/usb/cdnsp/Kconfig         |   40 +
>  drivers/usb/cdnsp/Makefile        |   12 +
>  drivers/usb/cdnsp/cdnsp-pci.c     |  247 +++
>  drivers/usb/cdnsp/debug.h         |  583 +++++++
>  drivers/usb/cdnsp/ep0.c           |  500 ++++++
>  drivers/usb/cdnsp/gadget.c        | 2009 ++++++++++++++++++++++++
>  drivers/usb/cdnsp/gadget.h        | 1598 +++++++++++++++++++
>  drivers/usb/cdnsp/mem.c           | 1326 ++++++++++++++++
>  drivers/usb/cdnsp/ring.c          | 2426 +++++++++++++++++++++++++++++
>  drivers/usb/cdnsp/trace.c         |   12 +
>  drivers/usb/cdnsp/trace.h         |  840 ++++++++++
>  24 files changed, 10228 insertions(+), 379 deletions(-)
>  create mode 100644 drivers/usb/cdns3/cdns3-plat.c
>  create mode 100644 drivers/usb/cdnsp/Kconfig
>  create mode 100644 drivers/usb/cdnsp/Makefile
>  create mode 100644 drivers/usb/cdnsp/cdnsp-pci.c
>  create mode 100644 drivers/usb/cdnsp/debug.h
>  create mode 100644 drivers/usb/cdnsp/ep0.c
>  create mode 100644 drivers/usb/cdnsp/gadget.c
>  create mode 100644 drivers/usb/cdnsp/gadget.h
>  create mode 100644 drivers/usb/cdnsp/mem.c
>  create mode 100644 drivers/usb/cdnsp/ring.c
>  create mode 100644 drivers/usb/cdnsp/trace.c
>  create mode 100644 drivers/usb/cdnsp/trace.h
>=20
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=