Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3501317pxk; Mon, 28 Sep 2020 21:09:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+HJT27iLEObu9v8DbSkKo+RGB0TH0nB6HLsZo657uSB60lE2nFjcpF2N+ldV+iC3y79VD X-Received: by 2002:a17:907:40c1:: with SMTP id nv1mr2039990ejb.318.1601352559928; Mon, 28 Sep 2020 21:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601352559; cv=none; d=google.com; s=arc-20160816; b=YULi3Cf8eLl7W06F0NIDv8NaEw8+mlcGJ65zlMxdzfL0JJFFWZ60x0wmEla4HLKFpS QovD1erilAiyCVr4DlZAMtiOdI5u4RrVzifIhy6DWR+Kh4MyrjNSkj4A/jAFsuyMctqy A520+LtQFTsbzp8JhSBe5Yei65no6GJ5OYS0c6lvMHqgwOnYGKML+qQMzInpwJm38NSB H5vBFUnYq7Q42NakeItisb1BY8yXUkcUC59H7aUDYeLJeZIjicz0lfqshlwCFk4NLbRa ze293nZXiz2RgB9qbfv9LoSWgEBXr81zwKK97ROw6clQ6eEdSIXYmKafxgjrQ7wVCbEe mw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=8YsXwgo3KPHwWcfe1EqRif6k6a8lufSqL4k1+GmC9Iw=; b=pkOI910bSFX/Xy+rUb8cQE3C2IX72c75fTAdcMbtO1J6RmYNfMJxdY9akm6eh4et4A 1/AgiQEV9960QWLMNSOly9dguaB/lhj79J1xLjG3OJ3qLGvznIgeSeHQNdpZXaBB7RSK uQ1b2bSg2mVk8PVVOXxA70e5tnAyzw8zWe7qY0BvimiePFum5X1pq7R0R+pAm5APrVKo K6WVRLqaQ9a6uERPf67ME1Ri4VAnN8tNdmQvMTZpvX+QGPeZzqZGt5c7EtprOIA5U937 4hU1FGFeD24T8K41qRw71E+8h7r49tdueei/O29f/wS4vSntDY/3BhU1VzTyjo4Emq/T ZLRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OEr1kq2U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs17si2080712ejb.309.2020.09.28.21.08.51; Mon, 28 Sep 2020 21:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OEr1kq2U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725730AbgI2EGm (ORCPT + 99 others); Tue, 29 Sep 2020 00:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgI2EGl (ORCPT ); Tue, 29 Sep 2020 00:06:41 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18264C061755; Mon, 28 Sep 2020 21:06:41 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id r24so2842709ljm.3; Mon, 28 Sep 2020 21:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8YsXwgo3KPHwWcfe1EqRif6k6a8lufSqL4k1+GmC9Iw=; b=OEr1kq2UweWPHFgI55L5tGm1VUAj9zkJkt+i/OPT+VVHA2UQ1CgP9k9YrXcCA3L0jO uTnqUmj7mkEb8FYPmMTSF0Epy/R+kq9D8L1Z4hqVpxkCHU9tcGUWRTothsLwUf/VV0fc hX7P6xJX6prz8QTvT0vv6eEIE9B1D/wGfLCTDtiL+PBsOuJ1iLNPhM420SxF1Yl668nF 4ip8gNOJBYZ3+RrhgY1B1ak4X99rctj3Fh49y/11xd6q7OETNR8swvaK9OKsy3lINd4F 5c7EBEYI3CFagkY1v1DZG4rcLat7a5POPH48T/Air8R+8ESbwx/2Qx+1FeKqDnYgoju9 0aeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8YsXwgo3KPHwWcfe1EqRif6k6a8lufSqL4k1+GmC9Iw=; b=kuHi4daiue1Fz/GOrwXbmVZStmt+fGdRkRHy+BnyU4dFkx0FcqU1Nwlt7BrJgaE8eW MyiGpZJSIzyRIZ1QKVTpz0xSaCvVrcdiU7q2m4lfRnpClrUxY7bJzD0vKkohYxva/x1g /cHFuEFpLnVqARtf1UekZlXss9GsYgJrwsDJRAJJLBDf9kLMproar703kGLWtl0WRhyF CUSmwHMbqfbzgKeS4S9g9LV7GN7Oq1o6q2WSjt5r8eOJkzuIXZY69EkG9hVWhjMycWJv hJIxwWsgzs4wQICYcwaVpdST/lAWzOak6+4lomLjcksMyzuA+tfYhpRGWYfn0pyLhOS/ hz8w== X-Gm-Message-State: AOAM531zglM2j1XGN9milX4G4rUsgck7Z7vFVT9l75ebt2/Op8LFM2zr u5KlDxtFx6+OpfoGt4SgbIWgbRrWZIY= X-Received: by 2002:a05:651c:543:: with SMTP id q3mr490972ljp.6.1601352398288; Mon, 28 Sep 2020 21:06:38 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id p21sm3081470lfo.194.2020.09.28.21.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2020 21:06:37 -0700 (PDT) Subject: Re: [PATCH 3/5] iommu/tegra-smmu: Use iommu_fwspec in .probe_/.attach_device() To: Nicolin Chen , Thierry Reding Cc: linux-kernel@vger.kernel.org, krzk@kernel.org, jonathanh@nvidia.com, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org References: <20200926080719.6822-1-nicoleotsuka@gmail.com> <20200926080719.6822-4-nicoleotsuka@gmail.com> <20200928075212.GF2837573@ulmo> <20200928221829.GB15720@Asurada-Nvidia> From: Dmitry Osipenko Message-ID: <2a38018a-3f95-74da-6dc1-270efc26a8fb@gmail.com> Date: Tue, 29 Sep 2020 07:06:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200928221829.GB15720@Asurada-Nvidia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... >> As I mentioned in another reply, I think tegra_smmu_find() should be all >> you need in this case. > > This function is used by .probe_device() where its dev pointer is > an SMMU client. IIUC, tegra_smmu_find() needs np pointer of "mc". > For a PCI device that doesn't have a DT node with iommus property, > not sure how we can use tegra_smmu_find(). Perhaps you could get np from struct pci_dev.bus?