Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "chunfeng.yun@mediatek.com" <chunfeng.yun@mediatek.com>,
        "yanaijie@huawei.com" <yanaijie@huawei.com>
Subject: Re: [PATCH 5/8] usb: cdns3: Changed type of gadget_dev in cdns
 structure
Thread-Topic: [PATCH 5/8] usb: cdns3: Changed type of gadget_dev in cdns
 structure
Thread-Index: AQHWlZOfv2py0oF9mkmHy9/gJKGhyql/CKoA
Date:   Tue, 29 Sep 2020 04:36:12 +0000
Message-ID: <20200929043508.GC9076@b29397-desktop>
References: <20200928122741.17884-1-pawell@cadence.com>
 <20200928122741.17884-6-pawell@cadence.com>
In-Reply-To: <20200928122741.17884-6-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <388014B0FD69F847BA54C946059BAAAD@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: db64688f-1d5b-41da-e743-08d8643131ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 04:36:12.5466
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dfwEn560Wd3mHFMAu5HpZeuGa/o6muIYtlxf+U45+QByEkT+BSeZ8dqLkOxdBV9OjVABI26qmYdcBB32/zw6EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5443
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-09-28 14:27:38, Pawel Laszczak wrote:
> Patch changes the type for gadget_dev pointer in cdns structure from
> pointer to cdns3_device structure to void pointer.
> This filed is in reusable code and after this change it will be used to
> point to both cdns3_device or cdnsp_device objects.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/core.h   | 4 ++--
>  drivers/usb/cdns3/gadget.c | 6 ++++++
>  2 files changed, 8 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
> index 0c6e14683b36..267923904a37 100644
> --- a/drivers/usb/cdns3/core.h
> +++ b/drivers/usb/cdns3/core.h
> @@ -55,7 +55,7 @@ struct cdns_role_driver {
>   * @roles: array of supported roles for this controller
>   * @role: current role
>   * @host_dev: the child host device pointer for cdns core
> - * @gadget_dev: the child gadget device pointer for cdns3 core
> + * @gadget_dev: the child gadget device pointer
>   * @usb2_phy: pointer to USB2 PHY
>   * @usb3_phy: pointer to USB3 PHY
>   * @mutex: the mutex for concurrent code at driver
> @@ -87,7 +87,7 @@ struct cdns {
>  	struct cdns_role_driver	*roles[USB_ROLE_DEVICE + 1];
>  	enum usb_role			role;
>  	struct platform_device		*host_dev;
> -	struct cdns3_device		*gadget_dev;
> +	void				*gadget_dev;
>  	struct phy			*usb2_phy;
>  	struct phy			*usb3_phy;
>  	/* mutext used in workqueue*/
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 26f68182e65e..f9cbc84bbfb8 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -3177,7 +3177,9 @@ static int __cdns3_gadget_init(struct cdns *cdns)
>  static int cdns3_gadget_suspend(struct cdns *cdns, bool do_wakeup)
>  {
>  	struct cdns3_device *priv_dev =3D cdns->gadget_dev;
> +	unsigned long flags;
> =20
> +	spin_lock_irqsave(&priv_dev->lock, flags);

unrelated changes?

>  	cdns3_disconnect_gadget(priv_dev);
> =20
>  	priv_dev->gadget.speed =3D USB_SPEED_UNKNOWN;
> @@ -3186,6 +3188,7 @@ static int cdns3_gadget_suspend(struct cdns *cdns, =
bool do_wakeup)
> =20
>  	/* disable interrupt for device */
>  	writel(0, &priv_dev->regs->usb_ien);
> +	spin_unlock_irqrestore(&priv_dev->lock, flags);
> =20
>  	return 0;
>  }
> @@ -3193,11 +3196,14 @@ static int cdns3_gadget_suspend(struct cdns *cdns=
, bool do_wakeup)
>  static int cdns3_gadget_resume(struct cdns *cdns, bool hibernated)
>  {
>  	struct cdns3_device *priv_dev =3D cdns->gadget_dev;
> +	unsigned long flags;
> =20
>  	if (!priv_dev->gadget_driver)
>  		return 0;
> =20
> +	spin_lock_irqsave(&priv_dev->lock, flags);

ditto

>  	cdns3_gadget_config(priv_dev);
> +	spin_unlock_irqrestore(&priv_dev->lock, flags);
> =20
>  	return 0;
>  }
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=