Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 22:35:25 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     Lorenz Bauer <lmb@cloudflare.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Sitnicki <jakub@cloudflare.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, <kernel-team@cloudflare.com>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/4] bpf: sockmap: enable map_update_elem
 from bpf_iter
Message-ID: <20200929053525.aje3oavmcrbzmo34@kafai-mbp>
References: <20200928090805.23343-1-lmb@cloudflare.com>
 <20200928090805.23343-2-lmb@cloudflare.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200928090805.23343-2-lmb@cloudflare.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp (2620:10d:c090:400::5:d609) by MWHPR15CA0038.namprd15.prod.outlook.com (2603:10b6:300:ad::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Tue, 29 Sep 2020 05:35:31 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 722cc334-f5d6-4771-d8b1-08d864397baf
X-MS-TrafficTypeDiagnostic: BYAPR15MB3255:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3255D2A20950082BBE65F371D5320@BYAPR15MB3255.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cPG1E/8a0qGbFkD7AgI2hOu3TIHfqzqsfBMFA6cohcFEijwBn6oy7U55HRedr3Ma9p7iMDlbyNamut/N1DQ5MpcDBCCvswaNMeKE3mkhYIQ3QjJnrdAOE6JPq5/XEJWJbR7HZu6IO35uCZJEC9fmXgtnXBNE2yrkelEqLEHtO5G9oEPoFPStJKujf/oe5ekC7VjvHe1xoScwIhap72g5iaNgXFAlcLmGU8Krw9hBNgrJdSal/Z2BeQds5KjR+TubvZd5ZToifZOnWoZ3ZbphkqReBlJGE6IOoIfBX2Y7pEdTk0Tx6xJW8zPyHZ18dPWyRZOeGSECeHhILp8wqWZ5B0+XON2Q8X6pkWnpZLmm4Bc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3571.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(136003)(396003)(39860400002)(16526019)(52116002)(186003)(7416002)(6666004)(6496006)(316002)(1076003)(54906003)(4744005)(4326008)(5660300002)(2906002)(86362001)(8676002)(478600001)(8936002)(55016002)(66946007)(66556008)(6916009)(33716001)(83380400001)(66476007)(9686003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: u6zDlN19bw+9PdGMPn4cz9zGQ3o85UafYnuILddcAl8spmzoY8ON4o5izeBYvyQsEVL9TFy/VWSsN+IB1ybz1BkIKbMJ+/QoMjLB1wk4t5U/3R2/mc7mMDoNF2FP5Y+hI3AVd/KesSAH9hkZ1hHVgXNWy5UTIxWD5tOtY5Ski40AlcWV8Z59Q0yWOP99tD2GOYaIetdr0AvsA4bczb/LonsRFyNeeXqYBubpWEoOeQzSx52x66PLgqRY0t7sphM9CNMkxerP6NvMWqI2j2R1UaQLSwlM6u8/4juCyzGujcrhCCxG+J846oSgaF4GJrEYVPkBoK4F3J8l+dFL2kYZGOkoJFVHEt9PCxgXgMtPSKBZXh0ApJ08mGWQskiG2okDYsDCMrLYl45XqGm4Bhhp0oogquZFAgNdNiPTxLPbt8sEV44OZJhJB4KEi9E8SIde62094z5ag2QtVjp9SnRmLfiWDs5BHA7sphT5316bfMMNR4FmCTkB1HbI1qgOYizyQNg4qRYIl3oUs1aq9+QJxqkB705whblmxc84XI3hbB8hTucN6fBo/LLeipPTHeGSm3my0QvvtvSLVRSNAud6ZV0y8m2mSLe03xjkVCwMdAfq0KgbwrRtdG7a6tm/n+avo0dmPWDyHYR9pINw85KmPCGHv51LsD2JUmcVdYWgzno=
X-MS-Exchange-CrossTenant-Network-Message-Id: 722cc334-f5d6-4771-d8b1-08d864397baf
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3571.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 05:35:32.6968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KfRlS+DW9vNKhcvYxJINPdbJs12BvZylOfyM375bxw/kedV4Quw305F8pTMjgsOZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3255
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-29_01:2020-09-28,2020-09-29 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=1
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=843
 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2006250000 definitions=main-2009290054
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 28, 2020 at 10:08:02AM +0100, Lorenz Bauer wrote:
> Allow passing a pointer to a BTF struct sock_common* when updating
> a sockmap or sockhash. Since BTF pointers can fault and therefore be
> NULL at runtime we need to add an additional !sk check to
> sock_map_update_elem. Since we may be passed a request or timewait
> socket we also need to check sk_fullsock. Doing this allows calling
> map_update_elem on sockmap from bpf_iter context, which uses
> BTF pointers.
Acked-by: Martin KaFai Lau <kafai@fb.com>