Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Sep 2020 22:59:05 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     Lorenz Bauer <lmb@cloudflare.com>
CC:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        <kernel-team@cloudflare.com>, <linux-kselftest@vger.kernel.org>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare
 socket cookies
Message-ID: <20200929055851.n7fa3os7iu7grni3@kafai-mbp>
References: <20200928090805.23343-1-lmb@cloudflare.com>
 <20200928090805.23343-3-lmb@cloudflare.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200928090805.23343-3-lmb@cloudflare.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp (2620:10d:c090:400::5:d609) by CO1PR15CA0085.namprd15.prod.outlook.com (2603:10b6:101:20::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22 via Frontend Transport; Tue, 29 Sep 2020 05:59:10 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 864bc275-3401-4845-d346-08d8643cc94f
X-MS-TrafficTypeDiagnostic: BYAPR15MB3207:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3207356CA0CCE1A9114056C2D5320@BYAPR15MB3207.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:1079;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wZdoL0sAaQRJ3l9nMlCATfanpKVn3a3MAMJuC2jir9K32eRxwsQ+I1H+MNTUj0QNzookxdBi5F0lo4SmG8XS7RpnbwGZLcf0C0QKsWKdth2XNd2CqpjQnyeqWEzxLduvl2lssBozC+rmYQaTzhIbJBksJXLHf3EtgacRk5m0abcofQWNhrsRJGl8HgWHrKiv/COqRV4lZ0mrZLnNgIRgGggcpTNBcccTd37pld25Ti9kbjgyeOuD2RqSkWgNUOBqbxSZjlGyvnceMERAhJepSkWTu3mOaqpCbzo5Dgz8sAzd9EyPzhXUQZ+T/Y7JSQ4q9S8nuFs4PmcyP8o4Ai0oqgog7klp3peYAPx3anAoK/s8Rx66oh22FRdocHcsPl3+
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3571.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(346002)(376002)(366004)(396003)(66946007)(66556008)(66476007)(4744005)(1076003)(4326008)(2906002)(86362001)(33716001)(8676002)(316002)(8936002)(478600001)(6666004)(6916009)(54906003)(52116002)(5660300002)(186003)(83380400001)(55016002)(9686003)(16526019)(6496006);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: TRIrg1HdjDoSHUFNE1+fprx0J0tLM4BeDS0leMD28a3nFYT/08fgskuU49T9R1Yazdn6Q39KHyutw87+QyVCH+cPfNvmUT5le2LrFlcLry9Qhpz5J9BVZrH99VEet2aUvE00ZyN0ESzrFfkekHNvFNi03yReXfsqdKcdwSTzqaopnawWuGsczJbvbEGBAF03VGiKORSajlmvWB/NSgFO/iMSAo3GyqNKdG7IX7D+L1QKscrRykXiYSDrtJKEvDl4ImlxhxmfxtPRv9/XeykIxV+RniwAJERXxPc0UUMEO2j6ScZMmsAT4rpQfjHSHZ27M2rnpl8SYVrxe0jwLP2ns8k0/zwD4w8+aFvjpT+FEwtNE1PomOU+bTsampepcSmoOEHHVc5k5J6NLqkS/aHFGIyYnlgJEL/Ub157Wedy6jC7+hKZ/pHRJhYSrIAnyQb9OMnO2E9HGkY6dQVCPvzOGCLyAoZl58H+rRe67nL77U0iqFZfmaOo8Nwf41tskHirtFPrRI4+lxoicr31ObDZoiSKxr6VRnH3ySw6qqBP3pCmw0LugiNY2XewpciPbwVq81TZE7kgYVuMJ5UsscPDEArW1fQj+tFobdSPIVVSJFpJgKMCX7sFAhfpG7xH2Bqz/lFUcUquLrXpzC8vxQSbrXPzWEjDRwBv/ezrZYprIp1AbjxOwoAggOUhd2r6OCXL
X-MS-Exchange-CrossTenant-Network-Message-Id: 864bc275-3401-4845-d346-08d8643cc94f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3571.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 05:59:11.6389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: srlgCrocJeCKVxXHcYUKxLM7yIcb6thjMR9zmSILWNqcICNx72Dz+USbwLFpqbnl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3207
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-29_01:2020-09-29,2020-09-29 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 spamscore=0
 mlxlogscore=999 priorityscore=1501 adultscore=0 clxscore=1011
 lowpriorityscore=0 malwarescore=0 suspectscore=1 impostorscore=0
 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2006250000 definitions=main-2009290058
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 28, 2020 at 10:08:03AM +0100, Lorenz Bauer wrote:
> We compare socket cookies to ensure that insertion into a sockmap worked.
> Pull this out into a helper function for use in other tests.
> 
> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
> ---
>  .../selftests/bpf/prog_tests/sockmap_basic.c  | 50 +++++++++++++------
>  1 file changed, 36 insertions(+), 14 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> index 4b7a527e7e82..67d3301bdf81 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> @@ -50,6 +50,37 @@ static int connected_socket_v4(void)
>  	return -1;
>  }
>  
> +static void compare_cookies(struct bpf_map *src, struct bpf_map *dst)
> +{
> +	__u32 i, max_entries = bpf_map__max_entries(src);
> +	int err, duration, src_fd, dst_fd;
This should have a compiler warning.  "duration" is not initialized.