Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: sound/soc/ti/j721e-evm.c:528:34: warning: unused variable
 'j721e_audio_of_match'
To:     Mark Brown <broonie@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
CC:     kernel test robot <lkp@intel.com>, <kbuild-all@lists.01.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <202009271553.4OjMpGkX%lkp@intel.com>
 <76cae106-b643-57a9-e82e-48e46ebf1b70@ti.com>
 <CAKwvOdnsQY6S+3zAH6_SD0ifbUaSDFj9mBdhF4GVq6VB=tjFsA@mail.gmail.com>
 <20200928180412.GA4827@sirena.org.uk>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <c97e8363-1e8e-38fe-3214-cff47f09e459@ti.com>
Date:   Tue, 29 Sep 2020 09:00:02 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200928180412.GA4827@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 28/09/2020 21.04, Mark Brown wrote:
> On Mon, Sep 28, 2020 at 10:52:54AM -0700, Nick Desaulniers wrote:
>> On Mon, Sep 28, 2020 at 12:27 AM 'Peter Ujfalusi' via Clang Built
>=20
>>> Right, in the attached .config:
>>> # CONFIG_OF is not set
>=20
>>> There must be a clean way to handle this without extensive ifedfery..=
=2E
>=20
>> Pretty sure I just saw a patch go by wrapping another device table
>> definition in #ifdef CONFIG_OF, so it's not unusual.
>=20
> It's the standard solution, it's just not as clean as would be ideal :/=


The ifdef would be preferred if the driver could work in non DT boot (to
save few bytes) but since it is not the case here:

https://lore.kernel.org/alsa-devel/20200928074330.13029-1-peter.ujfalusi@=
ti.com/

Not much point to size optimize for randconfig builds ;)

- P=E9ter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki