Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3550110pxk;
        Mon, 28 Sep 2020 23:03:20 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxIqh4+2BA+QLtjenr2YaBdW8L2o99sxJf5Z/uCHi4e639XhNlKrRMPm0vjbXqDcrSsGP1i
X-Received: by 2002:aa7:c444:: with SMTP id n4mr1510404edr.200.1601359400352;
        Mon, 28 Sep 2020 23:03:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601359400; cv=none;
        d=google.com; s=arc-20160816;
        b=uM2mWdcvGlOqwHnIuHX9zCQaidddeN7YQfZuOWge1iiuFoWsXU6IqrQ1WlKgcpBR82
         iuoSgWvuP73IibNmtbWtcJLEiHKLvzaX3bhrtTaarx1i620kGWIpE1Sv88bDZ0o45edB
         fHZQQihaPBrzPGNj390wpOZEWqD26WJ1DrP/qOIez9l8HpaqYQGG51FA9XzSV8FNkE0w
         6Y8cSvZmNHq9fTNTRUx9u8EbSoHrKnsijI76cPRDP37lNJ3GDXj0D5CnxA/ynM/LfPMl
         zvTzxd6HQA0kDRxy980AKCOEyYgmz6Tz+MT92JhXrKOfBi8LYFnH2Ekn7y+k1wbrix6u
         3Mcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=s1n4fxUnOrXqu7iO06sSwSUoafpNw5JWrX09ZriSJ6w=;
        b=nCtH3SI/k4Slqs5jDjmZZ25bk7sdIiny6xQvN3kSOs5Ug4f0uC027cQZtS0xcZvFQk
         StV8IoPchhq+sdm1zJjxAlvxy3mWw/TNFex4d9pkU39ZHjCJBJWb4K4HHb0HdqeDBFwb
         lIFqe19IAG769XuF5ARXb+LjY1HhbI4spVrbzWGnvWnuKHGCHRuqe/dEi7Cl8Ft2n0yI
         fBtaaKT9+hrtj5+2A2w3zDTLPe1748v1gb9wGFdORZgGoBt1ftzwaHvxwK49drqADF0N
         wyzX49JJHAJWQmKLfBeJbdaehccY5h5kPan5WGQnqTGFD6g8sCoPrtgCqgfO6zif7Z+J
         jNAg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=B7cTZFwv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id of21si1974297ejb.345.2020.09.28.23.02.57;
        Mon, 28 Sep 2020 23:03:20 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=B7cTZFwv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727522AbgI2GBt (ORCPT <rfc822;sbrunau@gmail.com> + 99 others);
        Tue, 29 Sep 2020 02:01:49 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:18603 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725355AbgI2GBs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Sep 2020 02:01:48 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f72cd9a0004>; Mon, 28 Sep 2020 23:00:58 -0700
Received: from mtl-vdi-166.wap.labs.mlnx (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 29 Sep
 2020 06:01:46 +0000
Date:   Tue, 29 Sep 2020 09:01:42 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Leon Romanovsky <leonro@nvidia.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <virtualization@lists.linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jason Wang <jasowang@redhat.com>,
        Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build
 errors
Message-ID: <20200929060142.GA120395@mtl-vdi-166.wap.labs.mlnx>
References: <73f7e48b-8d16-6b20-07d3-41dee0e3d3bd@infradead.org>
 <20200918082245.GP869610@unreal>
 <20200924052932-mutt-send-email-mst@kernel.org>
 <20200924102413.GD170403@mtl-vdi-166.wap.labs.mlnx>
 <20200925061959-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200925061959-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1601359258; bh=s1n4fxUnOrXqu7iO06sSwSUoafpNw5JWrX09ZriSJ6w=;
        h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:
         Content-Type:Content-Disposition:In-Reply-To:User-Agent:
         X-Originating-IP:X-ClientProxiedBy;
        b=B7cTZFwvFf76FTc/g/Ys1cglEtwHgufmhfFn7BYTLj1AF83c4NqrkPGEnL4Vhg/yG
         LYbejwCA9lyVXrnoAf274Db1usjswzJIuTr/Eyf5URW4izcj9j2tk1qJryP8kmfxs1
         xhJlHbKCzdqdviWqdcVe2sOK8BneC69mYO91YweTy+4qj1tJswR2W6uLFYmr7Snk/R
         1SvgOV6oj264ehDJXQ9IKMRG7qmiZS06Exnl0DCk+R6+/882Ab5N4DeiIlYD1LKujA
         IXt6ItLxD5E0O5Nkd5+18OO8Kx1Rx3ee20RWWnPdlzDbOT8cUKOk2Ks/UKokNV+Vz0
         JvqWFubIjSQDA==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 25, 2020 at 06:20:45AM -0400, Michael S. Tsirkin wrote:
> > > 
> > > Hmm other drivers select VHOST_IOTLB, why not do the same?
> > 
> > I can't see another driver doing that.
> 
> Well grep VHOST_IOTLB and you will see some examples.

$ git grep -wn VHOST_IOTLB
drivers/vhost/Kconfig:2:config VHOST_IOTLB
drivers/vhost/Kconfig:11:       select VHOST_IOTLB
drivers/vhost/Kconfig:18:       select VHOST_IOTLB

What am I missing here?

> > Perhaps I can set dependency on
> > VHOST which by itself depends on VHOST_IOTLB?
> 
> VHOST is processing virtio in the kernel. You don't really need that
> for mlx, do you?
> 
> > > 
> > > 
> > > > >  	help
> > > > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > > > >
> > > 
>