Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Sep 2020 09:32:13 +0200
From:   Greg KH <greg@kroah.com>
To:     miaoqinglang <miaoqinglang@huawei.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the tty tree
Message-ID: <20200929073213.GA409833@kroah.com>
References: <20200929160111.18719071@canb.auug.org.au>
 <2e36e978-1276-6b86-3956-4346fc04093f@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2e36e978-1276-6b86-3956-4346fc04093f@huawei.com>
Precedence: bulk

On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote:
> 
> 
> 在 2020/9/29 14:01, Stephen Rothwell 写道:
> > Hi all,
> > 
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
> > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable]
> >    806 |  int ret, id, irq;
> >        |      ^~~
> > 
> > Introduced by commit
> > 
> >    b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()")
> > 
> Hi Greg,
> 
> Sorry about the noise for remaining the unused variable 'ret' in commit
> b63537020db3.
> 
> Should I send another patch to clean up this warning or send another v2
> patch instead?

A fix-up patch would be best, as this is already in my tree.

thanks,

greg k-h