Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3596239pxk;
        Tue, 29 Sep 2020 00:44:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzd38edn3bv/RplWYmWIUGqV1/FwWEQ7PZBO+YHNb5dMWT3T223TijHzwOP/S1F3aH7M0Hp
X-Received: by 2002:a17:906:4b4a:: with SMTP id j10mr2587039ejv.498.1601365463207;
        Tue, 29 Sep 2020 00:44:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601365463; cv=none;
        d=google.com; s=arc-20160816;
        b=ZiBjmyWbgFW0BmowGuIF2fN8G2a/CzKtkMKA5V8gviXyn9gyMkczEaWiNcHwlUrPv3
         2MBv/8X72AnrPRNSIIUSkuOR5MhALDPCWHtlyoGXtADfXZQXrWMYZLUvnxK0nTOsi5eb
         JKA1Pe5na1tLalp5R20l69gLhm9DAT03j5TT96HvkXvrAUV5DI4JNH9ZBIHCs2tQdvjR
         bKLoFNjTLczQof+aPJIUazAwxN6IoFfWN0ZI5o7OC2Bm0VNle1eS5eeo1N8lKcZwB2Cz
         f/dYVx3qji82rku73gB1QXfeamW+2r71tctVmMt02O1o4y30Yj36OPLGSq5xKHhaTpsw
         Czpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=khNyUg6fCBHz2WjAbLMQyLYkEJvYeDmjiMJT4IcmDR4=;
        b=EIkc7hDxF6QAoFlX9kns9Ld2JGItF8RHZl5NvOKx/Jp0aO5QZcz/PpDMGsEvUAciGX
         Po5v7E/MuuvUxosRdCPEL2Q4ZqrqDmPbj/3BTxuSjRD+WmyXoG23klBwg2XnnD1ZnEUJ
         hvCmoZfqrPMF79l6zWfPWykKt2G+wYNBogFDObsM3RcGFdzvG45BTpJ5cbZecc+w4ZCI
         UzWa2mkPynZVs4+8Vn6W8oqU2T2x9g3N+Mm5M0FBRtE8HVwhAudmuc05o9vK40wNy5dP
         cRGwNnPUzNXWE/GfHC1ufyFbpVQCqfMG8f4V5biJIbt41wV+9VLpSEYFETsFsn/TuUZa
         xZZw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=n1Ox6h0L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g9si144416edy.513.2020.09.29.00.44.00;
        Tue, 29 Sep 2020 00:44:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=n1Ox6h0L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726431AbgI2Hmy (ORCPT <rfc822;sbrunau@gmail.com> + 99 others);
        Tue, 29 Sep 2020 03:42:54 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10874 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725554AbgI2Hmy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Sep 2020 03:42:54 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f72e5710000>; Tue, 29 Sep 2020 00:42:41 -0700
Received: from mtl-vdi-166.wap.labs.mlnx (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 29 Sep
 2020 07:42:52 +0000
Date:   Tue, 29 Sep 2020 10:42:48 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     <jasowang@redhat.com>, <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <elic@nvidia.com>
Subject: Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a
 distinct module
Message-ID: <20200929074248.GA123696@mtl-vdi-166.wap.labs.mlnx>
References: <20200924143231.GA186492@mtl-vdi-166.wap.labs.mlnx>
 <20200928155448-mutt-send-email-mst@kernel.org>
 <20200929062026.GB120395@mtl-vdi-166.wap.labs.mlnx>
 <20200929022430-mutt-send-email-mst@kernel.org>
 <20200929063433.GC120395@mtl-vdi-166.wap.labs.mlnx>
 <20200929025038-mutt-send-email-mst@kernel.org>
 <20200929065744.GE120395@mtl-vdi-166.wap.labs.mlnx>
 <20200929031348-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200929031348-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1601365361; bh=khNyUg6fCBHz2WjAbLMQyLYkEJvYeDmjiMJT4IcmDR4=;
        h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:
         Content-Type:Content-Disposition:In-Reply-To:User-Agent:
         X-Originating-IP:X-ClientProxiedBy;
        b=n1Ox6h0L1r6zOGQpGzRyQfSzRq3NzlDT35HuIqTIFBGQgtpjIQVsDtbeflwSaQJ6K
         XkVDzlEe31USSyJKRh7tk4xxdTAuRRA0x4cx+zMnrhjodwWqTj+c3M7fQER3Kn1ACY
         7CuVNm0Ye7x0rMtuCeOA4zmgij1kdii+MiYBUyDgDKoWugX9H6E+0euCubuykyP7jV
         8wHDiakvHVmXta6n3mBT9KDPzKUO+hm4W3oEHGWRoRDqbpXcNhG/LawykCdM48Yg2m
         HqbXV439INGTKl1HpYlDyGsexuvPc+zwHktE0xNSfJIpcrgvs4qI2nFTPuZPi/4ZSQ
         sOoSVd7Oz71Lg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 29, 2020 at 03:17:05AM -0400, Michael S. Tsirkin wrote:
> > 
> > Use "select MLX5_CORE"
> > instead of "depends on MLX5_CORE"
> > 
> > Wasn't this agreed upon?
> 
> Hmm I don't know. I recall a similar discussion around VHOST_IOTLB.
> That's different ...

I see.

> 
> I see
> 
> [linux]$ git grep MLX5_CORE|grep depends
> drivers/infiniband/hw/mlx5/Kconfig:     depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on NETDEVICES && ETHERNET && INET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN && RFS_ACCEL
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN && NET_SWITCHDEV
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN && DCB
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig:        depends on MLX5_CORE_EN && MLX5_ESWITCH
> drivers/vdpa/Kconfig:   depends on MLX5_CORE
> 
> and no selects of this symbol, I guess you are saying you are changing everything
> else to select - is that right? Then I guess vdpa should follow suit ...
> 

No, I will leave that and will discuss internally if/who/when will do
this.